Avoid requesting features in CCR

Author: henrymercer

lib/analyze-action.js

@@ -4,6 +4,7 @@ import * as path from "path";
 import test, { ExecutionContext } from "ava";
 
 import * as defaults from "./defaults.json";
+import { EnvVar } from "./environment";
 import {
   Feature,
   featureConfig,
@@ -39,27 +40,37 @@ const testRepositoryNwo = parseRepositoryNwo("github/example");
 
 test(`All features are disabled if running against GHES`, async (t) => {
   await withTmpDir(async (tmpDir) => {
-    const loggedMessages = [];
+    const loggedMessages: LoggedMessage[] = [];
     const features = setUpFeatureFlagTests(
       tmpDir,
       getRecordingLogger(loggedMessages),
       { type: GitHubVariant.GHES, version: "3.0.0" },
     );
 
-    for (const feature of Object.values(Feature)) {
-      t.deepEqual(
-        await getFeatureIncludingCodeQlIfRequired(features, feature),
-        featureConfig[feature].defaultValue,
-      );
-    }
+    await assertAllFeaturesHaveDefaultValues(t, features);
+    assertLoggedMessage(
+      t,
+      loggedMessages,
+      "Not running against github.com. Using default values for all features.",
+    );
+  });
+});
 
-    t.assert(
-      loggedMessages.find(
-        (v: LoggedMessage) =>
-          v.type === "debug" &&
-          v.message ===
-            "Not running against github.com. Disabling all toggleable features.",
-      ) !== undefined,
+test(`All features use default values if running in CCR`, async (t) => {
+  await withTmpDir(async (tmpDir) => {
+    const loggedMessages: LoggedMessage[] = [];
+    const features = setUpFeatureFlagTests(
+      tmpDir,
+      getRecordingLogger(loggedMessages),
+    );
+
+    process.env[EnvVar.ANALYSIS_KEY] = "dynamic/copilot-pull-request-reviewer";
+
+    await assertAllFeaturesHaveDefaultValues(t, features);
+    assertLoggedMessage(
+      t,
+      loggedMessages,
+      "Feature flags are not supported in Copilot Code Review. Using default values for all features.",
     );
   });
 });
@@ -542,6 +553,30 @@ test("non-legacy feature flags should not start with codeql_action_", async (t)
   }
 });
 
+async function assertAllFeaturesHaveDefaultValues(
+  t: ExecutionContext<unknown>,
+  features: FeatureEnablement,
+) {
+  for (const feature of Object.values(Feature)) {
+    t.deepEqual(
+      await getFeatureIncludingCodeQlIfRequired(features, feature),
+      featureConfig[feature].defaultValue,
+    );
+  }
+}
+
+function assertLoggedMessage(
+  t: ExecutionContext<unknown>,
+  loggedMessages: LoggedMessage[],
+  expectedMessage: string,
+) {
+  t.assert(
+    loggedMessages.find(
+      (v: LoggedMessage) => v.type === "debug" && v.message === expectedMessage,
+    ) !== undefined,
+  );
+}
+
 function assertAllFeaturesUndefinedInApi(
   t: ExecutionContext<unknown>,
   loggedMessages: LoggedMessage[],

lib/autobuild-action.js

@@ -3,6 +3,7 @@ import * as path from "path";
 
 import * as semver from "semver";
 
+import { isCCR } from "./actions-util";
 import { getApiClient } from "./api-client";
 import type { CodeQL } from "./codeql";
 import * as defaults from "./defaults.json";
@@ -664,7 +665,14 @@ class GitHubFeatureFlags {
     // Do nothing when not running against github.com
     if (!supportsFeatureFlags(this.gitHubVersion.type)) {
       this.logger.debug(
-        "Not running against github.com. Disabling all toggleable features.",
+        "Not running against github.com. Using default values for all features.",
+      );
+      this.hasAccessedRemoteFeatureFlags = false;
+      return {};
+    }
+    if (isCCR()) {
+      this.logger.debug(
+        "Feature flags are not supported in Copilot Code Review. Using default values for all features.",
       );
       this.hasAccessedRemoteFeatureFlags = false;
       return {};