feat: add pre-action steps and use double-colon to Makefile (#15)

* feat: add pre-action steps and use double-colon to Makefile

This adds pre-action targets for most targets and also used double-colon to allow creating post-action steps.

* remove double-colon from targets fly-login and update-pipeline

* Update root/Makefile (PR feedback)

Co-authored-by: Mark Lee <malept@users.noreply.github.com>

* remove newline

Co-authored-by: Mark Lee <malept@users.noreply.github.com>

Author: vk-outreach

root/Makefile

@@ -35,14 +35,29 @@ BASE_TEST_ENV       ?= GOPROXY=$(GOPROXY) GOPRIVATE=$(GOPRIVATE) OUTREACH_ACCOUN
 .PHONY: default
 default: build
 
+# All the pre-action steps are bunched together here.
+.PHONY: pre-release pre-build pre-test pre-coverage pre-integration pre-e2e pre-benchmark pre-gogenerate pre-devserver pre-debug pre-docker-build pre-fmt
+pre-release::
+pre-build::
+pre-test::
+pre-coverage::
+pre-integration::
+pre-e2e::
+pre-benchmark::
+pre-gogenerate::
+pre-devserver::
+pre-debug::
+pre-docker-build::
+pre-fmt::
+
 ## release:         tag a new release with goreleaser
 .PHONY: release
-release:
+release:: pre-release
 	@# Create a tag for our version
 	@git tag -d "$(APP_VERSION)" >&2 || true
 	@git tag "$(APP_VERSION)" >&2
 	@./.bootstrap/shell/gobin.sh github.com/goreleaser/goreleaser@v0.157.0 release --skip-publish --rm-dist
-	@# Delete the tag once we're done.
+	@# Delete the tag once we are done.
 	@git tag -d "$(APP_VERSION)" >&2
 
 ## help             show this help
@@ -62,34 +77,34 @@ pre-commit: fmt
 
 ## build:           run codegen and build application binary
 .PHONY: build
-build: gobuild
+build:: pre-build gobuild
 
 ## test:            run unit tests
 .PHONY: test
-test:
+test:: pre-test
 	$(BASE_TEST_ENV) ./.bootstrap/shell/test.sh
 
 ## coverage:        generate code coverage
 .PHONY: coverage
-coverage:
+coverage:: pre-coverage
 	 WITH_COVERAGE=true GOPROXY=$(GOPROXY) GOPRIVATE=$(GOPRIVATE) ./.bootstrap/shell/test.sh
 	 go tool cover --html=/tmp/coverage.out
 
 ## integration:     run integration tests
 .PHONY: integration
-integration:
+integration:: pre-integration
 	TEST_TAGS=${TEST_TAGS} $(BASE_TEST_ENV) ./.bootstrap/shell/test.sh
 
 ## e2e:             run e2e tests
 .PHONY: e2e
-e2e:
+e2e:: pre-e2e
 	@devenv --skip-update status -q || \
 		(echo "Starting developer environment"; set -x; devenv --skip-update provision ${E2E_ARGS})
 	TEST_TAGS=or_test,or_e2e $(BASE_TEST_ENV) MY_NAMESPACE=$(E2E_NAMESPACE) MY_POD_SERVICE_ACCOUNT=$(E2E_SERVICE_ACCOUNT) OUTREACH_DOMAIN=$(OUTREACH_DOMAIN) ./.bootstrap/shell/test.sh
 
 ## benchmark:       run benchmarks
 .PHONY: benchmark
-benchmark:
+benchmark:: pre-benchmark
 	BENCH_FLAGS=${BENCH_FLAGS} TEST_TAGS=${TEST_TAGS} $(BASE_TEST_ENV) ./.bootstrap/shell/test.sh | tee /tmp/benchmark.txt
 	@$(LOG) info "Results of benchmarks: "
 	./.bootstrap/shell/gobin.sh golang.org/x/perf/cmd/benchstat /tmp/benchmark.txt
@@ -102,7 +117,7 @@ dep:
 
 ## gogenerate:      run go codegen
 .PHONY: gogenerate
-gogenerate: check-deps
+gogenerate:: pre-gogenerate check-deps
 	@$(LOG) info "Running gogenerate"
 	@GOPROXY=$(GOPROXY) GOPRIVATE=$(GOPRIVATE) $(GO) generate ./...
 
@@ -119,27 +134,27 @@ grpcui:
 	./.bootstrap/shell/grpcui.sh localhost:5000
 ## devserver:       run the service
 .PHONY: devserver
-devserver: build
+devserver:: pre-devserver build
 	if [[ -z $$SKIP_DEVCONFIG ]]; then ./.bootstrap/shell/devconfig.sh; fi
 	OUTREACH_ACCOUNTS_BASE_URL=$(ACCOUNTS_URL) MY_NAMESPACE=$(E2E_NAMESPACE) OUTREACH_DOMAIN=$(OUTREACH_DOMAIN) $(BINDIR)/$(BIN_NAME)
 
 ## debug:           run the service via delve
 .PHONY: debug
-debug: build
+debug:: pre-debug build
 	if [[ -z $$SKIP_DEVCONFIG ]]; then ./.bootstrap/shell/devconfig.sh; fi
 	OUTREACH_ACCOUNTS_BASE_URL=$(ACCOUNTS_URL) MY_NAMESPACE=$(E2E_NAMESPACE) OUTREACH_DOMAIN=$(OUTREACH_DOMAIN) ./.bootstrap/shell/debug.sh
 
 ## docker-build:    build docker image for dev environment
 .PHONY: docker-build
-docker-build:
+docker-build:: pre-docker-build
 	@echo " ===> building docker image <==="
 	@ssh-add -L
 	@echo " ===> If you run into credential issues, ensure that your key is in your SSH agent (ssh-add <ssh-key-path>) <==="
 	DOCKER_BUILDKIT=1 docker build --ssh default -t gcr.io/outreach-docker/$(APP) -f deployments/$(APP)/Dockerfile . --build-arg VERSION=${APP_VERSION}
 
 ## fmt:             run source code formatters
 .PHONY: fmt
-fmt:
+fmt:: pre-fmt
 	@./.bootstrap/shell/fmt.sh
 
 ## fly-login:       log into concourse