Skip to content

Commit 569b2a8

Browse files
authored
Merge branch 'dev' into 387-ped-phasing2
2 parents a9e1a98 + dfe9082 commit 569b2a8

File tree

11 files changed

+49
-199
lines changed

11 files changed

+49
-199
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3434
- [#954](https://github.com/genomic-medicine-sweden/nallo/pull/954) - Changed to topic versions in `HIPHASE`
3535
- [#957](https://github.com/genomic-medicine-sweden/nallo/pull/957) - Moved requirement of `--somalier_sites` to `--skip_sex_check` instead of `--skip_alignment` since it is not needed for the alignment
3636
- [#959](https://github.com/genomic-medicine-sweden/nallo/pull/959) - Updated PR template
37+
- [#964](https://github.com/genomic-medicine-sweden/nallo/pull/957) - Limit `--snv_calling_processes` to `1` for sentieon due to issues with duplicated variants (see #926)
3738

3839
### Removed
3940

4041
- [#950](https://github.com/genomic-medicine-sweden/nallo/pull/950) - Stray TODO statement
4142
- [#951](https://github.com/genomic-medicine-sweden/nallo/pull/951) - Removed unused `SOMALIER_PED` import
43+
- [#961](https://github.com/genomic-medicine-sweden/nallo/pull/961) - Removed `docs/CITATIONS.md` since the information is available in the MultiQC report
4244

4345
### Fixed
4446

4547
- [#939](https://github.com/genomic-medicine-sweden/nallo/pull/939) - Fixed nf-test not triggering on changes to `conf/`, which can affect pipeline outputs
4648
- [#960](https://github.com/genomic-medicine-sweden/nallo/pull/960) - Fixed crash when preparing for chromograph while skipping annotating variants
49+
- [#964](https://github.com/genomic-medicine-sweden/nallo/pull/957) - Fix sentieon spanning deletion calls crashing most_severe_consequence script due to missing CSQ
4750

4851
### Parameters
4952

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,4 +112,4 @@ This pipeline uses code and infrastructure developed and maintained by the [nf-c
112112
>
113113
> _Nat Biotechnol._ 2020 Feb 13. doi: [10.1038/s41587-020-0439-x](https://dx.doi.org/10.1038/s41587-020-0439-x).
114114
115-
An extensive list of references for the tools used by the pipeline can be found in the [`docs/CITATIONS.md`](docs/CITATIONS.md) file.
115+
An extensive list of references for the tools used by the pipeline can be found in the Software Versions section of the MultiQC report generated with the pipeline.

conf/modules/annotate_snvs.config

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,11 @@ process {
2929
ext.args = { [
3030
'--output-type z',
3131
'--write-index=tbi',
32-
"${params.pre_vep_snv_filter_expression}"
32+
"${params.pre_vep_snv_filter_expression}",
33+
// Drop spanning deletion ("*") alleles from Sentieon.
34+
// They are redundant (covered by upstream DELs) and break VEP annotation,
35+
// causing downstream MSC/PLI scripts to crash.
36+
params.variant_caller == 'sentieon' ? '-e \'ALT="*"\'' : ''
3337
].join(" ") }
3438
}
3539

docs/CITATIONS.md

Lines changed: 0 additions & 155 deletions
This file was deleted.

docs/parameters.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ Workflow options specific to genomic-medicine-sweden/nallo
151151
| `methbat_female_label` | Label used for female samples in methbat profile. | `string` | FEMALE | | |
152152
| `modkit_modified_bases` | Modkit modified bases, separated by space. E.g. '5mC 5hmC' | `string` | 5mC | | |
153153
| `alignment_processes` | If alignment_processes is bigger than 1, input files will be split and aligned in parallel to reduce processing time. | `integer` | 8 | | |
154-
| `snv_calling_processes` | If snv_calling_processes is bigger than 1, short variant calling will be done in parallel to reduce processing time. | `integer` | 13 | | |
154+
| `snv_calling_processes` | If snv_calling_processes is bigger than 1, short variant calling will be done in parallel to reduce processing time. Must be `1` when `--snv_caller sentieon` is used. | `integer` | 13 | | |
155155
| `vep_cache_version` | VEP cache version | `integer` | 110 | | |
156156
| `vep_plugin_files` | Path to a CSV/TSV/JSON/YAML file with vep_files as header, and then paths to vep plugin files. Paths to pLI_values.txt and LoFtool_scores.txt are required. | `string` | | | |
157157
| `force_sawfish_joint_call_single_samples` | Force sawfish to run joint-call on single samples instead of all samples from the same family. This effectively causes SVDB to merge the samples into family VCFs instead. | `boolean` | | | |

docs/usage.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,8 @@ This subworkflow depends on the alignment subworkflow, and requires PARs.
188188

189189
By default the pipeline uses [DeepVariant](https://github.com/google/deepvariant) for long-read SNV calling. To enable [Sentieon DNAscope Long Read](https://github.com/Sentieon/sentieon-cli/blob/main/docs/dnascope-longread.md), set `--snv_caller sentieon`. Make the Sentieon license available by adding a base64-encoded license string to the Nextflow secrets store (`nextflow secrets set SENTIEON_LICENSE_BASE64 ...`) or by exporting the same variable before running the pipeline.
190190

191+
When using Sentieon, `--snv_calling_processes` must be set to `1`.
192+
191193
| Parameter | Description |
192194
| ------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------- |
193195
| `par_regions` | A BED file with PAR regions (e.g. [GRCh38_PAR.bed](https://storage.googleapis.com/deepvariant/case-study-testdata/GRCh38_PAR.bed)). Used by DeepVariant. |

mkdocs.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ nav:
99
- Usage: usage.md
1010
- Output: output.md
1111
- Parameters: parameters.md
12-
- Citations: CITATIONS.md
1312

1413
theme:
1514
name: material

0 commit comments

Comments
 (0)