Remove the duplicated PnL text in perpetual position details

- position_details built the PnL text and tone by hand, repeating pnl_text; 9d04595 had to apply the same initial-margin fix in both places. It now calls pnl_text, whose tone is GemValueTone::of(pnl) as before.
- security transaction scan tests compared a bool with assert_eq!, which fails workspace clippy (bool_assert_comparison).

Author: gemcoder21

core/crates/security/src/transaction_scan/evaluate.rs

@@ -138,7 +138,7 @@ mod tests {
 
         assert_eq!(result.scan.is_malicious, Some(true));
         assert_eq!(result.scan.malicious_website.as_deref(), Some("https://bnbdaily.finance/path"));
-        assert_eq!(result.scan.is_scan_complete, true);
+        assert!(result.scan.is_scan_complete);
         assert_eq!(result.detections[0].provider, ScanProvider::Internal);
         assert_eq!(result.new_verdicts, vec![]);
     }
@@ -150,7 +150,7 @@ mod tests {
 
         let unmatched = evaluate_transaction_scan(&input, plan_transaction_scan(&input, &HashSet::from([ScanProvider::Internal])), vec![]);
         assert_eq!(unmatched.scan.is_malicious, Some(false));
-        assert_eq!(unmatched.scan.is_scan_complete, false);
+        assert!(!unmatched.scan.is_scan_complete);
 
         input.payload.website = Some("https://bnbdaily.finance/path".to_string());
         let disabled_provider = evaluate_transaction_scan(&input, plan_transaction_scan(&input, &HashSet::new()), vec![]);

core/gemstone/src/services/perpetual/rules.rs

@@ -790,13 +790,7 @@ pub fn details(perpetual: &Perpetual, asset: &Asset, positions: Vec<PerpetualPos
 fn position_details(asset: &Asset, position: &PerpetualPosition) -> Vec<GemPerpetualPositionDetail> {
     let amount = |title: GemListRowTitle, amount: GemFormattedNumber, info: Option<GemInfoTopic>| GemListRow::Amount { title, amount, info };
     let label = |title: GemListRowTitle, text: GemLocalizedText, tone: GemValueTone, info: Option<GemInfoTopic>| GemListRow::Label { title, text, tone, info, progress: false };
-    let pnl = GemLocalizedText::Pnl {
-        amount: GemFormattedNumber::signed_usd(position.pnl),
-        percent: GemFormattedNumber::percentage(
-            PriceChangeCalculator::pnl_percentage(position.pnl, initial_margin(position.entry_price, position.size, position.leverage)),
-            GemPercentageStyle::Signed,
-        ),
-    };
+    let (pnl, pnl_tone) = pnl_text(position.pnl, initial_margin(position.entry_price, position.size, position.leverage));
     let margin = GemLocalizedText::Margin {
         amount: GemFormattedNumber::usd(position.margin_amount),
         margin_type: position.margin_type.clone(),
@@ -821,7 +815,7 @@ fn position_details(asset: &Asset, position: &PerpetualPosition) -> Vec<GemPerpe
         ),
     };
     [
-        (GemPerpetualPositionDetailRow::Pnl, Some(label(GemListRowTitle::Pnl, pnl, GemValueTone::of(position.pnl), None))),
+        (GemPerpetualPositionDetailRow::Pnl, Some(label(GemListRowTitle::Pnl, pnl, pnl_tone, None))),
         (
             GemPerpetualPositionDetailRow::Autoclose,
             Some(GemListRow::Lines {