kernel: use IS_MUTABLE_OBJ in UNB_LIST/ASS_LIST/ASSS_LIST

Author: fingolfin

src/lists.h

@@ -465,9 +465,7 @@ void UNBB_LIST(Obj list, Obj pos);
 EXPORT_INLINE void UNB_LIST(Obj list, Int pos)
 {
     GAP_ASSERT(pos > 0);
-    UInt tnum = TNUM_OBJ(list);
-    if (FIRST_LIST_TNUM <= tnum && tnum <= LAST_LIST_TNUM &&
-        (tnum & IMMUTABLE)) {
+    if (!IS_MUTABLE_OBJ(list)) {
         ErrorMayQuit("List Unbind: <list> must be a mutable list", 0, 0);
     }
     (*UnbListFuncs[TNUM_OBJ(list)])(list, pos);
@@ -502,9 +500,7 @@ EXPORT_INLINE void ASS_LIST(Obj list, Int pos, Obj obj)
 {
     GAP_ASSERT(pos > 0);
     GAP_ASSERT(obj != 0);
-    UInt tnum = TNUM_OBJ(list);
-    if (FIRST_LIST_TNUM <= tnum && tnum <= LAST_LIST_TNUM &&
-        (tnum & IMMUTABLE)) {
+    if (!IS_MUTABLE_OBJ(list)) {
         ErrorMayQuit("List Assignment: <list> must be a mutable list", 0, 0);
     }
     (*AssListFuncs[TNUM_OBJ(list)])(list, pos, obj);
@@ -550,9 +546,7 @@ EXPORT_INLINE void ASSS_LIST(Obj list, Obj poss, Obj objs)
     GAP_ASSERT(IS_POSS_LIST(poss));
     GAP_ASSERT(IS_DENSE_LIST(objs));
     GAP_ASSERT(LEN_LIST(poss) == LEN_LIST(objs));
-    UInt tnum = TNUM_OBJ(list);
-    if (FIRST_LIST_TNUM <= tnum && tnum <= LAST_LIST_TNUM &&
-        (tnum & IMMUTABLE)) {
+    if (!IS_MUTABLE_OBJ(list)) {
         ErrorMayQuit("List Assignments: <list> must be a mutable list", 0, 0);
     }
     (*AsssListFuncs[TNUM_OBJ(list)])(list, poss, objs);

tst/testinstall/kernel/lists.tst

@@ -29,7 +29,7 @@ Error, no 1st choice method found for `IsBound[]' on 2 arguments
 
 #
 gap> UNB_LIST(1,2);
-Error, Unbind: <list> must be a list (not the integer 1)
+Error, List Unbind: <list> must be a mutable list
 gap> UNB_LIST([1],1);
 gap> UNB_LIST([1],2);
 
@@ -79,7 +79,7 @@ gap> ELMS_LIST_DEFAULT([1,2,3],[1..2]);
 
 #
 gap> ASS_LIST(1,1,1);
-Error, List Assignments: <list> must be a list (not the integer 1)
+Error, List Assignment: <list> must be a mutable list
 gap> l:=[];; ASS_LIST(l,1,1); l;
 [ 1 ]
 
@@ -89,7 +89,7 @@ Error, List Assignments: <rhss> must be a dense list (not the integer 1)
 gap> ASSS_LIST([1],1,[1]);
 Error, List Assignments: <poss> must be a dense list of positive integers
 gap> ASSS_LIST(1,[1],[1]);
-Error, List Assignments: <list> must be a list (not the integer 1)
+Error, List Assignments: <list> must be a mutable list
 gap> l:=[];; ASSS_LIST(l,[1],[1]); l;
 [ 1 ]
 
@@ -99,7 +99,7 @@ Error, List Assignments: <rhss> must be a dense list
 gap> ASSS_LIST_DEFAULT([1],1,[1]);
 Error, List Assignments: <poss> must be a dense list of positive integers
 gap> ASSS_LIST_DEFAULT(1,[1],[1]);
-Error, List Assignments: <list> must be a list (not the integer 1)
+Error, List Assignment: <list> must be a mutable list
 gap> l:=[];; ASSS_LIST_DEFAULT(l,[1],[1]); l;
 [ 1 ]