feat(runkit): stop scaffolding runkit details because the service is dead

Author: travi

src/project-type/package/scaffolder.js

@@ -2,7 +2,6 @@ import deepmerge from 'deepmerge';
 import {info} from '@travi/cli-messages';
 import {dialects, mergeIntoExistingPackageJson} from '@form8ion/javascript-core';
 
-import {scaffold as scaffoldRunkit} from '../../runkit/index.js';
 import determinePackageAccessLevelFromProjectVisibility from '../publishable/access-level.js';
 import {scaffold as scaffoldPublishable} from '../publishable/index.js';
 import scaffoldPackageDocumentation from './documentation.js';
@@ -69,7 +68,6 @@ export default async function scaffoldPackageProjectType({
       }
     })
   ]);
-  const runkitResults = await scaffoldRunkit({projectRoot, packageName, visibility});
 
   return deepmerge.all([
     publishableResults,
@@ -81,7 +79,6 @@ export default async function scaffoldPackageProjectType({
         {summary: 'Publish pre-release versions to npm until package is stable enough to publish v1.0.0'}
       ]
     },
-    detailsForBuild,
-    runkitResults
+    detailsForBuild
   ]);
 }

src/project-type/package/scaffolder.test.js

@@ -4,15 +4,13 @@ import {beforeEach, describe, expect, it, vi} from 'vitest';
 import any from '@travi/any';
 import {when} from 'vitest-when';
 
-import {scaffold as scaffoldRunkit} from '../../runkit/index.js';
 import determinePackageAccessLevelFromProjectVisibility from '../publishable/access-level.js';
 import {scaffold as scaffoldPublishable} from '../publishable/index.js';
 import * as buildDetails from './build-details.js';
 import * as documentationScaffolder from './documentation.js';
 import scaffoldPackage from './scaffolder.js';
 
 vi.mock('@form8ion/javascript-core');
-vi.mock('../../runkit/index.js');
 vi.mock('../publishable/access-level.js');
 vi.mock('../publishable/index.js');
 vi.mock('./build-details.js');
@@ -37,7 +35,6 @@ describe('package project-type scaffolder', () => {
   const documentation = any.simpleObject();
   const decisions = any.simpleObject();
   const buildDetailsResults = any.simpleObject();
-  const runkitResults = any.simpleObject();
 
   beforeEach(() => {
     when(documentationScaffolder.default)
@@ -46,7 +43,6 @@ describe('package project-type scaffolder', () => {
     when(determinePackageAccessLevelFromProjectVisibility)
       .calledWith({projectVisibility: visibility})
       .thenReturn(packageAccessLevel);
-    when(scaffoldRunkit).calledWith({projectRoot, visibility, packageName}).thenReturn(runkitResults);
   });
 
   it('should scaffold details specific to a modern-js package', async () => {
@@ -76,8 +72,7 @@ describe('package project-type scaffolder', () => {
       ...publishableResults,
       ...buildDetailsResults,
       documentation,
-      nextSteps: commonNextSteps,
-      ...runkitResults
+      nextSteps: commonNextSteps
     });
     expect(mergeIntoExistingPackageJson).toHaveBeenCalledWith({
       projectRoot,
@@ -123,8 +118,7 @@ describe('package project-type scaffolder', () => {
       ...publishableResults,
       ...buildDetailsResults,
       documentation,
-      nextSteps: commonNextSteps,
-      ...runkitResults
+      nextSteps: commonNextSteps
     });
     expect(mergeIntoExistingPackageJson).toHaveBeenCalledWith({
       projectRoot,
@@ -165,8 +159,7 @@ describe('package project-type scaffolder', () => {
       ...publishableResults,
       ...buildDetailsResults,
       documentation,
-      nextSteps: commonNextSteps,
-      ...runkitResults
+      nextSteps: commonNextSteps
     });
     expect(mergeIntoExistingPackageJson).toHaveBeenCalledWith({
       projectRoot,
@@ -213,8 +206,7 @@ describe('package project-type scaffolder', () => {
       ...publishableResults,
       ...buildDetailsResults,
       documentation,
-      nextSteps: commonNextSteps,
-      ...runkitResults
+      nextSteps: commonNextSteps
     });
     expect(mergeIntoExistingPackageJson).toHaveBeenCalledWith({
       projectRoot,

test/integration/features/step_definitions/npm-steps.js

@@ -56,12 +56,11 @@ function assertThatPackageSpecificDetailsAreDefinedCorrectly(
   }
 
   if ('Public' === visibility) {
-    assert.equal(packageDetails.runkitExampleFilename, './example.js');
     assert.equal(packageDetails.publishConfig.access, 'public');
   } else {
-    assert.isUndefined(packageDetails.runkitExampleFilename);
     assert.deepEqual(packageDetails.publishConfig.access, 'restricted');
   }
+  assert.isUndefined(packageDetails.runkitExampleFilename);
 }
 
 function assertThatApplicationSpecificDetailsAreDefinedCorrectly(packageDetails, projectName) {