Fix Etherscan maxFeePerGas post data key#5147
Open
0xjc65eth wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the generated Etherscan provider output that still used
maxFeePerGsinstead ofmaxFeePerGaswhen normalizing transaction post data.The TypeScript source already has the correct key, but the built ESM/CommonJS/dist artifacts still had the typo, so
maxFeePerGaswas not quantity-normalized before being sent through the Etherscan API path.Closes #5080.
Testing
Ran small ESM and CommonJS smoke checks against
_getTransactionPostDatato confirm an EIP-1559 transaction withmaxFeePerGas: 1000000000nserializes as:I also attempted
npm run build-all, but the current checkout fails before this change with duplicatewindow/selfdeclarations betweenlib.dom.d.tsandsrc.ts/crypto/crypto-browser.ts, so I kept this PR to the generated files that contain the typo.