feat: add blockTimestamp to logs#5104
Open
andrevmatos wants to merge 2 commits into
Open
Conversation
Author
|
@ricmoo can you give a look at this one when possible, please? |
Author
|
Related: #5012 |
Added to JSON-RPC in ethereum/execution-apis#639
andrevmatos
force-pushed
the
feat/logs_block_timestamp
branch
from
01fa42e to
e8f3a33
Compare
andrevmatos
added a commit
to smartcontractkit/ccip-tools-ts
that referenced
this pull request
May 13, 2026
* ccip: fix caches and logs.blockTimestamp all 2026 EVM nodes return `blockTimestamp` inside logs payload for both `eth_getLogs` and `eth_getTransactionReceipt`; still, ethers doesn't include it in those returned objects; we fix this by hooking into some methods which get access to the raw payloads of those requests, and caching the result in Chain.getBlockTimestamp; see ethers-io/ethers.js#5104 Also, fix some caches, as micro-memoize's maxSize default=1 * prefer log.blockTimestamp over tx.timestamp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added to JSON-RPC in ethereum/execution-apis#639
Resolves: #1250 (comment)