Skip to content

Commit ef7af6d

Browse files
committed
fix CI
1 parent dc8ecd5 commit ef7af6d

8 files changed

Lines changed: 539 additions & 515 deletions

File tree

.github/workflows/ci.yml

Lines changed: 38 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,30 @@ concurrency:
1313
cancel-in-progress: true
1414

1515
jobs:
16+
build:
17+
name: "Build"
18+
runs-on: ubuntu-latest
19+
timeout-minutes: 10
20+
21+
steps:
22+
- uses: actions/checkout@v4
23+
- uses: pnpm/action-setup@v4
24+
- uses: actions/setup-node@v4
25+
with:
26+
node-version-file: package.json
27+
cache: pnpm
28+
- name: Install Dependencies
29+
run: pnpm install --frozen-lockfile
30+
- name: Build
31+
run: pnpm build
32+
- name: Upload Build Artifact
33+
uses: actions/upload-artifact@v4
34+
with:
35+
name: addon-build
36+
path: |
37+
dist
38+
declarations
39+
1640
lint:
1741
name: "Lints"
1842
runs-on: ubuntu-latest
@@ -57,6 +81,7 @@ jobs:
5781
floating:
5882
name: "Floating Dependencies"
5983
runs-on: ubuntu-latest
84+
needs: "build"
6085
timeout-minutes: 10
6186

6287
steps:
@@ -68,13 +93,20 @@ jobs:
6893
cache: pnpm
6994
- name: Install Dependencies
7095
run: pnpm install --no-lockfile
96+
- name: Download Build Artifact
97+
uses: actions/download-artifact@v4
98+
with:
99+
name: addon-build
100+
path: .
71101
- name: Run Tests
72102
run: pnpm test
73103

74104
try-scenarios:
75105
name: ${{ matrix.name }}
76106
runs-on: ubuntu-latest
77-
needs: "test"
107+
needs:
108+
- build
109+
- test
78110
timeout-minutes: 10
79111
strategy:
80112
fail-fast: false
@@ -93,6 +125,11 @@ jobs:
93125
94126
- name: Install Dependencies
95127
run: pnpm install --no-lockfile
128+
- name: Download Build Artifact
129+
uses: actions/download-artifact@v4
130+
with:
131+
name: addon-build
132+
path: .
96133
- name: Run Tests
97134
run: |
98135
pnpm test

.github/workflows/push-dist.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ jobs:
2828
cache: pnpm
2929
- name: Install Dependencies
3030
run: pnpm install --frozen-lockfile
31+
- name: Build
32+
run: pnpm build
3133
- uses: kategengler/put-built-npm-package-contents-on-branch@v2.0.0
3234
with:
3335
branch: dist

demo-app/templates/application.gts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import { tracked } from '@glimmer/tracking';
22
import { on } from '@ember/modifier';
33
import { pageTitle } from 'ember-page-title';
4-
// eslint-disable-next-line ember/no-at-ember-render-modifiers
5-
import { didInsert, didUpdate, willDestroy } from '@ember/render-modifiers';
4+
import { didInsert, didUpdate, willDestroy } from '#src/index.ts';
65

76
class DemoState {
87
@tracked insertedElements: string[] = [];

package.json

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
"lint:js:fix": "eslint . --fix",
4545
"lint:publish": "pnpm build && publint run --level error",
4646
"lint:types": "ember-tsc --noEmit",
47-
"prepare": "pnpm build",
4847
"prepack": "rollup --config",
4948
"start": "vite dev",
5049
"test": "vite build --mode=development --out-dir dist-tests && testem --file testem.cjs ci --port 0"
@@ -67,7 +66,7 @@
6766
"@embroider/macros": "^1.20.2",
6867
"@embroider/vite": "^1.7.2",
6968
"@eslint/js": "^9.39.4",
70-
"@glimmer/component": "^2.0.0",
69+
"@glimmer/component": "^2.1.1",
7170
"@glint/ember-tsc": "^1.5.0",
7271
"@glint/template": "^1.7.7",
7372
"@glint/tsserver-plugin": "^2.4.0",
@@ -87,16 +86,16 @@
8786
"eslint-plugin-import": "^2.32.0",
8887
"eslint-plugin-n": "^17.24.0",
8988
"globals": "^17.4.0",
90-
"prettier": "^3.8.1",
91-
"prettier-plugin-ember-template-tag": "^2.1.3",
89+
"prettier": "^3.8.2",
90+
"prettier-plugin-ember-template-tag": "^2.1.4",
9291
"publint": "^0.3.18",
9392
"qunit": "^2.25.0",
9493
"qunit-dom": "^3.5.0",
9594
"rollup": "^4.60.1",
96-
"testem": "^3.19.1",
95+
"testem": "^3.20.0",
9796
"typescript": "~6.0.2",
98-
"typescript-eslint": "^8.58.0",
99-
"vite": "^8.0.3"
97+
"typescript-eslint": "^8.58.1",
98+
"vite": "^8.0.8"
10099
},
101100
"packageManager": "pnpm@10.33.0+sha512.10568bb4a6afb58c9eb3630da90cc9516417abebd3fabbe6739f0ae795728da1491e9db5a544c76ad8eb7570f5c4bb3d6c637b2cb41bfdcdb47fa823c8649319",
102101
"publishConfig": {

0 commit comments

Comments
 (0)