Skip to content

Commit 9d9f17a

Browse files
Updated INP Ordering and Spacing (#915)
1 parent bbbfc2a commit 9d9f17a

7 files changed

Lines changed: 42 additions & 26 deletions

File tree

‎packages/docs/src/benchmarks/lighthouse-client-side-rendered-tests/LighthouseFrameworkClientRenderedVersionCharts.astro‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,19 @@ const interactionWorkData =
2929
{...prepareLighthouseClientSideRenderedTestsFcpMsHistory(versions)}
3030
/>
3131
{
32-
interactionWorkData.length > 0 ? (
32+
interactionData.length > 0 ? (
3333
<InteractionHistoryChart
34-
title="Client Interaction Work to Commit by Version"
35-
data={interactionWorkData}
36-
metric={INTERACTION_WORK}
34+
title="Client Interaction Breakdown by Version (Lighthouse)"
35+
data={interactionData}
3736
/>
3837
) : null
3938
}
4039
{
41-
interactionData.length > 0 ? (
40+
interactionWorkData.length > 0 ? (
4241
<InteractionHistoryChart
43-
title="Client Interaction Breakdown by Version (Lighthouse)"
44-
data={interactionData}
42+
title="Client Interaction Work to Commit by Version"
43+
data={interactionWorkData}
44+
metric={INTERACTION_WORK}
4545
/>
4646
) : null
4747
}

‎packages/docs/src/benchmarks/lighthouse-server-side-rendered-tests/LighthouseFrameworkServerRenderedVersionCharts.astro‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,19 @@ const interactionWorkData =
2929
{...prepareLighthouseServerSideRenderedTestsFcpMsHistory(versions)}
3030
/>
3131
{
32-
interactionWorkData.length > 0 ? (
32+
interactionData.length > 0 ? (
3333
<InteractionHistoryChart
34-
title="Server Interaction Work to Commit by Version"
35-
data={interactionWorkData}
36-
metric={INTERACTION_WORK}
34+
title="Server Interaction Breakdown by Version (Lighthouse)"
35+
data={interactionData}
3736
/>
3837
) : null
3938
}
4039
{
41-
interactionData.length > 0 ? (
40+
interactionWorkData.length > 0 ? (
4241
<InteractionHistoryChart
43-
title="Server Interaction Breakdown by Version (Lighthouse)"
44-
data={interactionData}
42+
title="Server Interaction Work to Commit by Version"
43+
data={interactionWorkData}
44+
metric={INTERACTION_WORK}
4545
/>
4646
) : null
4747
}

‎packages/docs/src/benchmarks/shared/InteractionBreakdownChart.astro‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,14 @@ const chart1Table = prepareInteractionBreakdownTable(chart1)
4040
]}
4141
defaultValue="chart"
4242
>
43-
<StackedBarChart slot="chart" {...chart1}>
43+
<StackedBarChart slot="chart" class="interaction-breakdown-chart" {...chart1}>
4444
<InteractionChartCaption slot="caption" {metric} />
4545
</StackedBarChart>
4646
<StatsTable slot="table" {...chart1Table} />
4747
</ViewSwitcher>
48+
49+
<style>
50+
.interaction-breakdown-chart {
51+
padding-bottom: 2rem;
52+
}
53+
</style>

‎packages/docs/src/benchmarks/shared/InteractionHistoryChart.astro‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ const valueOf = (datum: Props['data'][number], key: string) =>
2222
---
2323

2424
<StackedAreaChart
25+
class="interaction-history-chart"
2526
{title}
2627
data={data.map((datum) => ({
2728
name: datum.name,
@@ -40,3 +41,9 @@ const valueOf = (datum: Props['data'][number], key: string) =>
4041
>
4142
<InteractionChartCaption slot="caption" {title} {metric} />
4243
</StackedAreaChart>
44+
45+
<style>
46+
figure.interaction-history-chart {
47+
margin-block: 1.5rem 2.5rem;
48+
}
49+
</style>

‎packages/docs/src/benchmarks/shared/LighthouseRenderedInteractionCharts.astro‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,19 @@ const data = getRenderedInteractionBreakdownData(testsKey).sort(
2121
---
2222

2323
{
24-
work.length > 0 ? (
24+
data.length > 0 ? (
2525
<InteractionBreakdownChart
26-
title="Interaction Work to Commit"
27-
data={work}
28-
metric={INTERACTION_WORK}
26+
title="Interaction Breakdown (Lighthouse)"
27+
data={data}
2928
/>
3029
) : null
3130
}
3231
{
33-
data.length > 0 ? (
32+
work.length > 0 ? (
3433
<InteractionBreakdownChart
35-
title="Interaction Breakdown (Lighthouse)"
36-
data={data}
34+
title="Interaction Work to Commit"
35+
data={work}
36+
metric={INTERACTION_WORK}
3737
/>
3838
) : null
3939
}

‎packages/docs/src/components/StackedAreaChart.astro‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,17 @@ import { formatValue } from '../lib/chart'
33
import type { StackedAreaChartPayload } from '../lib/types'
44
import StatsTable from './StatsTable.astro'
55
6-
type Props = StackedAreaChartPayload
6+
type Props = StackedAreaChartPayload & { class?: string }
77
88
const {
9+
class: className,
910
title,
1011
data,
1112
series,
1213
valueFormat,
1314
yAxisLabel,
1415
totalLabel = 'Total',
16+
...attrs
1517
} = Astro.props
1618
const singleMeasurement = data.length === 1 ? data[0] : undefined
1719
const chartPayload = JSON.stringify({
@@ -28,7 +30,7 @@ function formatTotal(total: number | null) {
2830
}
2931
---
3032

31-
<figure class="stacked-area-chart">
33+
<figure {...attrs} class:list={['stacked-area-chart', className]}>
3234
{
3335
data.length < 2 ? (
3436
<>

‎packages/docs/src/components/StackedBarChart.astro‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,16 @@ interface Datum {
1111
values: Record<string, number>
1212
}
1313
interface Props {
14+
class?: string
1415
title: string
1516
series: Series[]
1617
data: Datum[]
1718
valueFormat?: ChartValueFormat
1819
}
19-
const { title, series, data, valueFormat = 'kb' } = Astro.props
20+
const { title, series, data, valueFormat = 'kb', ...attrs } = Astro.props
2021
---
2122

22-
<figure>
23+
<figure {...attrs}>
2324
<slot name="caption" />
2425
{
2526
!Astro.slots.has('caption') && (

0 commit comments

Comments
 (0)