@ilmalte Sure, feel free to work on it! Yes, this issue is just about SQLite.

First, you'll need to add support for it in the ADO.NET provider. Just follow what we do for float. Here's the code for reading values: (Note, there's a bit of duplication required in this method.)

efcore/src/Microsoft.Data.Sqlite.Core/SqliteValueReader.cs

Lines 202 to 205 in c983103

    
           if (typeof(T) == typeof(float)) 
        
           { 
        
               return (T)(object)GetFloat(ordinal); 
        
           }

And, here's the code for writing:

efcore/src/Microsoft.Data.Sqlite.Core/SqliteValueBinder.cs

Lines 161 to 165 in c983103

    
           else if (type == typeof(float)) 
        
           { 
        
               var value = (double)(float)_value; 
        
               BindDouble(value); 
        
           }

Then yeah, for the EF Core changes, the type mapper is the right place.

We should also update the scaffolding code which uses heuristics to determine the CLR type:

efcore/src/EFCore.Sqlite.Core/Scaffolding/Internal/SqliteDatabaseModelFactory.cs

Lines 696 to 707 in c983103

    
           if (_floatTypes.Contains(baseColumnType)) 
        
           { 
        
               if (min >= float.MinValue 
        
                   && max <= float.MaxValue) 
        
               { 
        
                   column["ClrType"] = typeof(float); 
        
                   continue; 
        
               } 
        
               _logger.OutOfRangeWarning(column.Name, table.Name, "float"); 
        
           }

	if (typeof(T) == typeof(float))
	{
	return (T)(object)GetFloat(ordinal);
	}

	else if (type == typeof(float))
	{
	var value = (double)(float)_value;
	BindDouble(value);
	}

	if (_floatTypes.Contains(baseColumnType))
	{
	if (min >= float.MinValue
	&& max <= float.MaxValue)
	{
	column["ClrType"] = typeof(float);

	continue;
	}

	_logger.OutOfRangeWarning(column.Name, table.Name, "float");
	}

Microsoft.Data.Sqlite: Support Half #30931

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions