Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Commit 90b94dd

Browse files
committed
fix the error Haproxy.cls_linked_services is assigned as a list
1 parent cc88e63 commit 90b94dd

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

haproxy/helper/cloud_link_helper.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,10 @@ def _get_linked_containers(cache, container_links):
6767

6868

6969
def get_linked_services(haproxy_links):
70-
linked_services = []
70+
linked_services = set()
7171
for link in haproxy_links.itervalues():
72-
if link["service_uri"] not in linked_services:
73-
linked_services.append(link["service_uri"])
74-
return linked_services
72+
linked_services.add(link["service_uri"])
73+
return set(linked_services)
7574

7675

7776
def get_service_links_str(haproxy_links):

tests/unit/helper/test_cloud_link_helper.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ def test_get_linked_containers(self):
112112
self.assertEqual([container_b, container_a], _get_linked_containers(cache, self.container_links))
113113

114114
def test_get_linked_service(self):
115-
self.assertEqual(['/api/app/v1/service/bc091010-0054-4cc6-9038-73ea1efc5b99/',
116-
'/api/app/v1/service/0d12900d-2ae8-4244-a9c0-48466347c08a/'],
115+
self.assertEqual(set(['/api/app/v1/service/bc091010-0054-4cc6-9038-73ea1efc5b99/',
116+
'/api/app/v1/service/0d12900d-2ae8-4244-a9c0-48466347c08a/']),
117117
get_linked_services(self.new_links))
118118

119119
def test_get_service_Links_str(self):

0 commit comments

Comments
 (0)