Support capital type definition in .sql?

[ZichaoNickFox]

Now I have to use lowercase to define type as

-- Your database schema. Use the Schema Designer at http://localhost:8001/ to add some tables.
CREATE TYPE node_type AS ENUM ('folder', 'file');
CREATE TYPE cell_type AS ENUM ('raw', 'image', 'backtest');
CREATE TYPE symbol_type AS ENUM ('stock', 'etf', 'future', 'option', 'fund');
CREATE TABLE symbol (
    id UUID DEFAULT uuid_generate_v4() PRIMARY KEY NOT NULL,
    code TEXT NOT NULL,
    name TEXT NOT NULL,
    symbol_type symbol_type NOT NULL,
    list_date TIMESTAMP WITHOUT TIME ZONE NOT NULL,
    delist_date TIMESTAMP WITHOUT TIME ZONE,
    UNIQUE(code, symbol_type)
);

If I use CREATE TYPE "SYMBOL_TYPE" AS ENUM ('stock', 'etf', 'future', 'option', 'fund') to define enum type. I have to write symbol_type "SYMBOL_TYPE" NOT NULL in creating symbol table. And there will be an error as follow when I enter localhost:8001.

If I write symbol_type SYMBOL_TYPE NOT NULL without "". ihp-migration will treat SYMBOL_TYPE as lowercase symbol_type. This will generate a new migration to lowercase definition.

Using lowercase to define type is OK in everywhere. But using capital to define type is more better to uniform type definition of database. Do you have any plan to support using capital to define database type?

[ZichaoNickFox]

@mpscholten My mistake. I then asked all AIs and they all recommand lowercase (aka capital without ") for type definition.
And I read many articles, they also recommand using lowercase (aka capital without ") in creating type.
So I think there is no issue here. I think this is not true -- But using capital to define type is more better to uniform type definition of database

And following code works fine without ".

-- Your database schema. Use the Schema Designer at http://localhost:8001/ to add some tables.
CREATE TYPE NODE_TYPE AS ENUM ('folder', 'file');
CREATE TYPE CELL_TYPE AS ENUM ('raw', 'image', 'backtest');
CREATE TYPE SYMBOL_TYPE AS ENUM ('stock', 'etf', 'future', 'option', 'fund');
CREATE TABLE symbol (
    id UUID DEFAULT uuid_generate_v4() PRIMARY KEY NOT NULL,
    code TEXT NOT NULL,
    name TEXT NOT NULL,
    symbol_type SYMBOL_TYPE NOT NULL,
    list_date TIMESTAMP WITHOUT TIME ZONE NOT NULL,
    delist_date TIMESTAMP WITHOUT TIME ZONE,
    UNIQUE(code, symbol_type)
);
CREATE TABLE basket_tree (
    id UUID DEFAULT uuid_generate_v4() PRIMARY KEY NOT NULL,
    node_type NODE_TYPE NOT NULL,
    name TEXT NOT NULL,
    parent_tree_id UUID,
    "position" INT NOT NULL
);

So the PR and Issue maybe useless.

[ZichaoNickFox]

When I use capital inside schema.sql. The definition in schema editor is also turns into capital. Though they are actually lowercase when handing.

Previously I think INT, DOUBLE, DATETIME, TEXT are capital. But they are actually lowercase for postgresql.

[mpscholten]

I'd generally go with lowercase here as well, but there's no reason not to support it (this makes it easier to use IHP with existing database schemas)