diff --git a/changelog/unreleased/fix-add-acl.md b/changelog/unreleased/fix-add-acl.md new file mode 100644 index 00000000000..27f2a72f787 --- /dev/null +++ b/changelog/unreleased/fix-add-acl.md @@ -0,0 +1,3 @@ +Bugfix: fix missing GID 2 in EOS AddACL + +https://github.com/cs3org/reva/pull/5584 \ No newline at end of file diff --git a/pkg/storage/fs/eos/client/grpc/acl.go b/pkg/storage/fs/eos/client/grpc/acl.go index 5a2a65089d5..c0cb7a63b15 100644 --- a/pkg/storage/fs/eos/client/grpc/acl.go +++ b/pkg/storage/fs/eos/client/grpc/acl.go @@ -36,6 +36,8 @@ func (c *Client) AddACL(ctx context.Context, auth eosclient.Authorization, path return err } + rq.Role.Gid = 2 + msg := new(erpc.NSRequest_AclRequest) msg.Cmd = erpc.NSRequest_AclRequest_ACL_COMMAND(erpc.NSRequest_AclRequest_ACL_COMMAND_value["MODIFY"]) msg.Type = erpc.NSRequest_AclRequest_ACL_TYPE(erpc.NSRequest_AclRequest_ACL_TYPE_value["SYS_ACL"]) @@ -59,7 +61,7 @@ func (c *Client) AddACL(ctx context.Context, auth eosclient.Authorization, path return errtypes.NotFound(fmt.Sprintf("Path: %s", path)) } - log.Debug().Str("func", "AddACL").Str("path", path).Str("resp:", fmt.Sprintf("%#v", resp)).Msg("grpc response") + log.Debug().Str("func", "AddACL").Str("path", path).Str("resp:", fmt.Sprintf("%#v", resp)).Any("acl", resp.Acl).Any("error", resp.Error).Msg("grpc response") return err }