Problem
pkg/engine/engine.go declares Insecure bool on Options, and buildApplyRenderOptions in pkg/commands/apply.go assigns applyCmdFlags.insecure to it. However, engine.Render and all helpers in pkg/engine/ never read opts.Insecure.
This was extended by #119 which added the assignment (and a regression test for the assignment), but the field still has no effect on behavior.
Proposed fix
Either:
- Remove the field if it is truly unused.
- Wire it up if it was meant to influence rendering (e.g., suppress
FailIfMultiNodes for the maintenance-mode path, which conceptually supports multi-node).
References
pkg/engine/engine.go:55pkg/commands/apply.go:216 (in buildApplyRenderOptions)pkg/commands/apply_test.go — regression test asserts the pass-through
Problem
pkg/engine/engine.godeclaresInsecure boolonOptions, andbuildApplyRenderOptionsinpkg/commands/apply.goassignsapplyCmdFlags.insecureto it. However,engine.Renderand all helpers inpkg/engine/never readopts.Insecure.This was extended by #119 which added the assignment (and a regression test for the assignment), but the field still has no effect on behavior.
Proposed fix
Either:
FailIfMultiNodesfor the maintenance-mode path, which conceptually supports multi-node).References
pkg/engine/engine.go:55pkg/commands/apply.go:216(inbuildApplyRenderOptions)pkg/commands/apply_test.go— regression test asserts the pass-through