Merge pull request #144 from bonzofenix/fix-commitish-422-error

Fix 422 error when updating release without commitish parameter

Author: taylorsilva

out_command.go

@@ -48,7 +48,7 @@ func (c *OutCommand) Run(sourceDir string, request OutRequest) (OutResponse, err
 		}
 	}
 
-	targetCommitish := ""
+	var targetCommitish string
 	if request.Params.CommitishPath != "" {
 		targetCommitish, err = c.fileContents(filepath.Join(sourceDir, request.Params.CommitishPath))
 		if err != nil {
@@ -94,10 +94,13 @@ func (c *OutCommand) Run(sourceDir string, request OutRequest) (OutResponse, err
 		}
 
 		existingRelease.Name = github.String(name)
-		existingRelease.TargetCommitish = github.String(targetCommitish)
 		existingRelease.Draft = github.Bool(draft)
 		existingRelease.Prerelease = github.Bool(prerelease)
 
+		if targetCommitish != "" {
+			existingRelease.TargetCommitish = github.String(targetCommitish)
+		}
+
 		if bodySpecified {
 			existingRelease.Body = github.String(body)
 		} else {

out_command_test.go

@@ -194,7 +194,7 @@ var _ = Describe("Out Command", func() {
 				updatedRelease := githubClient.UpdateReleaseArgsForCall(0)
 				Ω(*updatedRelease.Name).Should(Equal("v0.3.12"))
 				Ω(*updatedRelease.Body).Should(Equal("this is a great release"))
-				Ω(updatedRelease.TargetCommitish).Should(Equal(github.String("")))
+				Ω(updatedRelease.TargetCommitish).Should(BeNil(), "does not set the TargetCommitish")
 			})
 		})