Skip to content

Commit 3f6655a

Browse files
markstokanRui Yang
andcommitted
remove alpine image dockerfile
switch to concourse/resource-types-base-image-static as base image Co-authored-by: Mark Stokan <stokanm@vmware.com> Co-authored-by: Rui Yang <ruiya@vmware.com> Signed-off-by: Mark Stokan <stokanm@vmware.com>
1 parent 0fadec1 commit 3f6655a

3 files changed

Lines changed: 5 additions & 37 deletions

File tree

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
ARG base_image=alpine:latest
1+
ARG base_image
22
ARG builder_image=concourse/golang-builder
33

44
FROM ${builder_image} AS builder
55
COPY . $GOPATH/src/github.com/concourse/github-release-resource
6-
WORKDIR $GOPATH/src/github.com/concourse/github-release-resource
76
ENV CGO_ENABLED 0
7+
WORKDIR $GOPATH/src/github.com/concourse/github-release-resource
88
RUN go mod vendor
99
RUN go build -o /assets/out github.com/concourse/github-release-resource/cmd/out
1010
RUN go build -o /assets/in github.com/concourse/github-release-resource/cmd/in
@@ -14,8 +14,7 @@ RUN set -e; for pkg in $(go list ./...); do \
1414
done
1515

1616
FROM ${base_image} AS resource
17-
RUN apk update && apk upgrade
18-
RUN apk add --update bash tzdata ca-certificates
17+
USER root
1918
COPY --from=builder /assets /opt/resource
2019

2120
FROM resource AS tests

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -202,11 +202,10 @@ environment is consistent across any `docker` enabled platform. When the docker
202202
image builds, the test are run inside the docker container, on failure they
203203
will stop the build.
204204

205-
Run the tests with the following commands for both `alpine` and `ubuntu` images:
205+
Run the tests with the following command:
206206

207207
```sh
208-
docker build -t github-release-resource -f dockerfiles/alpine/Dockerfile .
209-
docker build -t github-release-resource -f dockerfiles/ubuntu/Dockerfile --build-arg base_image=ubuntu:latest .
208+
docker build -t github-release-resource --target tests --build-arg base_image=concourse/resource-types-base-image-static:latest .
210209
```
211210

212211
### Contributing

dockerfiles/ubuntu/Dockerfile

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)