Skip to content

Commit fa693f8

Browse files
committed
computerd: cleanup code comments
1 parent 543da34 commit fa693f8

28 files changed

Lines changed: 265 additions & 565 deletions

‎.github/actions/install/action.yml‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@ runs:
1616
registry-url: ${{ inputs.registry-url }}
1717
cache: npm
1818

19-
# npm ci compiles the vendored fuse-napi addon for
20-
# @cloudflare/computerd, which needs the libfuse 3 headers. Without
21-
# them the install, and with it every job, fails.
19+
# npm ci compiles computerd's vendored FUSE addon against these.
2220
- name: Install the libfuse 3 headers
2321
if: runner.os == 'Linux'
2422
shell: bash

‎.github/workflows/ci.yml‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,8 @@ jobs:
6767
path: packages/computerd
6868
needs-siblings: true
6969
build-computerd-bin: true
70-
# fuse3 ships fusermount3, which the real-FUSE tests mount
71-
# through. The addon itself is compiled during npm ci. xz-utils
72-
# extracts the target Node binary used by build:bin.
70+
# fuse3 provides fusermount3 for the real-FUSE tests; xz-utils
71+
# unpacks the Node binary build:bin injects into.
7372
system-deps: "fuse3 xz-utils"
7473
steps:
7574
- uses: actions/checkout@v6

‎.github/workflows/next-computerd-image.yml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,7 @@ jobs:
6767
- name: Build all workspaces
6868
run: npm run build --workspaces --if-present
6969

70-
# build:bin compiles the FUSE addon inside a Debian trixie container,
71-
# so the runner needs Docker but no FUSE packages of its own.
70+
# Compiles the FUSE addon in a container, so no FUSE packages here.
7271
- name: Build the computerd binary
7372
run: npm run build:bin --workspace @cloudflare/computerd
7473

‎examples/container/Dockerfile‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,8 @@ FROM ghcr.io/cloudflare/computer-computerd-linux-x64:0.5.1 AS computerd
1818

1919
FROM debian:stable-slim
2020

21-
# fuse3 brings libfuse 3. Releases after 0.4.1 link it and need 3.17
22-
# or newer, which is Debian trixie. 0.4.1 and earlier link libfuse 2
23-
# instead, hence libfuse2t64; drop it once the pin above is past 0.4.1.
21+
# libfuse2t64 is for the pinned 0.4.1 binary. Later releases need only
22+
# fuse3, at libfuse 3.17 or newer (Debian trixie); drop it then.
2423
RUN apt-get update \
2524
&& apt-get install -y --no-install-recommends \
2625
fuse3 libfuse2t64 ca-certificates curl gnupg git \

‎examples/egress/Dockerfile‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@ FROM ghcr.io/cloudflare/computer-computerd-linux-x64:0.5.1 AS computerd
22

33
FROM debian:trixie-slim
44

5-
# fuse3 brings libfuse 3. Releases after 0.4.1 link it and need 3.17
6-
# or newer, which is Debian trixie. 0.4.1 and earlier link libfuse 2
7-
# instead, hence libfuse2t64; drop it once the pin above is past 0.4.1.
5+
# libfuse2t64 is for the pinned 0.4.1 binary. Later releases need only
6+
# fuse3, at libfuse 3.17 or newer (Debian trixie); drop it then.
87
RUN apt-get update \
98
&& apt-get install -y --no-install-recommends \
109
fuse3 libfuse2t64 ca-certificates curl \

‎examples/mcp/Dockerfile‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@ FROM ghcr.io/cloudflare/computer-computerd-linux-x64:0.5.1 AS computerd
22

33
FROM node:22-trixie-slim
44

5-
# fuse3 brings libfuse 3. Releases after 0.4.1 link it and need 3.17
6-
# or newer, which is Debian trixie. 0.4.1 and earlier link libfuse 2
7-
# instead, hence libfuse2t64; drop it once the pin above is past 0.4.1.
5+
# libfuse2t64 is for the pinned 0.4.1 binary. Later releases need only
6+
# fuse3, at libfuse 3.17 or newer (Debian trixie); drop it then.
87
RUN apt-get update \
98
&& apt-get install -y --no-install-recommends \
109
ca-certificates curl fuse3 git libfuse2t64 \

‎examples/think-compare-runtimes/Dockerfile.workspace‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,8 @@ FROM ghcr.io/cloudflare/computer-computerd-linux-x64:0.5.1 AS computerd
1616

1717
FROM --platform=linux/amd64 node:22-trixie-slim
1818

19-
# fuse3 brings libfuse 3. Releases after 0.4.1 link it and need 3.17
20-
# or newer, which is Debian trixie. 0.4.1 and earlier link libfuse 2
21-
# instead, hence libfuse2t64; drop it once the pin above is past 0.4.1.
19+
# libfuse2t64 is for the pinned 0.4.1 binary. Later releases need only
20+
# fuse3, at libfuse 3.17 or newer (Debian trixie); drop it then.
2221
RUN apt-get update \
2322
&& apt-get install -y --no-install-recommends \
2423
ca-certificates git fuse3 libfuse2t64 \

‎examples/think/Dockerfile‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,8 @@ FROM debian:stable-slim
2020
# come in handy for ad-hoc agent commands too. The cost is ~120 MB
2121
# of layer over the base; acceptable for an example whose whole
2222
# point is running real build/test workflows.
23-
# fuse3 brings libfuse 3. Releases after 0.4.1 link it and need 3.17
24-
# or newer, which is Debian trixie. 0.4.1 and earlier link libfuse 2
25-
# instead, hence libfuse2t64; drop it once the pin above is past 0.4.1.
23+
# libfuse2t64 is for the pinned 0.4.1 binary. Later releases need only
24+
# fuse3, at libfuse 3.17 or newer (Debian trixie); drop it then.
2625
RUN apt-get update \
2726
&& apt-get install -y --no-install-recommends \
2827
fuse3 libfuse2t64 ca-certificates curl gnupg git \

‎examples/tutorial/Dockerfile‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,8 @@ ARG TYPST_VERSION=0.15.1
1818
# pandoc converts the agent's markdown; typst is the PDF engine, a
1919
# single 30 MB binary instead of the several hundred megabytes a LaTeX
2020
# install would cost. curl is only the download tool for those two.
21-
# fuse3 brings libfuse 3. Releases after 0.4.1 link it and need 3.17
22-
# or newer, which is Debian trixie. 0.4.1 and earlier link libfuse 2
23-
# instead, hence libfuse2t64; drop it once the pin above is past 0.4.1.
21+
# libfuse2t64 is for the pinned 0.4.1 binary. Later releases need only
22+
# fuse3, at libfuse 3.17 or newer (Debian trixie); drop it then.
2423
RUN apt-get update \
2524
&& apt-get install -y --no-install-recommends \
2625
fuse3 libfuse2t64 ca-certificates curl xz-utils \

‎packages/computer/test-harness/run-computerd.sh‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ RUN apt-get update >/dev/null \
4848
DOCKERFILE
4949
fi
5050

51-
# Forward local-only path and FUSE tuning settings from the caller, so a
52-
# test can boot computerd with MOUNT_IGNORE or COMPUTERD_FUSE_TRACE set.
51+
# Lets a test boot computerd with MOUNT_IGNORE or COMPUTERD_FUSE_* set.
5352
FORWARD_ENV=()
5453
while IFS='=' read -r name _; do
5554
case "$name" in

0 commit comments

Comments
 (0)