Skip to content

Do not bypass auto_duplicate() even when just modifying meta-data #682

Description

@cbrnr

auto_duplicate() protects file-backed data sets by always duplicating before a mutation, and asks Create-new-vs-Overwrite for derived ones. At least three actions skip this and mutate self.current directly:

  • channel_properties()
  • rename_channels()
  • find_events()

So renaming a channel or running Find Events right after loading a file silently mutates the root data set that's supposed to represent that file untouched. I suggest running these (and any other actions with similar behavior) through auto_duplicate() like every other processing action.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions