Skip to content

[PM-34822] Consistent error response 400 and 404 in Org Integrations controller#7458

Merged
voommen-livefront merged 7 commits intomainfrom
dirt/pm-34822/incorrect-ui-error
Apr 25, 2026
Merged

[PM-34822] Consistent error response 400 and 404 in Org Integrations controller#7458
voommen-livefront merged 7 commits intomainfrom
dirt/pm-34822/incorrect-ui-error

Conversation

@voommen-livefront
Copy link
Copy Markdown
Collaborator

@voommen-livefront voommen-livefront commented Apr 13, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34822

📔 Objective

Organization Integration endpoints returns

  • 404 NotFound response when permissions are missing and
  • 400 BadRequest when errors occur
    Updated unit tests to reflect this change.

📸 Screenshots

None at this time.

@voommen-livefront voommen-livefront requested a review from a team as a code owner April 13, 2026 14:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 13, 2026

Logo
Checkmarx One – Scan Summary & Detailsa25632a5-e8db-48f9-b213-2fa2c5fb1493


New Issues (2) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM CSRF src/Api/Vault/Controllers/CiphersController.cs: 1558
detailsMethod at line 1558 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
Attack Vector
2 MEDIUM CSRF src/Api/Vault/Controllers/CiphersController.cs: 1385
detailsMethod at line 1385 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
Attack Vector

Fixed Issues (2) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
MEDIUM CSRF src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 145
MEDIUM CSRF src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 97

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.14%. Comparing base (e1c67a4) to head (a080efb).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7458   +/-   ##
=======================================
  Coverage   59.13%   59.14%           
=======================================
  Files        2077     2077           
  Lines       91848    91860   +12     
  Branches     8175     8177    +2     
=======================================
+ Hits        54315    54327   +12     
  Misses      35601    35601           
  Partials     1932     1932           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

prograhamming
prograhamming previously approved these changes Apr 13, 2026
voommen-livefront and others added 2 commits April 22, 2026 15:13
…unit tests

Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
@voommen-livefront voommen-livefront changed the title [PM-34822] when lacking permissions return a Forbid() response [PM-34822] Consistent error response from commands Apr 22, 2026
@voommen-livefront voommen-livefront changed the title [PM-34822] Consistent error response from commands [PM-34822] Consistent error response 400 and 404 in Org Integrations controller Apr 23, 2026
Co-authored-by: Copilot <copilot@github.com>
@sonarqubecloud
Copy link
Copy Markdown

@voommen-livefront voommen-livefront merged commit dcc685d into main Apr 25, 2026
70 of 71 checks passed
@voommen-livefront voommen-livefront deleted the dirt/pm-34822/incorrect-ui-error branch April 25, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants