Remove repo specific skills from software engineer#92
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR removes the five repo-specific skills ( Code Review DetailsNo new findings. Prior reviewer feedback from SaintPatrck on agent technology references (lines 26-28, 34-48) and broader routing/verification guidance is acknowledged by the author, who has explicitly scoped this PR to surgical trims and deferred deeper restructuring to a follow-up focused on plugin direction. The earlier Claude comment about the README opening describing "Claude Code skills" was addressed via commit Version bump (0.3.3 → 0.4.0) and CHANGELOG entry are present and consistent across |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| - **Dapper/stored procedure work** (creating SPs, MSSQL migrations, Dapper repository methods) → activate `implementing-dapper-queries` | ||
| - **EF Core work** (EF repositories, EF migrations, PostgreSQL/MySQL/SQLite) → activate `implementing-ef-core` | ||
| - **Both ORMs** (new repository interface that needs both implementations) → activate both implementation skills |
There was a problem hiding this comment.
CLAUDE.md or Skill(s).
There was a problem hiding this comment.
Yeah, you're likely correct.🤷🏼
I was hesitant to trim it all out right-away. I would prefer to do major surgery with a more focused direction for the plugin. I realize I opened the door by editing the file, but I felt I had to remove the sections I removed.
There was a problem hiding this comment.
These have been there for months now and likely aren't hurting the way that Claude operates. Would you be okay with modifying them in the coming week or two after we make a plan for the agent's long-term purpose?
| ### Server repo (C#/.NET) | ||
|
|
||
| - **Build:** `dotnet build` from the solution root | ||
| - **Unit tests:** `dotnet test` targeting the relevant test project (e.g., `test/Core.Test`) | ||
| - **Integration tests:** Run tests with `[DatabaseData]` attribute when database changes are involved | ||
|
|
||
| ### Client repo (Angular/TypeScript) | ||
|
|
||
| - **Build:** `npm run build` in the relevant app directory (`apps/web`, `apps/browser`, etc.) | ||
| - **Lint:** `npm run lint` to catch style violations | ||
| - **Unit tests:** `npm run test` in the relevant library or app directory | ||
|
|
||
| ### Database changes | ||
|
|
||
| - Verify your changes against the conventions in the active database skill (`implementing-dapper-queries`, `implementing-ef-core`, or `writing-database-queries`) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, you're likely correct here again 🤷🏼
I was hesitant to trim it all out right-away. I would prefer to do major surgery with a more focused direction for the plugin. I realize I opened the door by editing the file, but I felt I had to remove the sections I removed.
There was a problem hiding this comment.
These have been there for months now and likely aren't hurting the way that Claude operates. Would you be okay with modifying them in the coming week or two after we make a plan for the agent's long-term purpose?
Co-authored-by: Patrick Honkonen <1883101+SaintPatrck@users.noreply.github.com>
2 participants
🎟️ Tracking
PM-35296
📔 Objective
Remove the repo level skills that are being migrated in these pull requests
Tidy up the agent with surgical changes & align the description of the plugin/agent.