diff --git a/app/controllers/boards/columns_controller.rb b/app/controllers/boards/columns_controller.rb index d0bd13c551..cd07562755 100644 --- a/app/controllers/boards/columns_controller.rb +++ b/app/controllers/boards/columns_controller.rb @@ -29,7 +29,7 @@ def update respond_to do |format| format.turbo_stream - format.json { head :no_content } + format.json { render :show } end end diff --git a/docs/api/sections/columns.md b/docs/api/sections/columns.md index c4fc35d3be..481ad50351 100644 --- a/docs/api/sections/columns.md +++ b/docs/api/sections/columns.md @@ -170,7 +170,7 @@ __Request:__ __Response:__ -Returns `204 No Content` on success. +Returns `200 OK` with the updated column in the same shape as `GET /:account_slug/boards/:board_id/columns/:column_id`. ## `DELETE /:account_slug/boards/:board_id/columns/:column_id` diff --git a/test/controllers/api/flat_json_params_test.rb b/test/controllers/api/flat_json_params_test.rb index 77a74f454e..be8c59c8af 100644 --- a/test/controllers/api/flat_json_params_test.rb +++ b/test/controllers/api/flat_json_params_test.rb @@ -127,8 +127,10 @@ class FlatJsonParamsTest < ActionDispatch::IntegrationTest put board_column_path(column.board, column), params: { name: "Flat Updated" }, as: :json - assert_response :no_content + assert_response :success assert_equal "Flat Updated", column.reload.name + assert_equal column.id, @response.parsed_body["id"] + assert_equal "Flat Updated", @response.parsed_body["name"] end test "create step with flat JSON" do diff --git a/test/controllers/boards/columns_controller_test.rb b/test/controllers/boards/columns_controller_test.rb index 664e91ea15..45c31724c7 100644 --- a/test/controllers/boards/columns_controller_test.rb +++ b/test/controllers/boards/columns_controller_test.rb @@ -86,8 +86,12 @@ class Boards::ColumnsControllerTest < ActionDispatch::IntegrationTest put board_column_path(column.board, column), params: { column: { name: "Updated Name" } }, as: :json - assert_response :no_content + assert_response :success assert_equal "Updated Name", column.reload.name + + json = @response.parsed_body + assert_equal column.id, json["id"] + assert_equal "Updated Name", json["name"] end test "destroy as JSON" do