Skip to content

Update seed plugin to match post-cutback pattern#8

Merged
jeremy merged 5 commits intomainfrom
seed-lean-plugin
Mar 5, 2026
Merged

Update seed plugin to match post-cutback pattern#8
jeremy merged 5 commits intomainfrom
seed-lean-plugin

Conversation

@jeremy
Copy link
Copy Markdown
Member

@jeremy jeremy commented Mar 5, 2026

Summary

  • Drop agents/ (navigator duplicated skill, context-linker was inert)
  • Make plugin.json metadata-only (drop hooks and agents fields)
  • Replace session-start.sh with lean liveness check (templatized {{.Name}})
  • Add hooks.json declaring SessionStart + PostToolUse
  • Add templatized post-commit-check.sh (patterns: {{.Upper}}-[0-9]+|item-[0-9]+|{{.Name}}-[0-9]+)
  • Add /{{.Name}}-doctor slash command
  • Add skills symlink step to seed-cli.md

Companion PRs: basecamp/fizzy-cli#77 (trim plugin), basecamp/claude-plugins#4 (register fizzy)

Test plan

  • ls -laR seed/.claude-plugin/ — no agents/, has commands/ and hooks/, plugin.json is metadata-only
  • make passes
  • grep symlink prompts/seed-cli.md — step present

Drop agents/ (navigator duplicated skill, context-linker was inert).
Make plugin.json metadata-only. Replace session-start.sh with lean
liveness check. Add hooks.json, templatized post-commit-check.sh,
and /doctor command. Add skills symlink step to seed-cli.md.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96c2c1d155

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread prompts/seed-cli.md Outdated
Comment thread seed/.claude-plugin/hooks/post-commit-check.sh Outdated
Comment thread seed/.claude-plugin/hooks/post-commit-check.sh
- Add mkdir -p before skills symlink in seed-cli.md bootstrap step
- Guard post-commit-check.sh against missing jq (exit 0 gracefully)
- Append || true to grep -v to prevent errexit on single-line output
@github-actions github-actions Bot added seed prompts enhancement New feature or request labels Mar 5, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the seed Claude plugin to a slimmer “post-cutback” structure by removing agent-based behaviors and moving hook configuration into a dedicated hooks.json, while adding a new doctor command and a post-commit reference helper.

Changes:

  • Simplifies plugin.json to metadata-only and removes agents/ content.
  • Replaces session-start context priming with a lightweight liveness/auth check.
  • Adds hook configuration (hooks.json), a post-commit checker hook, and a /{{.Name}}-doctor command; updates seed docs with a skills symlink step.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
seed/.claude-plugin/plugin.json Removes embedded hooks/agents config and keeps metadata-only plugin definition.
seed/.claude-plugin/hooks/session-start.sh Replaces heavy session-start context loading with a minimal liveness/auth status message.
seed/.claude-plugin/hooks/post-commit-check.sh Adds PostToolUse hook to detect item references after successful git commit and suggest follow-up CLI commands.
seed/.claude-plugin/hooks/hooks.json Declares SessionStart + PostToolUse hook wiring via ${CLAUDE_PLUGIN_ROOT} commands.
seed/.claude-plugin/commands/doctor.md Adds a templatized slash command to run {{.Name}} doctor --json and summarize results.
seed/.claude-plugin/agents/navigator.md Removes navigator agent content (no longer used).
seed/.claude-plugin/agents/context-linker.md Removes context-linker agent content (no longer used).
prompts/seed-cli.md Documents creating a skills symlink for the plugin.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread seed/.claude-plugin/hooks/session-start.sh Outdated
Comment thread seed/.claude-plugin/hooks/session-start.sh Outdated
Comment thread seed/.claude-plugin/hooks/session-start.sh Outdated
Comment thread seed/.claude-plugin/hooks/post-commit-check.sh
jeremy added 2 commits March 5, 2026 14:26
Seed templates now include:
- internal/harness/claude.go.tmpl skeleton for plugin detection and
  marketplace install utilities
- setup claude subcommand pattern in setup.go.tmpl
- Doctor check 9 wired to harness.CheckClaudePlugin()
- AGENTS.md.tmpl updated with harness/ in repo structure
- 3A.6: setup claude installs plugin via marketplace
- 3A.7: Plugin registered in basecamp/claude-plugins marketplace
- Fix 3A.3 wording (agents → commands)
- Update scoring totals (T3: 11→13, total: 82→84)
- Add audit checklists in rubric-audit SKILL.md
- Add harness + marketplace steps to seed-cli.md
- Add 3A.6/3A.7 implementation patterns to close-gap.md
Copilot AI review requested due to automatic review settings March 5, 2026 22:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread seed/.claude-plugin/hooks/post-commit-check.sh Outdated
Comment thread seed/.claude-plugin/commands/doctor.md Outdated
- Move jq check before auth status call in session-start.sh
- Assign CLI name to quoted variable to prevent word-splitting
- Escape commit message with printf %q in post-commit-check.sh
@jeremy jeremy force-pushed the seed-lean-plugin branch from 2b1ca5a to d2a3de9 Compare March 5, 2026 22:40
@jeremy jeremy merged commit e2e5b7c into main Mar 5, 2026
@jeremy jeremy deleted the seed-lean-plugin branch March 5, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants