Update seed plugin to match post-cutback pattern#8
Conversation
Drop agents/ (navigator duplicated skill, context-linker was inert). Make plugin.json metadata-only. Replace session-start.sh with lean liveness check. Add hooks.json, templatized post-commit-check.sh, and /doctor command. Add skills symlink step to seed-cli.md.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96c2c1d155
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Add mkdir -p before skills symlink in seed-cli.md bootstrap step - Guard post-commit-check.sh against missing jq (exit 0 gracefully) - Append || true to grep -v to prevent errexit on single-line output
There was a problem hiding this comment.
Pull request overview
Updates the seed Claude plugin to a slimmer “post-cutback” structure by removing agent-based behaviors and moving hook configuration into a dedicated hooks.json, while adding a new doctor command and a post-commit reference helper.
Changes:
- Simplifies
plugin.jsonto metadata-only and removesagents/content. - Replaces session-start context priming with a lightweight liveness/auth check.
- Adds hook configuration (
hooks.json), a post-commit checker hook, and a/{{.Name}}-doctorcommand; updates seed docs with a skills symlink step.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| seed/.claude-plugin/plugin.json | Removes embedded hooks/agents config and keeps metadata-only plugin definition. |
| seed/.claude-plugin/hooks/session-start.sh | Replaces heavy session-start context loading with a minimal liveness/auth status message. |
| seed/.claude-plugin/hooks/post-commit-check.sh | Adds PostToolUse hook to detect item references after successful git commit and suggest follow-up CLI commands. |
| seed/.claude-plugin/hooks/hooks.json | Declares SessionStart + PostToolUse hook wiring via ${CLAUDE_PLUGIN_ROOT} commands. |
| seed/.claude-plugin/commands/doctor.md | Adds a templatized slash command to run {{.Name}} doctor --json and summarize results. |
| seed/.claude-plugin/agents/navigator.md | Removes navigator agent content (no longer used). |
| seed/.claude-plugin/agents/context-linker.md | Removes context-linker agent content (no longer used). |
| prompts/seed-cli.md | Documents creating a skills symlink for the plugin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Seed templates now include: - internal/harness/claude.go.tmpl skeleton for plugin detection and marketplace install utilities - setup claude subcommand pattern in setup.go.tmpl - Doctor check 9 wired to harness.CheckClaudePlugin() - AGENTS.md.tmpl updated with harness/ in repo structure
- 3A.6: setup claude installs plugin via marketplace - 3A.7: Plugin registered in basecamp/claude-plugins marketplace - Fix 3A.3 wording (agents → commands) - Update scoring totals (T3: 11→13, total: 82→84) - Add audit checklists in rubric-audit SKILL.md - Add harness + marketplace steps to seed-cli.md - Add 3A.6/3A.7 implementation patterns to close-gap.md
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Move jq check before auth status call in session-start.sh - Assign CLI name to quoted variable to prevent word-splitting - Escape commit message with printf %q in post-commit-check.sh
Summary
agents/(navigator duplicated skill, context-linker was inert)plugin.jsonmetadata-only (drophooksandagentsfields)session-start.shwith lean liveness check (templatized{{.Name}})hooks.jsondeclaring SessionStart + PostToolUsepost-commit-check.sh(patterns:{{.Upper}}-[0-9]+|item-[0-9]+|{{.Name}}-[0-9]+)/{{.Name}}-doctorslash commandseed-cli.mdCompanion PRs: basecamp/fizzy-cli#77 (trim plugin), basecamp/claude-plugins#4 (register fizzy)
Test plan
ls -laR seed/.claude-plugin/— no agents/, has commands/ and hooks/, plugin.json is metadata-onlymakepassesgrep symlink prompts/seed-cli.md— step present