fix: AllowAttackState confusion (#3649)

Author: sogladev

libs/shared/sai-editor/src/constants/sai-actions.ts

@@ -336,9 +336,9 @@ SAI_ACTION_PARAM2_TOOLTIPS[SAI_ACTIONS.REMOVE_UNIT_FLAG] = SAI_ACTION_PARAM2_TOO
 
 // SMART_ACTION_AUTO_ATTACK
 SAI_ACTION_TOOLTIPS[SAI_ACTIONS.AUTO_ATTACK] = 'Stop or Continue Automatic Attack.';
-SAI_ACTION_PARAM1_NAMES[SAI_ACTIONS.AUTO_ATTACK] = 'StartOrStop';
+SAI_ACTION_PARAM1_NAMES[SAI_ACTIONS.AUTO_ATTACK] = 'AllowAttackState';
 SAI_ACTION_PARAM1_TOOLTIPS[SAI_ACTIONS.AUTO_ATTACK] =
-  '0 = the creature will stop attacking its current target. 1 = starts/continues to attack its target';
+  '0 = disable auto attack, the creature will stop attacking its current target. 1 = allow the creature to attack its target';
 
 // SMART_ACTION_ALLOW_COMBAT_MOVEMENT
 SAI_ACTION_TOOLTIPS[SAI_ACTIONS.ALLOW_COMBAT_MOVEMENT] = 'Allow or disallow moving while the creature is in combat';

libs/shared/sai-editor/src/constants/sai-comments.ts

@@ -104,7 +104,7 @@ SAI_ACTION_COMMENTS[SAI_ACTIONS.CALL_AREAEXPLOREDOREVENTHAPPENS] = `Quest Credit
 SAI_ACTION_COMMENTS[SAI_ACTIONS.SET_EMOTE_STATE] = `Set Emote State _actionParamOne_`;
 SAI_ACTION_COMMENTS[SAI_ACTIONS.SET_UNIT_FLAG] = `Set Flag_getUnitFlags_`;
 SAI_ACTION_COMMENTS[SAI_ACTIONS.REMOVE_UNIT_FLAG] = `Remove Flag_getUnitFlags_`;
-SAI_ACTION_COMMENTS[SAI_ACTIONS.AUTO_ATTACK] = `_startOrStopActionParamOne_ Attacking`;
+SAI_ACTION_COMMENTS[SAI_ACTIONS.AUTO_ATTACK] = `_continueOrStopActionParamOne_ Attacking`;
 SAI_ACTION_COMMENTS[SAI_ACTIONS.ALLOW_COMBAT_MOVEMENT] = `_enableDisableActionParamOne_ Combat Movement`;
 SAI_ACTION_COMMENTS[SAI_ACTIONS.SET_EVENT_PHASE] = `Set Event Phase _actionParamOne_`;
 SAI_ACTION_COMMENTS[SAI_ACTIONS.INC_EVENT_PHASE] = `_incrementOrDecrementActionParamOne_ Phase`;

libs/shared/sai-editor/src/sai-comment-generator.service.spec.ts

@@ -676,7 +676,7 @@ describe('SaiCommentGeneratorService', () => {
           action_type: SAI_ACTIONS.AUTO_ATTACK,
           action_param1: 1,
         },
-        expected: `MockEntity - In Combat - Start Attacking`,
+        expected: `MockEntity - In Combat - Continue Attacking`,
       },
       {
         name: 'SAI_ACTIONS.ALLOW_COMBAT_MOVEMENT check action params 1 (0)',

libs/shared/sai-editor/src/sai-comment-generator.service.ts

@@ -490,12 +490,12 @@ export class SaiCommentGeneratorService {
       actionLine = actionLine.replace('_getNpcFlags_', ' ' + commentNpcFlag);
     }
 
-    if (actionLine.indexOf('_startOrStopActionParamOne_') > -1) {
+    if (actionLine.indexOf('_continueOrStopActionParamOne_') > -1) {
       if (`${smartScript.action_param1}` === '0') {
-        actionLine = actionLine.replace('_startOrStopActionParamOne_', 'Stop');
+        actionLine = actionLine.replace('_continueOrStopActionParamOne_', 'Stop');
       } else {
         // ! Even if above 1 or below 0 we start attacking/allow-combat-movement
-        actionLine = actionLine.replace('_startOrStopActionParamOne_', 'Start');
+        actionLine = actionLine.replace('_continueOrStopActionParamOne_', 'Continue');
       }
     }