Closed
Conversation
Collaborator
|
Could you simulate big tests or something like that? Just to be sure it is not breaking code. Thank you in advance @EdJoPaTo |
Owner
|
for me it's ok. not sure if telegram uses provided mime type. maybe we can try uploading a couple of files and check how they are displayed in telegram |
Conflicts: src/client_ureq.rs
Collaborator
Author
|
as self-hosted bot API servers seem to have different handling of files in more places, I think its a good idea to do these tests against them too. |
Collaborator
Author
|
I think I'll just leave it as is and drop this PR. #260 simplifies this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While tinkering on #260 I noticed that mime_guess doesn't seem to be required. Everything I tested worked fine without. But I only tested with quite small files and the officially hosted bot API servers, not a self-hosted one.
reqwest also depends on mime_guess, so I'm not sure whether its used internally for the client-reqwest multipart stuff there. It's also possible to specify a mime with reqwest multipart, but it's not done there. Either it's not required at all or reqwest does the assumption internally which doesn't seem the case to be currently, but I haven't looked far.
@ayrat555 @pxp9 do you have any thoughts on this? There should probably more testing before something like this is changed.