Skip to content

feat(gateway): add create commands - #1899

Merged
aidandaly24 merged 20 commits into
refactorfrom
feat/gateway-create-cud
Aug 10, 2026
Merged

feat(gateway): add create commands#1899
aidandaly24 merged 20 commits into
refactorfrom
feat/gateway-create-cud

Conversation

@aidandaly24

@aidandaly24 aidandaly24 commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add create commands for Gateways, Targets, connector-backed Targets, and Rules
  • expose complete service-model inputs through JSON sources plus focused Target and Connector shortcuts
  • omit protocolType by default for unrestricted Gateways and map --protocol mcp to an MCP-only Gateway
  • require the service-modeled --role-arn when creating a Gateway
  • default curated Connector shortcuts to GATEWAY_IAM_ROLE; require exactly one explicit credential configuration for exact --connector-configuration

IAM scope

  • this PR does not create, tag, mutate, or delete IAM roles or permission policies
  • Gateway and Target execution-role permissions remain customer-managed
  • automatic role provisioning and permission reconciliation are deferred to the shared IAM management plane

Stack

Testing

  • focused Gateway validation, handler mapping, source-aware help, and connector shortcut tests
  • fixture-backed Gateway, HTTP Target, Web Search Connector, and Rule creation through the real router and Core
  • live deploy-account probes proving every tested Connector rejects omitted credentials, explicit [] is rejected by the service, explicit GATEWAY_IAM_ROLE is accepted, and the CLI shortcut default reaches READY
  • the fixture provisions its prerequisite role and Web Search permission outside production code, then passes --role-arn through the CLI
  • full lint, formatting, typecheck, Gateway stack tests, bundle, and AgentCore E2E coverage
  • every disposable probe Target, Gateway, inline policy, and role was deleted and confirmed absent

This was referenced Aug 4, 2026
Open
Open
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 4, 2026
@codecov-commenter

codecov-commenter commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.85185% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.72%. Comparing base (8cfce32) to head (aebf62f).

Files with missing lines Patch % Lines
src/handlers/gateway/create/index.tsx 92.30% 11 Missing ⚠️
src/handlers/gateway/target/create/index.tsx 95.53% 5 Missing ⚠️
src/handlers/gateway/connector/create/index.tsx 99.22% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           refactor    #1899    +/-   ##
==========================================
  Coverage     96.71%   96.72%            
==========================================
  Files           296      301     +5     
  Lines         16209    16745   +536     
==========================================
+ Hits          15677    16196   +519     
- Misses          532      549    +17

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 4, 2026
@aidandaly24
aidandaly24 marked this pull request as ready for review August 4, 2026 14:58
@aidandaly24
aidandaly24 marked this pull request as draft August 4, 2026 15:01
@aidandaly24
aidandaly24 changed the base branch from refactor to feat/iam-candidate-policy-swap August 4, 2026 16:59
@aidandaly24
aidandaly24 force-pushed the feat/gateway-create-cud branch from 9a3bf67 to c507614 Compare August 4, 2026 16:59
@aidandaly24 aidandaly24 mentioned this pull request Aug 4, 2026
Closed
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 4, 2026
@aidandaly24
aidandaly24 force-pushed the feat/gateway-create-cud branch from c507614 to 27fd3b5 Compare August 4, 2026 17:57
@aidandaly24
aidandaly24 force-pushed the feat/gateway-create-cud branch 3 times, most recently from 3271c5a to 13c4bb7 Compare August 4, 2026 18:44
@aidandaly24
aidandaly24 changed the base branch from feat/iam-candidate-policy-swap to refactor August 5, 2026 15:54
@aidandaly24
aidandaly24 force-pushed the feat/gateway-create-cud branch from f0c80fd to 06a20b3 Compare August 5, 2026 15:54
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 5, 2026
@aidandaly24
aidandaly24 changed the base branch from refactor to feat/gateway-connector-read August 5, 2026 17:48
@aidandaly24
aidandaly24 force-pushed the feat/gateway-create-cud branch from 06a20b3 to d95ae8f Compare August 5, 2026 17:48
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 5, 2026
@github-actions github-actions Bot removed the size/xl PR size: XL label Aug 5, 2026
nborges-aws
nborges-aws previously approved these changes Aug 10, 2026
View reviewed changes
jariy17
jariy17 previously approved these changes Aug 10, 2026
View reviewed changes

@jariy17 jariy17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aidandaly24
feat(gateway): add create commands
2267756
@aidandaly24
refactor(gateway): finalize create command surface
c64149d
@aidandaly24
refactor(gateway): simplify default execution role
3ed82d9
@aidandaly24
fix(gateway): verify create flows with service fixtures
939324d
@aidandaly24
refactor(gateway): simplify target create shortcuts
8ce0a2e
@aidandaly24
refactor(gateway): align create handler and core ownership
b453de5
@aidandaly24
refactor(gateway): reuse connector target classification
3d6eaed
@aidandaly24
refactor(gateway): name connector target module explicitly
a5c102c
@aidandaly24
refactor(gateway): make connector shortcuts exhaustive
9b56481
@aidandaly24
test(gateway): align create coverage with harness
aecb2d7
@aidandaly24
test(gateway): record create fixtures with e2e profile
c4aad24
@aidandaly24
test(gateway): cover connector create flow
e744990
@aidandaly24
fix(gateway): create web search connector shortcut
96cb314
@aidandaly24
test(gateway): mark IAM fixture workaround
32cb515
@aidandaly24
fix(gateway): reject generated role collisions
408bb34
@aidandaly24
refactor(gateway): require customer-managed role
7bc8446
@aidandaly24
fix(gateway): remove connector and rule client tokens
cc115a4
@aidandaly24
docs(gateway): clarify source-aware create flags
dfae9a0
@aidandaly24
fix(gateway): default connector shortcut credentials
2afeed8
@aidandaly24
test(gateway): inject logs client in create fixtures
aebf62f
@aidandaly24
aidandaly24 dismissed stale reviews from jariy17 and nborges-aws via aebf62f August 10, 2026 19:13
@aidandaly24
aidandaly24 force-pushed the feat/gateway-create-cud branch from e0f4f25 to aebf62f Compare August 10, 2026 19:13
@aidandaly24
aidandaly24 merged commit af7f3bf into refactor Aug 10, 2026
11 checks passed
@aidandaly24
aidandaly24 deleted the feat/gateway-create-cud branch August 10, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jariy17 jariy17 jariy17 approved these changes
@nborges-aws nborges-aws nborges-aws approved these changes
@AlexanderRichey AlexanderRichey AlexanderRichey left review comments

Assignees

No one assigned

Labels

size/xl PR size: XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aidandaly24 @codecov-commenter @nborges-aws @AlexanderRichey @jariy17