Skip to content

feat(dev): CodeZip dev runner and process lifecycle core - #1883

Merged
jariy17 merged 6 commits into
refactorfrom
feat/dev-server-core
Aug 10, 2026
Merged

feat(dev): CodeZip dev runner and process lifecycle core#1883
jariy17 merged 6 commits into
refactorfrom
feat/dev-server-core

Conversation

@tejaskash

@tejaskash tejaskash commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • stream long-running subprocess stdout and stderr as typed async-generator events from the io boundary
  • cancel process groups through AbortSignal, with graceful termination, hard-kill escalation, and descendant cleanup
  • simplify CodeZipDevRunner to yield status and process events without callbacks or lifecycle handles
  • run Python environments through uv run; use uvicorn for HTTP and direct Python execution for MCP, A2A, and AGUI
  • run TypeScript projects through npm exec -- tsx watch, installing dependencies only when node_modules is absent
  • remove unused port discovery and public implementation-helper exports from this PR

Verification

  • bun test (981 tests)
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build

@github-actions github-actions Bot added the size/l PR size: L label Jul 31, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Jul 31, 2026
@codecov-commenter

codecov-commenter commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.94872% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.73%. Comparing base (af7f3bf) to head (80d9c7c).

Files with missing lines Patch % Lines
src/io/exec.ts 96.74% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           refactor    #1883      +/-   ##
============================================
+ Coverage     96.72%   96.73%   +0.01%     
============================================
  Files           301      302       +1     
  Lines         16745    16939     +194     
============================================
+ Hits          16196    16386     +190     
- Misses          549      553       +4

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Jul 31, 2026
@tejaskash tejaskash changed the title feat(dev): CodeZip dev runner and process lifecycle core [NOT READY FOR REVIEW] feat(dev): CodeZip dev runner and process lifecycle core Jul 31, 2026
@tejaskash
tejaskash force-pushed the feat/dev-server-core branch from f5e0f3a to ba41e68 Compare July 31, 2026 16:55
@tejaskash
tejaskash force-pushed the feat/dev-server-core branch 4 times, most recently from 750364c to fe79c87 Compare August 3, 2026 18:01
@tejaskash
tejaskash force-pushed the feat/dev-server-core branch from fe79c87 to 356b555 Compare August 3, 2026 21:16
@tejaskash
tejaskash force-pushed the feat/dev-server-core branch from 70f25ad to 970d944 Compare August 6, 2026 15:57
@tejaskash tejaskash changed the title [NOT READY FOR REVIEW] feat(dev): CodeZip dev runner and process lifecycle core feat(dev): CodeZip dev runner and process lifecycle core Aug 6, 2026
@tejaskash
tejaskash force-pushed the feat/dev-server-core branch from ddad635 to dd9c5de Compare August 6, 2026 17:34
@tejaskash
tejaskash force-pushed the feat/dev-server-core branch from 5213de0 to 6cad8b2 Compare August 6, 2026 18:43
@tejaskash
tejaskash force-pushed the feat/dev-server-core branch from 6cad8b2 to c96378f Compare August 6, 2026 19:19
@tejaskash
tejaskash force-pushed the feat/dev-server-core branch from 3f9671b to d20d71f Compare August 6, 2026 19:22
@tejaskash
tejaskash force-pushed the feat/dev-server-core branch from d20d71f to 8e17d7d Compare August 7, 2026 16:37
@tejaskash
tejaskash changed the base branch from feat/project-foundation to refactor August 7, 2026 16:43
@tejaskash
tejaskash force-pushed the feat/dev-server-core branch 2 times, most recently from 3798df1 to 72d85ec Compare August 10, 2026 15:08
@tejaskash
tejaskash force-pushed the feat/dev-server-core branch 5 times, most recently from 8714739 to 6fc79c5 Compare August 10, 2026 15:31
@tejaskash tejaskash mentioned this pull request Aug 10, 2026
Open
@tejaskash
tejaskash force-pushed the feat/dev-server-core branch from 6fc79c5 to 4f5bb54 Compare August 10, 2026 18:41
@tejaskash
feat(dev): add CodeZip dev server, process supervisor, and port resol…
3a6cdac 
…ution

Implements the core infrastructure for `agentcore project dev`:
- ProcessSupervisor manages child processes with SIGTERM/SIGHUP cleanup
- CodeZipDevRunner bootstraps Python (uvicorn) and TypeScript (tsx) runtimes
- findAvailablePort walks up from requested port to find a free one
- Consumer-owned DevRunner interface with ProcessExit union type
@tejaskash
refactor(dev): address ARV review on dev-server-core
ee6d0ad 
- port: reject non-EADDRINUSE errors instead of treating every failure
  as "port busy" (EACCES on a privileged port no longer masquerades as
  in-use and gets silently walked past)
- dev: delete duplicate core/dev/run.ts; consume io/exec.ts (runProcess)
  so subprocess IO lives only in io/ (boundary of concern)
- codezip: drop nodePackageManager lockfile detection; assume npm
- process: rewrite watch() comment; tighten 128+signal comment
@tejaskash
refactor(dev): stream dev process events
98fee2c
@tejaskash
test(io): account for zombie descendants
2cdbdcd
@tejaskash
fix(dev): spawn streamed processes directly
dda811f
@tejaskash
tejaskash force-pushed the feat/dev-server-core branch 2 times, most recently from 7aac8a7 to 214e439 Compare August 10, 2026 20:15
aidandaly24
aidandaly24 reviewed Aug 10, 2026
View reviewed changes
Comment thread src/io/exec.ts Outdated
@tejaskash
tejaskash force-pushed the feat/dev-server-core branch from 214e439 to 80d9c7c Compare August 10, 2026 20:52
@jariy17
jariy17 merged commit b190e9e into refactor Aug 10, 2026
12 checks passed
@jariy17
jariy17 deleted the feat/dev-server-core branch August 10, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aidandaly24 aidandaly24 aidandaly24 approved these changes
@jariy17 jariy17 jariy17 approved these changes
@notgitika notgitika Awaiting requested review from notgitika

Assignees

No one assigned

Labels

size/l PR size: L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tejaskash @codecov-commenter @aidandaly24 @jariy17