changed test class/method modifiers to pkg-private (PMD rule)

Author: kuzjka

src/test/java/org/apache/xml/security/test/dom/encryption/EncryptionFormattingTest.java

@@ -60,7 +60,7 @@
  * and data encryption key.
  */
 @FormattingTest
-public class EncryptionFormattingTest {
+class EncryptionFormattingTest {
     private final Random random = new Random();
     private final FormattingChecker formattingChecker;
     private KeyStore keyStore;
@@ -85,7 +85,7 @@ public EncryptionFormattingTest() throws Exception {
     }
 
     @Test
-    public void testEncryptedFormatting() throws Exception {
+    void testEncryptedFormatting() throws Exception {
         /* this test checks formatting of base64binary values */
         byte[] testData = new byte[128]; // long enough for line breaks
         random.nextBytes(testData);
@@ -106,7 +106,7 @@ public void testEncryptedFormatting() throws Exception {
     }
 
     @Test
-    public void testEncryptDecrypt() throws Exception {
+    void testEncryptDecrypt() throws Exception {
         /* this test ensures that the encrypted data can be processed with various formatting settings */
         byte[] testData = new byte[128]; // long enough for line breaks
         random.nextBytes(testData);

src/test/java/org/apache/xml/security/test/dom/signature/SignatureFormattingTest.java

@@ -61,7 +61,7 @@
  * RSA-2048 and SHA-512 are used to create longer binary values.
  */
 @FormattingTest
-public class SignatureFormattingTest {
+class SignatureFormattingTest {
     private final static byte[] MOCK_DATA = new byte[]{ 0x0a, 0x0b, 0x0c, 0x0d };
 
     private final FormattingChecker formattingChecker;
@@ -89,7 +89,7 @@ public SignatureFormattingTest() throws Exception {
     }
 
     @Test
-    public void testSignatureFormatting() throws Exception {
+    void testSignatureFormatting() throws Exception {
         /* this test checks formatting of base64Binary values */
         Document doc = createDocument();
 
@@ -117,7 +117,7 @@ public void testSignatureFormatting() throws Exception {
     }
 
     @Test
-    public void testSignVerify() throws Exception {
+    void testSignVerify() throws Exception {
         /* this test checks the signature can be verified with given formatting settings */
         Document doc = createDocument();
         Element signatureElement = findElementByXpath("//ds:Signature[1]", doc);

src/test/java/org/apache/xml/security/test/stax/encryption/EncryptionFormattingTest.java

@@ -70,7 +70,7 @@
  * Also, decryption with StAX API is performed to ensure different formatting can be consumed.
  */
 @FormattingTest
-public class EncryptionFormattingTest {
+class EncryptionFormattingTest {
     private Random random = new Random();
     private final FormattingChecker formattingChecker;
     private KeyStore keyStore;
@@ -98,7 +98,7 @@ public EncryptionFormattingTest() throws KeyStoreException {
     }
 
     @Test
-    public void testEncryptedFormatting() throws Exception {
+    void testEncryptedFormatting() throws Exception {
         /* this test checks formatting of base64Binary values */
         byte[] documentBytes = createDocument();
 
@@ -128,7 +128,7 @@ public void testEncryptedFormatting() throws Exception {
     }
 
     @Test
-    public void testEncryptDecrypt() throws Exception {
+    void testEncryptDecrypt() throws Exception {
         /* this test ensures that the encrypted data can be processed with various formatting settings */
         byte[] documentBytes = createDocument();
 

src/test/java/org/apache/xml/security/test/stax/signature/SignatureFormattingTest.java

@@ -61,7 +61,7 @@
  * Also, signature verification with StAX API is performed to ensure different formatting can be consumed.
  */
 @FormattingTest
-public class SignatureFormattingTest {
+class SignatureFormattingTest {
     private final FormattingChecker formattingChecker;
     private KeyStore keyStore;
     private XPath xpath;
@@ -87,7 +87,7 @@ public SignatureFormattingTest() throws Exception {
     }
 
     @Test
-    public void testSignatureFormatting() throws Exception {
+    void testSignatureFormatting() throws Exception {
         /* this test checks formatting of base64Binary values */
         byte[] documentBytes = createDocument();
 
@@ -116,7 +116,7 @@ public void testSignatureFormatting() throws Exception {
     }
 
     @Test
-    public void testSignVerify() throws Exception {
+    void testSignVerify() throws Exception {
         /* this test checks the signature can be verified with given formatting settings */
         byte[] documentBytes = createDocument();
 

src/test/java/org/apache/xml/security/utils/XMLUtilsTest.java

@@ -47,43 +47,43 @@
  * formatting regardless of formatting options.
  */
 @FormattingTest
-public class XMLUtilsTest {
+class XMLUtilsTest {
 
     private FormattingChecker formattingChecker = FormattingCheckerFactory.getFormattingChecker();
 
     /* Base64 encoding of the following bytes is: AQIDBAUGBwg= */
     private static final byte[] TEST_DATA = new byte[]{ 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08 };
 
     @Test
-    public void testEncodeToString() {
+    void testEncodeToString() {
         byte[] data = new byte[60]; // long enough for a line break in MIME encoding
         String encoded = XMLUtils.encodeToString(data);
         formattingChecker.checkBase64Value(encoded);
     }
 
     @Test
-    public void testEncodeToStringShort() {
+    void testEncodeToStringShort() {
         byte[] data = new byte[8];
         String encoded = XMLUtils.encodeToString(data);
         formattingChecker.checkBase64Value(encoded);
     }
 
     @Test
-    public void testEncodeElementValue() {
+    void testEncodeElementValue() {
         byte[] data = new byte[60]; // long enough for a line break in MIME encoding
         String encoded = XMLUtils.encodeElementValue(data);
         formattingChecker.checkBase64ValueWithSpacing(encoded);
     }
 
     @Test
-    public void testEncodeElementValueShort() {
+    void testEncodeElementValueShort() {
         byte[] data = new byte[8];
         String encoded = XMLUtils.encodeElementValue(data);
         formattingChecker.checkBase64ValueWithSpacing(encoded);
     }
 
     @Test
-    public void testEncodeUsingStream() throws IOException {
+    void testEncodeUsingStream() throws IOException {
         byte[] data = new byte[60];
         String expected = XMLUtils.encodeToString(data);
         String encodedWithStream;
@@ -98,7 +98,7 @@ public void testEncodeUsingStream() throws IOException {
     }
 
     @Test
-    public void decodeNoLineBreaks() {
+    void decodeNoLineBreaks() {
         String encoded = "AQIDBAUGBwg=";
 
         byte[] data = XMLUtils.decode(encoded);
@@ -109,7 +109,7 @@ public void decodeNoLineBreaks() {
     }
 
     @Test
-    public void decodeCrlfLineBreaks() {
+    void decodeCrlfLineBreaks() {
         String encoded = "AQIDBAUG\r\nBwg=";
 
         byte[] data = XMLUtils.decode(encoded);
@@ -120,7 +120,7 @@ public void decodeCrlfLineBreaks() {
     }
 
     @Test
-    public void decodeLfLineBreaks() {
+    void decodeLfLineBreaks() {
         String encoded = "AQIDBAUG\nBwg=";
 
         byte[] data = XMLUtils.decode(encoded);
@@ -131,7 +131,7 @@ public void decodeLfLineBreaks() {
     }
 
     @Test
-    public void decodeStream() throws IOException {
+    void decodeStream() throws IOException {
         byte[] encodedBytes = "AQIDBAUGBwg=".getBytes(StandardCharsets.US_ASCII);
 
         try (InputStream decoded = XMLUtils.decodeStream(new ByteArrayInputStream(encodedBytes))) {