Skip to content

skip a queued volume detach when the volume is no longer on that vm - #14401

Open
Damans227 wants to merge 2 commits into
apache:mainfrom
Damans227:fix-stale-detach-volume
Open

Damans227 wants to merge 2 commits into
apache:mainfrom
Damans227:fix-stale-detach-volume

move the stale detach check into shouldDetachBeSkipped

3ac4425
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 27, 2026 in 0s

20.67% (+0.45%) compared to a945a7c

View this Pull Request on Codecov

20.67% (+0.45%) compared to a945a7c

Details

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 20.67%. Comparing base (a945a7c) to head (3ac4425).
⚠️ Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/com/cloud/storage/VolumeApiServiceImpl.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14401      +/-   ##
============================================
+ Coverage     20.21%   20.67%   +0.45%     
- Complexity    20749    21727     +978     
============================================
  Files          6426     6492      +66     
  Lines        580181   590736   +10555     
  Branches      71033    72449    +1416     
============================================
+ Hits         117292   122132    +4840     
- Misses       450174   455329    +5155     
- Partials      12715    13275     +560     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.