ARTEMIS-5987: Properly handling exceptions with single connection.

If there is an issue while creating a session in single connection mode
then the connection factory can be in a bad state and the lopp for
creating sessions still continues ove this.

Issue: https://issues.apache.org/jira/browse/ARTEMIS-5987

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>

Author: ehsavoie

artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java

@@ -259,17 +259,22 @@ protected synchronized void setup() throws Exception {
             handler.setup();
             handlers.add(handler);
          } catch (Exception e) {
+            logger.trace("Failed to setup session {} for activation {}", i, spec, e);
             if (cf != null) {
-               if (!spec.isSingleConnection()) {
-                  cf.close();
-               }
+               cf.close();
             }
             if (session != null) {
                session.close();
             }
             if (firstException == null) {
                firstException = e;
             }
+            if (spec.isSingleConnection()) {
+               // The shared ClientSessionFactory is in a broken state; stop the loop
+               // all remaining sessions would fail with "ClientSession closed while
+               // creating session", masking the real error.
+               break;
+            }
          }
       }
       //if we have any exceptions close all the handlers and throw the first exception.