Skip to content

Commit 9a731da

Browse files
committed
Revert the C++ change
1 parent 0e2db33 commit 9a731da

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

cpp/src/arrow/extension/tensor_extension_array_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1008,7 +1008,7 @@ TEST_F(TestVariableShapeTensorType, ComputeStridesWithNonTrivialPermutation) {
10081008
internal::checked_pointer_cast<ExtensionScalar>(scalar)));
10091009

10101010
ASSERT_EQ(tensor->shape(), (std::vector<int64_t>{3, 2, 1}));
1011-
ASSERT_EQ(tensor->strides(), (std::vector<int64_t>{sizeof(int64_t), sizeof(int64_t) * 2,
1011+
ASSERT_EQ(tensor->strides(), (std::vector<int64_t>{sizeof(int64_t), sizeof(int64_t) * 3,
10121012
sizeof(int64_t)}));
10131013
ASSERT_EQ(tensor->dim_names(), (std::vector<std::string>{"y", "x", "z"}));
10141014
}

cpp/src/arrow/extension/variable_shape_tensor.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,9 +269,9 @@ Result<std::shared_ptr<Tensor>> VariableShapeTensorType::MakeTensor(
269269
internal::Permute<std::string>(permutation, &dim_names);
270270
}
271271

272-
internal::Permute<int64_t>(permutation, &shape);
273272
ARROW_ASSIGN_OR_RAISE(
274273
auto strides, internal::ComputeStrides(ext_type.value_type(), shape, permutation));
274+
internal::Permute<int64_t>(permutation, &shape);
275275

276276
ARROW_ASSIGN_OR_RAISE(const auto buffer,
277277
internal::SliceTensorBuffer(*data_array, value_type, shape));

0 commit comments

Comments
 (0)