can't set Cloudflare static assets "not-found-handling" config parameter

[WayneBuckhanan]

I just saw that the Cloudflare Worker SST component can deploy assets and ran a test with static files and a small hono script. The hono part worked fine, but it always ran and none of the static files were being served. Realized it was the "not-found-handling": "single-page-application" parameter usually passed to assets in the wrangler config file, so dug through the Pulumi layers to figure out the transform.

  async run() {
    const worker = new sst.cloudflare.Worker("Workit", {
      handler: "./index.ts",
      url: true,
      assets: {
        directory: "./dist",
      },
      transform: {
        worker: {
          assets: {
            config: {
              notFoundHandling: "single-page-application",
            },
          },
        },
      },
    })

✕ Failed

Workit sst:cloudflare:Worker → WorkitScript cloudflare:index:WorkersScript
[AttributeName("assets").AttributeName("config")] Value Conversion Error: An unexpected error was encountered trying to convert tftypes.Value into workers_script.WorkersScriptMetadataAssetsConfigModel. This is always an error in the provider. Please report the following to the provider developer:
error retrieving field names from struct tags: assets.config._headers: invalid tfsdk tag, must only use lowercase letters, underscores, and numbers, and must start with a letter

Seems to be related to the tf bug @fwang is aware of, but wanted to get this in here as another case to test when the upstream issue is resolved.

[WayneBuckhanan]

Are you considering incorporating the not-found-handling option closer to the surface in the Worker since that immediately allows StaticSite usage with the option to include worker functionality?

Oh, well, maybe... If I comment out the handler (and the transform), it won't deploy with just static assets.

| Updated Workit sst:cloudflare:Worker → WorkitAssets sst:cloudflare:WorkerAssets (1.8s)

✕ Failed

Error: EISDIR: illegal operation on a directory, read
at readFileHandle (node:internal/fs/promises:555:24)
< at file:///home/[...]/.sst/platform/src/components/cloudflare/worker.ts:538:17 {
errno: -21,
code: 'EISDIR',
syscall: 'read'
}

[WayneBuckhanan]

Upstream seems to have gotten a fix applied. I suspect we're just waiting for the intermediate packages to be updated, but figured I'd add this note in case there is something more direct that can be done.

Thanks.

[rayli09]

following on this -- would love to get this fixed asap

[WayneBuckhanan]

Saw that we'd gotten an updated Pulumi provider for Cloudflare and circled back to this.

Was able to deploy static site assets plus a hono Worker script.

  async run() {
    const worker = new sst.cloudflare.Worker("Workit", {
      handler: "./index.ts",
      url: true,
      assets: { 
        directory: "./dist/client",
      },
    })
  }

It worked by default to display the SPA properly and ran the appropriate hono handler for defined paths but the not found handling is falling back to the hono instance in index.ts for paths that should be handled by the SPA.

Using the sst.cloudflare.Worker() option assets.directory didn't work with the transform only specifying the config.

"Cannot use an assets binding without assets."

  async run() {
    const worker = new sst.cloudflare.Worker("Workit", {
      handler: "./index.ts",
      url: true,
      transform: {
        worker: {
          assets: {
            directory: "../../dist",
            config: {
              notFoundHandling: "single-page-application",
              runWorkerFirst: ["/api/*"],
            },
          },
        },
      },
    })
  }

Had to specify the directory inside the transform.worker.assets and used ../../dist because SST/Pulumi takes the path relative to .sst/platform/ not the project root.

HTH

[bachiitter]

fix #6566