From 73286a2e1140e0e8abd37dd7a0b88b5f6fc7910e Mon Sep 17 00:00:00 2001 From: Eneko Ruiz <196690101+eneekoruiz@users.noreply.github.com> Date: Mon, 26 Oct 2026 08:14:52 +0100 Subject: [PATCH 1/3] docs: distinguish target acceptance from local verification --- manifests/context-packs/skill-triggers@1.json | 2 +- skills/verification-loop/SKILL.md | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/manifests/context-packs/skill-triggers@1.json b/manifests/context-packs/skill-triggers@1.json index 34be199f4c7..2571cddbe63 100644 --- a/manifests/context-packs/skill-triggers@1.json +++ b/manifests/context-packs/skill-triggers@1.json @@ -10,7 +10,7 @@ "id": "hand-seeded", "source": "manual-curation-pending-regeneration" }, - "registryDigest": "846ac8826dd91e81cd838c2b55d7be536af427eb453efa127501f891e5778ff8", + "registryDigest": "5d93820285d52a85a9e4525f465c3e083e42edcadcfa901efbd328fbc20d55b6", "schemaVersion": 1, "triggers": { "skill:agent-runtime-gateway-smoke-test": [ diff --git a/skills/verification-loop/SKILL.md b/skills/verification-loop/SKILL.md index 35cb4b7737e..1fbef658234 100644 --- a/skills/verification-loop/SKILL.md +++ b/skills/verification-loop/SKILL.md @@ -94,6 +94,18 @@ Review each changed file for: - Missing error handling - Potential edge cases +## Target Acceptance + +When the requested outcome requires deployment or target-environment verification, +report target acceptance separately from local checks. Record the environment and +installed version, the evidence, and the next permitted check or precise access +dependency. Passing tests, review, merge, or release does not verify that target. +Do not access production or make external changes without authorization. For +local-only tasks, mark target acceptance as not applicable. + +For example: local checks PASS; staging verification NOT PERFORMED (no access); +next step: an authorized maintainer runs the staging smoke test. + ## Output Format After running all phases, produce a verification report: @@ -110,6 +122,8 @@ Security: [PASS/FAIL] (X issues) Diff: [X files changed] Overall: [READY/NOT READY] for PR +Target: [VERIFIED/FAILED/NOT PERFORMED/NOT APPLICABLE] (environment/version, evidence) +Next permitted step: [check or access dependency; none if complete/not applicable] Issues to Fix: 1. ... From d4c1fecfafb6ecc5b1a681a3f078b02eecc2de3d Mon Sep 17 00:00:00 2001 From: Eneko Ruiz <196690101+eneekoruiz@users.noreply.github.com> Date: Mon, 26 Oct 2026 08:29:43 +0100 Subject: [PATCH 2/3] docs: sync Pi verification guidance and clarify target evidence --- manifests/context-packs/skill-triggers@1.json | 2 +- pi/core/skills/verification-loop/SKILL.md | 15 +++++++++++++++ skills/verification-loop/SKILL.md | 5 +++-- 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/manifests/context-packs/skill-triggers@1.json b/manifests/context-packs/skill-triggers@1.json index 2571cddbe63..e4688c620f7 100644 --- a/manifests/context-packs/skill-triggers@1.json +++ b/manifests/context-packs/skill-triggers@1.json @@ -10,7 +10,7 @@ "id": "hand-seeded", "source": "manual-curation-pending-regeneration" }, - "registryDigest": "5d93820285d52a85a9e4525f465c3e083e42edcadcfa901efbd328fbc20d55b6", + "registryDigest": "bfc82befc37cd6c742b3acab6965190027589252c77352604d6ed24863ae2e4f", "schemaVersion": 1, "triggers": { "skill:agent-runtime-gateway-smoke-test": [ diff --git a/pi/core/skills/verification-loop/SKILL.md b/pi/core/skills/verification-loop/SKILL.md index 35cb4b7737e..32c1c5da8b6 100644 --- a/pi/core/skills/verification-loop/SKILL.md +++ b/pi/core/skills/verification-loop/SKILL.md @@ -94,6 +94,19 @@ Review each changed file for: - Missing error handling - Potential edge cases +## Target Acceptance + +When the requested outcome requires deployment or target-environment verification, +report target acceptance separately from local checks. Record the environment and +installed version when known, the evidence, and the next permitted check or precise +access dependency. Passing local checks, review, merge, or release does not establish +target acceptance. Report VERIFIED or FAILED for an executed target check, with its evidence. +Do not access production or make external changes without authorization. For +local-only tasks, mark target acceptance as not applicable. + +For example: local checks PASS; staging verification NOT PERFORMED (no access); +next step: an authorized maintainer runs the staging smoke test. + ## Output Format After running all phases, produce a verification report: @@ -110,6 +123,8 @@ Security: [PASS/FAIL] (X issues) Diff: [X files changed] Overall: [READY/NOT READY] for PR +Target: [VERIFIED/FAILED/NOT PERFORMED/NOT APPLICABLE] (environment/version, evidence) +Next permitted step: [check or access dependency; none if complete/not applicable] Issues to Fix: 1. ... diff --git a/skills/verification-loop/SKILL.md b/skills/verification-loop/SKILL.md index 1fbef658234..32c1c5da8b6 100644 --- a/skills/verification-loop/SKILL.md +++ b/skills/verification-loop/SKILL.md @@ -98,8 +98,9 @@ Review each changed file for: When the requested outcome requires deployment or target-environment verification, report target acceptance separately from local checks. Record the environment and -installed version, the evidence, and the next permitted check or precise access -dependency. Passing tests, review, merge, or release does not verify that target. +installed version when known, the evidence, and the next permitted check or precise +access dependency. Passing local checks, review, merge, or release does not establish +target acceptance. Report VERIFIED or FAILED for an executed target check, with its evidence. Do not access production or make external changes without authorization. For local-only tasks, mark target acceptance as not applicable. From 03834ce145e5e0717bcacdd8feb054114dd3ae6c Mon Sep 17 00:00:00 2001 From: Eneko Ruiz <196690101+eneekoruiz@users.noreply.github.com> Date: Mon, 26 Oct 2026 10:36:50 +0100 Subject: [PATCH 3/3] docs: carry target acceptance guidance to Codex and Kiro --- .agents/skills/verification-loop/SKILL.md | 15 +++++++++++++++ .kiro/skills/verification-loop/SKILL.md | 15 +++++++++++++++ 2 files changed, 30 insertions(+) diff --git a/.agents/skills/verification-loop/SKILL.md b/.agents/skills/verification-loop/SKILL.md index b936bc9646e..1a0dca129ea 100644 --- a/.agents/skills/verification-loop/SKILL.md +++ b/.agents/skills/verification-loop/SKILL.md @@ -85,6 +85,19 @@ Review each changed file for: - Missing error handling - Potential edge cases +## Target Acceptance + +When the requested outcome requires deployment or target-environment verification, +report target acceptance separately from local checks. Record the environment and +installed version when known, the evidence, and the next permitted check or precise +access dependency. Passing local checks, review, merge, or release does not establish +target acceptance. Report VERIFIED or FAILED for an executed target check, with its evidence. +Do not access production or make external changes without authorization. For +local-only tasks, mark target acceptance as not applicable. + +For example: local checks PASS; staging verification NOT PERFORMED (no access); +next step: an authorized maintainer runs the staging smoke test. + ## Output Format After running all phases, produce a verification report: @@ -101,6 +114,8 @@ Security: [PASS/FAIL] (X issues) Diff: [X files changed] Overall: [READY/NOT READY] for PR +Target: [VERIFIED/FAILED/NOT PERFORMED/NOT APPLICABLE] (environment/version, evidence) +Next permitted step: [check or access dependency; none if complete/not applicable] Issues to Fix: 1. ... diff --git a/.kiro/skills/verification-loop/SKILL.md b/.kiro/skills/verification-loop/SKILL.md index f4327b91e17..b055dff3d7a 100644 --- a/.kiro/skills/verification-loop/SKILL.md +++ b/.kiro/skills/verification-loop/SKILL.md @@ -87,6 +87,19 @@ Review each changed file for: - Missing error handling - Potential edge cases +## Target Acceptance + +When the requested outcome requires deployment or target-environment verification, +report target acceptance separately from local checks. Record the environment and +installed version when known, the evidence, and the next permitted check or precise +access dependency. Passing local checks, review, merge, or release does not establish +target acceptance. Report VERIFIED or FAILED for an executed target check, with its evidence. +Do not access production or make external changes without authorization. For +local-only tasks, mark target acceptance as not applicable. + +For example: local checks PASS; staging verification NOT PERFORMED (no access); +next step: an authorized maintainer runs the staging smoke test. + ## Output Format After running all phases, produce a verification report: @@ -103,6 +116,8 @@ Security: [PASS/FAIL] (X issues) Diff: [X files changed] Overall: [READY/NOT READY] for PR +Target: [VERIFIED/FAILED/NOT PERFORMED/NOT APPLICABLE] (environment/version, evidence) +Next permitted step: [check or access dependency; none if complete/not applicable] Issues to Fix: 1. ...