@@ -357,11 +350,11 @@ export class MasCollapsibleTableRow extends LitElement {
`
: html`
-
-
- ${this.renderPromoCode(Store.translationProjects.groupedVariationsData.value?.get(variationPath))}
+
+
+ ${this.renderPromoCode(getItemsSelectionStore().groupedVariationsData.value?.get(variationPath))}
- ${this.renderTags(Store.translationProjects.groupedVariationsData.value?.get(variationPath))}
+ ${this.renderTags(getItemsSelectionStore().groupedVariationsData.value?.get(variationPath))}
`;
@@ -377,14 +370,14 @@ export class MasCollapsibleTableRow extends LitElement {
?selected=${isSelected}
aria-selected=${isSelected ? 'true' : 'false'}
>
-
+
${this.isTopLevelExpanded
? html``
: html``}
-
+
-
+
`;
}
@@ -836,7 +851,11 @@ class MasTranslationEditor extends LitElement {
${this.isSelectedItemsOpen
- ? html``
+ ? html``
: nothing}
`
}
diff --git a/studio/src/translation/mas-translation.css.js b/studio/src/translation/mas-translation.css.js
index 4199004db..45f26b5c7 100644
--- a/studio/src/translation/mas-translation.css.js
+++ b/studio/src/translation/mas-translation.css.js
@@ -28,7 +28,7 @@ export const styles = [
}
}
- .translation-table {
+ .item-table {
sp-table-head-cell:last-child,
sp-table-cell:last-child {
max-width: 100px;
diff --git a/studio/src/translation/mas-translation.js b/studio/src/translation/mas-translation.js
index f819743d4..908fdb91c 100644
--- a/studio/src/translation/mas-translation.js
+++ b/studio/src/translation/mas-translation.js
@@ -106,13 +106,13 @@ class MasTranslation extends LitElement {
get translationsProjectsContent() {
const isLoading = Store.translationProjects?.list?.loading?.get();
if (isLoading && !this.translationProjectsData.length) {
- return html`
+ return html`
${this.translationProjectsTableHead}
${Array.from({ length: 5 }, translationSkeletonRow)}
`;
}
if (this.translationProjectsData.length) {
- return html`
+ return html`
${this.translationProjectsTableHead}
${repeat(
diff --git a/studio/src/translation/translation-common-styles.css.js b/studio/src/translation/translation-common-styles.css.js
index 8457fa3cb..e3d213c44 100644
--- a/studio/src/translation/translation-common-styles.css.js
+++ b/studio/src/translation/translation-common-styles.css.js
@@ -1,11 +1,6 @@
import { css } from 'lit';
-export const ghostButtonStyles = css`
- .ghost-button {
- --mod-button-background-color-default: transparent;
- --mod-button-background-color-hover: var(--spectrum-gray-200);
- }
-`;
+export { ghostButtonStyles, tableHeaderBaseStyles, tableCellBaseStyles } from '../common/styles/table-styles.css.js';
export const loadingContainerCenteredStyles = css`
.loading-container--absolute {
@@ -15,89 +10,3 @@ export const loadingContainerCenteredStyles = css`
transform: translate(-50%, -50%);
}
`;
-
-export const loadingContainerFlexStyles = css`
- .loading-container--flex {
- display: flex;
- justify-content: center;
- align-items: center;
- }
-`;
-
-export const tableHeaderBaseStyles = css`
- .translation-table {
- --mod-table-header-background-color: var(--spectrum-gray-50);
- --mod-table-border-radius: 0;
- }
-
- .translation-table sp-table-head {
- border-top: 1px solid var(--spectrum-gray-300);
- border-left: 1px solid var(--spectrum-gray-300);
- border-right: 1px solid var(--spectrum-gray-300);
- border-radius: 12px 12px 0 0;
- }
-
- .translation-table sp-table-head-cell {
- align-content: center;
- }
-
- .translation-table sp-table-head-cell:first-of-type {
- border-top-left-radius: 12px;
- }
-
- .translation-table sp-table-head-cell:last-of-type {
- border-top-right-radius: 12px;
- }
-`;
-
-export const tableColumnIconStyles = css`
- .translation-table-icon-cell {
- display: flex;
- align-items: center;
- flex: 0;
- }
-
- .translation-table-icon-cell--chevron {
- padding: 29px;
- }
-
- .translation-table-icon-cell--checkbox {
- padding: 22px;
- }
-`;
-
-export const tableCellBaseStyles = css`
- .translation-table sp-table-cell,
- sp-table-cell {
- display: flex;
- align-items: center;
- }
-
- .status-cell {
- display: flex;
- align-items: center;
- gap: 6px;
-
- .status-dot {
- width: 8px;
- height: 8px;
- border-radius: 50%;
- background-color: var(--spectrum-gray-500);
- }
-
- .status-dot.green {
- background-color: var(--spectrum-green-700);
- }
-
- .status-dot.blue {
- background-color: var(--spectrum-blue-800);
- }
- }
-`;
-
-export const tableSelectedRowStyles = css`
- sp-table-row[selected] {
- --mod-table-row-background-color: var(--spectrum-blue-200);
- --spectrum-table-cell-background-color: var(--spectrum-blue-200);
- }
-`;
diff --git a/studio/test/common/item-loading-browser.test.js b/studio/test/common/item-loading-browser.test.js
new file mode 100644
index 000000000..c7a6478b5
--- /dev/null
+++ b/studio/test/common/item-loading-browser.test.js
@@ -0,0 +1,75 @@
+import { expect } from '@esm-bundle/chai';
+import sinon from 'sinon';
+import { loadOfferData } from '../../src/common/utils/item-loading-browser.js';
+
+describe('common/utils/item-loading-browser', () => {
+ let sandbox;
+ let commerceService;
+
+ const createMockCommerceService = () => {
+ const service = document.createElement('mas-commerce-service');
+ service.collectPriceOptions = sinon.stub().returns({});
+ service.resolveOfferSelectors = sinon.stub().returns([Promise.resolve([{ offerId: 'test-offer-id' }])]);
+ document.body.appendChild(service);
+ return service;
+ };
+
+ const removeMockCommerceService = () => {
+ const service = document.querySelector('mas-commerce-service');
+ if (service) service.remove();
+ };
+
+ beforeEach(() => {
+ sandbox = sinon.createSandbox();
+ commerceService = createMockCommerceService();
+ });
+
+ afterEach(() => {
+ sandbox.restore();
+ removeMockCommerceService();
+ });
+
+ it('returns null when the fragment does not have an OSI field', async () => {
+ const offerData = await loadOfferData({
+ path: '/content/dam/mas/acom/en_US/cards/card-without-osi',
+ fields: [],
+ });
+
+ expect(offerData).to.equal(null);
+ expect(commerceService.collectPriceOptions.called).to.be.false;
+ });
+
+ it('reuses cached data for subsequent calls', async () => {
+ const cache = new Map();
+ const fragment = {
+ path: '/content/dam/mas/acom/en_US/cards/card1',
+ fields: [{ name: 'osi', values: ['osi-123'] }],
+ };
+
+ const firstResult = await loadOfferData(fragment, { cache });
+ const secondResult = await loadOfferData(fragment, { cache });
+
+ expect(firstResult).to.deep.equal({ offerId: 'test-offer-id' });
+ expect(secondResult).to.deep.equal({ offerId: 'test-offer-id' });
+ expect(commerceService.collectPriceOptions.calledOnce).to.be.true;
+ expect(cache.get('osi-123')).to.deep.equal({ offerId: 'test-offer-id' });
+ });
+
+ it('returns null and caches the failure when offer loading throws', async () => {
+ commerceService.resolveOfferSelectors = sandbox.stub().returns([Promise.reject(new Error('boom'))]);
+ const cache = new Map();
+
+ const offerData = await loadOfferData(
+ {
+ id: 'card-1',
+ path: '/content/dam/mas/acom/en_US/cards/card1',
+ fields: [{ name: 'osi', values: ['osi-123'] }],
+ },
+ { cache },
+ );
+
+ expect(offerData).to.equal(null);
+ expect(cache.has('osi-123')).to.be.true;
+ expect(cache.get('osi-123')).to.equal(null);
+ });
+});
diff --git a/studio/test/common/item-loading.test.js b/studio/test/common/item-loading.test.js
new file mode 100644
index 000000000..f5d408008
--- /dev/null
+++ b/studio/test/common/item-loading.test.js
@@ -0,0 +1,343 @@
+import { expect } from '@esm-bundle/chai';
+import sinon from 'sinon';
+import { Fragment } from '../../src/aem/fragment.js';
+import { CARD_MODEL_PATH, COLLECTION_MODEL_PATH } from '../../src/constants.js';
+import {
+ buildItemsByPath,
+ enrichCards,
+ fetchVariationDataByPath,
+ flattenGroupedVariationsByParent,
+ loadCardVariationsByPath,
+ loadGroupedVariations,
+ loadItemsByPath,
+ parseFragmentsFromStore,
+ parsePlaceholdersFromStore,
+ processConcurrently,
+ selectItemsByPath,
+} from '../../src/common/utils/item-loading.js';
+
+describe('common/utils/item-loading', () => {
+ let sandbox;
+
+ beforeEach(() => {
+ sandbox = sinon.createSandbox();
+ });
+
+ afterEach(() => {
+ sandbox.restore();
+ });
+
+ it('buildItemsByPath creates a path-indexed map', () => {
+ const items = [
+ { path: '/a', title: 'A' },
+ { path: '/b', title: 'B' },
+ ];
+
+ const map = buildItemsByPath(items);
+
+ expect(map.get('/a')).to.equal(items[0]);
+ expect(map.get('/b')).to.equal(items[1]);
+ });
+
+ it('selectItemsByPath preserves selected path order and filters missing items', () => {
+ const first = { path: '/a', title: 'A' };
+ const second = { path: '/b', title: 'B' };
+ const map = new Map([
+ ['/a', first],
+ ['/b', second],
+ ]);
+
+ const selected = selectItemsByPath(['/b', '/missing', '/a'], map);
+
+ expect(selected).to.deep.equal([second, first]);
+ });
+
+ it('flattenGroupedVariationsByParent flattens nested maps', () => {
+ const variation = { path: '/card/pzn/v1', title: 'Variation' };
+ const flattened = flattenGroupedVariationsByParent(new Map([['/card', new Map([['/card/pzn/v1', variation]])]]));
+
+ expect(flattened.get('/card/pzn/v1')).to.equal(variation);
+ });
+
+ it('processConcurrently preserves result order while respecting the concurrency limit', async () => {
+ let activeCount = 0;
+ let maxActiveCount = 0;
+
+ const results = await processConcurrently(
+ [1, 2, 3, 4],
+ async (item) => {
+ activeCount += 1;
+ maxActiveCount = Math.max(maxActiveCount, activeCount);
+ await new Promise((resolve) => setTimeout(resolve, 5));
+ activeCount -= 1;
+ return item * 2;
+ },
+ 2,
+ 2,
+ );
+
+ expect(results).to.deep.equal([2, 4, 6, 8]);
+ expect(maxActiveCount).to.equal(2);
+ });
+
+ it('parseFragmentsFromStore splits cards and collections and applies display name', () => {
+ const getDisplayName = sandbox.stub().returns('Display Name');
+ const allFragments = [
+ {
+ value: {
+ path: '/card',
+ title: 'Card',
+ model: { path: CARD_MODEL_PATH },
+ },
+ },
+ {
+ value: {
+ path: '/collection',
+ title: 'Collection',
+ model: { path: COLLECTION_MODEL_PATH },
+ },
+ },
+ ];
+
+ const { allCards, allCollections } = parseFragmentsFromStore(allFragments, { getDisplayName });
+
+ expect(allCards).to.have.lengthOf(1);
+ expect(allCards[0].studioPath).to.equal('Display Name');
+ expect(allCollections).to.have.lengthOf(1);
+ expect(allCollections[0].studioPath).to.equal('Display Name');
+ });
+
+ it('loadItemsByPath fetches items and decorates them with a display name', async () => {
+ const getDisplayName = sandbox.stub().returns('Display Name');
+ const fragmentData = {
+ path: '/content/dam/mas/acom/en_US/cards/card1',
+ title: 'Card 1',
+ model: { path: CARD_MODEL_PATH },
+ fields: [],
+ };
+ const getByPath = sandbox.stub().resolves(fragmentData);
+
+ const items = await loadItemsByPath([fragmentData.path], { getByPath, getDisplayName });
+
+ expect(items).to.have.lengthOf(1);
+ expect(items[0].studioPath).to.equal('Display Name');
+ expect(getByPath.calledOnceWith(fragmentData.path)).to.be.true;
+ });
+
+ it('loadItemsByPath skips paths that fail to load and keeps the successful items', async () => {
+ const getByPath = sandbox.stub();
+ getByPath.onFirstCall().resolves({
+ path: '/content/dam/mas/acom/en_US/cards/card1',
+ title: 'Card 1',
+ model: { path: CARD_MODEL_PATH },
+ fields: [],
+ });
+ getByPath.onSecondCall().rejects(new Error('not found'));
+
+ const items = await loadItemsByPath(
+ ['/content/dam/mas/acom/en_US/cards/card1', '/content/dam/mas/acom/en_US/cards/missing'],
+ { getByPath },
+ );
+
+ expect(items).to.have.lengthOf(1);
+ expect(items[0].path).to.equal('/content/dam/mas/acom/en_US/cards/card1');
+ });
+
+ it('loadGroupedVariations returns enriched grouped variations for valid refs only', async () => {
+ const getDisplayName = sandbox.stub().returns('Variation Name');
+ const getOfferData = sandbox.stub().resolves({ offerId: 'test-offer-id' });
+ const validVariationPath = '/content/dam/mas/acom/en_US/cards/card1/pzn/v1';
+ const invalidVariationPath = '/content/dam/mas/acom/en_US/cards/card1/pzn/v2';
+ const card = new Fragment({
+ path: '/content/dam/mas/acom/en_US/cards/card1',
+ title: 'Card 1',
+ model: { path: CARD_MODEL_PATH },
+ fields: [{ name: 'variations', values: [validVariationPath, invalidVariationPath] }],
+ references: [{ path: validVariationPath }, { path: invalidVariationPath }],
+ });
+ const getByPath = sandbox.stub();
+
+ getByPath.withArgs(validVariationPath).resolves({
+ path: validVariationPath,
+ fieldTags: [{ id: 'tag-1' }],
+ fields: [{ name: 'osi', values: ['osi-123'] }],
+ });
+ getByPath.withArgs(invalidVariationPath).resolves({
+ path: invalidVariationPath,
+ fieldTags: [],
+ fields: [{ name: 'osi', values: ['osi-456'] }],
+ });
+
+ const variations = await loadGroupedVariations(card, { getByPath, getOfferData, getDisplayName });
+
+ expect(variations).to.have.lengthOf(1);
+ expect(variations[0].path).to.equal(validVariationPath);
+ expect(variations[0].studioPath).to.equal('Variation Name');
+ expect(variations[0].offerData).to.deep.equal({ offerId: 'test-offer-id' });
+ });
+
+ it('fetchVariationDataByPath resolves and enriches grouped variations', async () => {
+ const getDisplayName = sandbox.stub().returns('Variation Name');
+ const getOfferData = sandbox.stub().resolves({ offerId: 'test-offer-id' });
+ const variationPath = '/content/dam/mas/acom/en_US/cards/parent/pzn/v1';
+ const getByPath = sandbox.stub().resolves({
+ path: variationPath,
+ fieldTags: [{ id: 'tag-1' }],
+ fields: [{ name: 'osi', values: ['osi-123'] }],
+ });
+
+ const result = await fetchVariationDataByPath(variationPath, { getByPath, getOfferData, getDisplayName });
+
+ expect(result.parentCardPath).to.equal('/content/dam/mas/acom/en_US/cards/parent');
+ expect(result.variation.path).to.equal(variationPath);
+ expect(result.variation.studioPath).to.equal('Variation Name');
+ expect(result.variation.offerData).to.deep.equal({ offerId: 'test-offer-id' });
+ });
+
+ it('fetchVariationDataByPath returns null for a non-grouped variation path', async () => {
+ const getByPath = sandbox.stub();
+
+ const result = await fetchVariationDataByPath('/content/dam/mas/acom/en_US/cards/card1', { getByPath });
+
+ expect(result).to.equal(null);
+ expect(getByPath.called).to.be.false;
+ });
+
+ it('loadCardVariationsByPath returns a keyed map of enriched variations', async () => {
+ const getDisplayName = sandbox.stub().returns('Variation Name');
+ const getOfferData = sandbox.stub().resolves({ offerId: 'test-offer-id' });
+ const variationPath = '/content/dam/mas/acom/en_US/cards/parent/pzn/v1';
+ const getByPath = sandbox.stub().resolves({
+ path: variationPath,
+ fieldTags: [{ id: 'tag-1' }],
+ fields: [{ name: 'osi', values: ['osi-123'] }],
+ });
+
+ const variationsByPath = await loadCardVariationsByPath([variationPath], {
+ getByPath,
+ getOfferData,
+ getDisplayName,
+ });
+
+ expect(variationsByPath.get(variationPath).studioPath).to.equal('Variation Name');
+ expect(variationsByPath.get(variationPath).offerData).to.deep.equal({ offerId: 'test-offer-id' });
+ });
+
+ it('loadCardVariationsByPath filters out invalid variations', async () => {
+ const validVariationPath = '/content/dam/mas/acom/en_US/cards/parent/pzn/v1';
+ const invalidVariationPath = '/content/dam/mas/acom/en_US/cards/parent/pzn/v2';
+ const getByPath = sandbox.stub();
+
+ getByPath.withArgs(validVariationPath).resolves({
+ path: validVariationPath,
+ fieldTags: [{ id: 'tag-1' }],
+ fields: [{ name: 'osi', values: ['osi-123'] }],
+ });
+ getByPath.withArgs(invalidVariationPath).resolves({
+ path: invalidVariationPath,
+ fieldTags: [],
+ fields: [{ name: 'osi', values: ['osi-456'] }],
+ });
+
+ const variationsByPath = await loadCardVariationsByPath([validVariationPath, invalidVariationPath], { getByPath });
+
+ expect(variationsByPath.size).to.equal(1);
+ expect(variationsByPath.has(validVariationPath)).to.be.true;
+ expect(variationsByPath.has(invalidVariationPath)).to.be.false;
+ });
+
+ it('enrichCards adds offer data and grouped variations while reusing existing data', async () => {
+ const groupedVariationPath = '/content/dam/mas/acom/en_US/cards/card1/pzn/v1';
+ const cardData = new Fragment({
+ path: '/content/dam/mas/acom/en_US/cards/card1',
+ title: 'Card 1',
+ model: { path: CARD_MODEL_PATH },
+ tags: [],
+ fields: [
+ { name: 'osi', values: ['osi-123'] },
+ { name: 'variations', values: [groupedVariationPath] },
+ ],
+ references: [{ path: groupedVariationPath }],
+ });
+ const getByPath = sandbox.stub().resolves({
+ path: groupedVariationPath,
+ fieldTags: [{ id: 'tag-1' }],
+ fields: [{ name: 'osi', values: ['osi-variation'] }],
+ });
+ const getOfferData = sandbox.stub().resolves({ offerId: 'variation-offer' });
+
+ const cards = await enrichCards([cardData], {
+ getByPath,
+ getOfferData,
+ getDisplayName: () => 'Display Name',
+ existingOfferDataByPath: new Map([[cardData.path, { offerId: 'cached-offer' }]]),
+ });
+
+ expect(cards).to.have.lengthOf(1);
+ expect(cards[0].offerData).to.deep.equal({ offerId: 'cached-offer' });
+ expect(cards[0].groupedVariations).to.have.lengthOf(1);
+ expect(cards[0].groupedVariations[0].path).to.equal(groupedVariationPath);
+ });
+
+ it('enrichCards returns an empty array when the signal is already aborted after loading offer data', async () => {
+ const abortController = new AbortController();
+ abortController.abort();
+ const cardData = new Fragment({
+ path: '/content/dam/mas/acom/en_US/cards/card1',
+ title: 'Card 1',
+ model: { path: CARD_MODEL_PATH },
+ tags: [],
+ fields: [{ name: 'osi', values: ['osi-123'] }],
+ });
+ const getOfferData = sandbox.stub().resolves({ offerId: 'offer-1' });
+
+ const cards = await enrichCards([cardData], {
+ getByPath: sandbox.stub(),
+ getOfferData,
+ signal: abortController.signal,
+ });
+
+ expect(cards).to.deep.equal([]);
+ });
+ it('parsePlaceholdersFromStore extracts placeholders and applies display name', () => {
+ const getDisplayName = sinon.stub().returns('placeholder: buy-now');
+ const stores = [
+ {
+ get: () => ({
+ key: 'buy-now',
+ value: 'Buy now',
+ path: '/content/dam/mas/acom/en_US/placeholders/buy-now',
+ status: 'Published',
+ }),
+ },
+ {
+ get: () => ({
+ key: 'save-now',
+ value: 'Save now',
+ path: '/content/dam/mas/acom/en_US/placeholders/save-now',
+ status: 'Draft',
+ }),
+ },
+ ];
+
+ const result = parsePlaceholdersFromStore(stores, { getDisplayName });
+
+ expect(result).to.have.lengthOf(2);
+ expect(result[0].key).to.equal('buy-now');
+ expect(result[0].studioPath).to.equal('placeholder: buy-now');
+ expect(result[1].key).to.equal('save-now');
+ });
+
+ it('parsePlaceholdersFromStore filters out entries without a key', () => {
+ const stores = [
+ { get: () => ({ key: 'valid', value: 'Yes' }) },
+ { get: () => ({ value: 'No key here' }) },
+ { get: () => null },
+ ];
+
+ const result = parsePlaceholdersFromStore(stores);
+
+ expect(result).to.have.lengthOf(1);
+ expect(result[0].key).to.equal('valid');
+ });
+});
diff --git a/studio/test/common/utils/render-utils.test.js b/studio/test/common/utils/render-utils.test.js
new file mode 100644
index 000000000..af955daf8
--- /dev/null
+++ b/studio/test/common/utils/render-utils.test.js
@@ -0,0 +1,76 @@
+import { expect } from '@esm-bundle/chai';
+import { nothing, render } from 'lit';
+import { renderFragmentStatusCell, getItemTypeLabel, getItemTitle } from '../../../src/common/utils/render-utils.js';
+import { CARD_MODEL_PATH, COLLECTION_MODEL_PATH, FRAGMENT_STATUS } from '../../../src/constants.js';
+
+describe('render-utils', () => {
+ describe('renderFragmentStatusCell', () => {
+ it('returns nothing when status is missing', () => {
+ expect(renderFragmentStatusCell()).to.equal(nothing);
+ expect(renderFragmentStatusCell('')).to.equal(nothing);
+ });
+
+ it('renders published status with green class', () => {
+ const container = document.createElement('div');
+ render(renderFragmentStatusCell(FRAGMENT_STATUS.PUBLISHED), container);
+ const dot = container.querySelector('.status-dot');
+ expect(dot?.classList.contains('green')).to.be.true;
+ expect(container.textContent).to.include('Published');
+ });
+
+ it('renders modified status with blue class', () => {
+ const container = document.createElement('div');
+ render(renderFragmentStatusCell(FRAGMENT_STATUS.MODIFIED), container);
+ const dot = container.querySelector('.status-dot');
+ expect(dot?.classList.contains('blue')).to.be.true;
+ expect(container.textContent).to.include('Modified');
+ });
+ });
+
+ describe('getItemTypeLabel', () => {
+ it('returns Unknown for falsy item', () => {
+ expect(getItemTypeLabel(null)).to.equal('Unknown');
+ expect(getItemTypeLabel(undefined)).to.equal('Unknown');
+ });
+
+ it('returns Grouped variation when path is a grouped variation path', () => {
+ expect(getItemTypeLabel({ path: '/content/x/pzn/y/var' })).to.equal('Grouped variation');
+ });
+
+ it('returns Placeholder for dictionary model', () => {
+ expect(getItemTypeLabel({ model: { path: '/conf/.../dictionary/foo' } })).to.equal('Placeholder');
+ });
+
+ it('returns Collection for collection model', () => {
+ expect(getItemTypeLabel({ model: { path: COLLECTION_MODEL_PATH } })).to.equal('Collection');
+ });
+
+ it('returns Default for card model', () => {
+ expect(getItemTypeLabel({ model: { path: CARD_MODEL_PATH } })).to.equal('Default');
+ });
+ });
+
+ describe('getItemTitle', () => {
+ it('returns dash for falsy item', () => {
+ expect(getItemTitle(null)).to.equal('-');
+ });
+
+ it('truncates long card titles', () => {
+ const long = 'a'.repeat(60);
+ expect(getItemTitle({ model: { path: CARD_MODEL_PATH }, title: long }).length).to.be.lessThan(long.length);
+ expect(getItemTitle({ model: { path: CARD_MODEL_PATH }, title: long })).to.include('...');
+ });
+
+ it('uses key for placeholder-like items', () => {
+ expect(getItemTitle({ key: 'my-key' })).to.equal('my-key');
+ });
+
+ it('uses getFieldValue when present', () => {
+ expect(
+ getItemTitle({
+ getFieldValue: (f) => (f === 'key' ? 'from-field' : ''),
+ }),
+ ).to.equal('from-field');
+ });
+ });
+});
diff --git a/studio/test/translation/mas-collapsible-table-row.test.js b/studio/test/translation/mas-collapsible-table-row.test.js
index 3e7f941cc..3f6a1ab69 100644
--- a/studio/test/translation/mas-collapsible-table-row.test.js
+++ b/studio/test/translation/mas-collapsible-table-row.test.js
@@ -3,8 +3,10 @@ import { html } from 'lit';
import { fixture, fixtureCleanup } from '@open-wc/testing-helpers/pure';
import sinon from 'sinon';
import Store from '../../src/store.js';
-import { setCardVariationsByPaths } from '../../src/translation/translation-items-loader.js';
+import { setItemsSelectionStore } from '../../src/common/items-selection-store.js';
+import { setCardVariationsByPaths } from '../../src/common/utils/items-loader.js';
import { CARD_MODEL_PATH, COLLECTION_MODEL_PATH, FRAGMENT_STATUS } from '../../src/constants.js';
+import { renderFragmentStatusCell } from '../../src/translation/translation-utils.js';
import '../../src/swc.js';
import '../../src/translation/mas-collapsible-table-row.js';
@@ -48,6 +50,7 @@ describe('MasCollapsibleTableRow', () => {
beforeEach(() => {
sandbox = sinon.createSandbox();
+ setItemsSelectionStore(Store.translationProjects);
resetStore();
createMockRepository();
});
@@ -57,6 +60,7 @@ describe('MasCollapsibleTableRow', () => {
sandbox.restore();
resetStore();
removeMockRepository();
+ setItemsSelectionStore(null);
});
describe('initialization', () => {
@@ -424,7 +428,10 @@ describe('MasCollapsibleTableRow', () => {
it('should render published status with green class', async () => {
const topLevelCard = createMockTopLevelCard({ status: FRAGMENT_STATUS.PUBLISHED });
const el = await fixture(
- html``,
+ html``,
);
const statusDot = el.shadowRoot.querySelector('.status-dot.green');
expect(statusDot).to.exist;
@@ -433,7 +440,10 @@ describe('MasCollapsibleTableRow', () => {
it('should render modified status with blue class', async () => {
const topLevelCard = createMockTopLevelCard({ status: FRAGMENT_STATUS.MODIFIED });
const el = await fixture(
- html``,
+ html``,
);
const statusDot = el.shadowRoot.querySelector('.status-dot.blue');
expect(statusDot).to.exist;
@@ -488,7 +498,7 @@ describe('MasCollapsibleTableRow', () => {
expect(groupedCell).to.exist;
});
- it('should render "no type" for unknown model path', async () => {
+ it('should render "Unknown" for unknown model path', async () => {
const topLevelCard = createMockTopLevelCard({
modelPath: '/conf/mas/settings/dam/cfm/models/unknown',
});
@@ -496,7 +506,7 @@ describe('MasCollapsibleTableRow', () => {
html``,
);
const shadowText = el.shadowRoot?.textContent || '';
- expect(shadowText).to.include('no type');
+ expect(shadowText).to.include('Unknown');
});
});
@@ -794,7 +804,7 @@ describe('MasCollapsibleTableRow', () => {
const el = await fixture(
html``,
);
- const chevronCell = el.shadowRoot.querySelector('.translation-table-icon-cell--chevron');
+ const chevronCell = el.shadowRoot.querySelector('.table-icon-cell--chevron');
expect(chevronCell).to.exist;
});
diff --git a/studio/test/translation/mas-items-selector.test.js b/studio/test/translation/mas-items-selector.test.js
index 2adbbb364..843e7e5e2 100644
--- a/studio/test/translation/mas-items-selector.test.js
+++ b/studio/test/translation/mas-items-selector.test.js
@@ -3,16 +3,18 @@ import { html } from 'lit';
import { fixture, fixtureCleanup } from '@open-wc/testing-helpers/pure';
import sinon from 'sinon';
import Store from '../../src/store.js';
+import { setItemsSelectionStore } from '../../src/common/items-selection-store.js';
import { TABLE_TYPE } from '../../src/constants.js';
import '../../src/swc.js';
-import '../../src/translation/mas-items-selector.js';
-import { TABS } from '../../src/translation/mas-items-selector.js';
+import '../../src/common/components/mas-items-selector.js';
+import { TABS } from '../../src/common/components/mas-items-selector.js';
describe('MasItemsSelector', () => {
let sandbox;
beforeEach(() => {
sandbox = sinon.createSandbox();
+ setItemsSelectionStore(Store.translationProjects);
Store.translationProjects.inEdit.set(null);
Store.translationProjects.showSelected.set(false);
Store.translationProjects.selectedCards.set([]);
@@ -28,6 +30,7 @@ describe('MasItemsSelector', () => {
Store.translationProjects.selectedCards.set([]);
Store.translationProjects.selectedCollections.set([]);
Store.translationProjects.selectedPlaceholders.set([]);
+ setItemsSelectionStore(null);
});
describe('TABS constant', () => {
diff --git a/studio/test/translation/mas-search-and-filters.test.js b/studio/test/translation/mas-search-and-filters.test.js
index 8306fa033..440b3f399 100644
--- a/studio/test/translation/mas-search-and-filters.test.js
+++ b/studio/test/translation/mas-search-and-filters.test.js
@@ -3,9 +3,10 @@ import { html } from 'lit';
import { fixture, fixtureCleanup } from '@open-wc/testing-helpers/pure';
import sinon from 'sinon';
import Store from '../../src/store.js';
+import { setItemsSelectionStore } from '../../src/common/items-selection-store.js';
import { TABLE_TYPE, FILTER_TYPE } from '../../src/constants.js';
import '../../src/swc.js';
-import '../../src/translation/mas-search-and-filters.js';
+import '../../src/common/components/mas-search-and-filters.js';
describe('MasSearchAndFilters', () => {
let sandbox;
@@ -27,6 +28,7 @@ describe('MasSearchAndFilters', () => {
beforeEach(() => {
sandbox = sinon.createSandbox();
+ setItemsSelectionStore(Store.translationProjects);
Store.translationProjects.allCards.set([]);
Store.translationProjects.displayCards.set([]);
Store.translationProjects.allCollections.set([]);
@@ -50,6 +52,7 @@ describe('MasSearchAndFilters', () => {
Store.fragments.list.loading.set(false);
Store.placeholders.list.loading.set(false);
Store.placeholders.list.data.set([]);
+ setItemsSelectionStore(null);
});
describe('initialization', () => {
diff --git a/studio/test/translation/mas-select-items-table.test.js b/studio/test/translation/mas-select-items-table.test.js
index ac373db11..38a459e1d 100644
--- a/studio/test/translation/mas-select-items-table.test.js
+++ b/studio/test/translation/mas-select-items-table.test.js
@@ -3,9 +3,12 @@ import { html } from 'lit';
import { fixture, fixtureCleanup } from '@open-wc/testing-helpers/pure';
import sinon from 'sinon';
import Store from '../../src/store.js';
+import { setItemsSelectionStore } from '../../src/common/items-selection-store.js';
import { CARD_MODEL_PATH, COLLECTION_MODEL_PATH, TABLE_TYPE, FRAGMENT_STATUS } from '../../src/constants.js';
+import { renderFragmentStatusCell } from '../../src/translation/translation-utils.js';
import '../../src/swc.js';
-import '../../src/translation/mas-select-items-table.js';
+import '../../src/translation/mas-collapsible-table-row.js';
+import '../../src/common/components/mas-select-items-table.js';
describe('MasSelectItemsTable', () => {
let sandbox;
@@ -109,6 +112,7 @@ describe('MasSelectItemsTable', () => {
beforeEach(() => {
sandbox = sinon.createSandbox();
+ setItemsSelectionStore(Store.translationProjects);
resetStore();
mockCommerceService = createMockCommerceService();
});
@@ -118,6 +122,7 @@ describe('MasSelectItemsTable', () => {
sandbox.restore();
resetStore();
removeMockCommerceService();
+ setItemsSelectionStore(null);
});
describe('initialization', () => {
@@ -540,10 +545,14 @@ describe('MasSelectItemsTable', () => {
describe('rendering - status cell', () => {
it('should render Published status with green dot', async () => {
- const el = await fixture(html``);
- await el.updateComplete;
const cards = [createMockCard('/path/card1', 'Card 1', { status: FRAGMENT_STATUS.PUBLISHED })];
setupCardsInStore(cards);
+ const el = await fixture(
+ html``,
+ );
await el.updateComplete;
const collapsibleRow = el.shadowRoot.querySelector('mas-collapsible-table-row');
const statusCell = collapsibleRow.shadowRoot.querySelector('.status-cell');
@@ -553,10 +562,14 @@ describe('MasSelectItemsTable', () => {
});
it('should render Modified status with blue dot', async () => {
- const el = await fixture(html``);
- await el.updateComplete;
const cards = [createMockCard('/path/card1', 'Card 1', { status: FRAGMENT_STATUS.MODIFIED })];
setupCardsInStore(cards);
+ const el = await fixture(
+ html``,
+ );
await el.updateComplete;
const collapsibleRow = el.shadowRoot.querySelector('mas-collapsible-table-row');
const statusCell = collapsibleRow.shadowRoot.querySelector('.status-cell');
@@ -566,10 +579,14 @@ describe('MasSelectItemsTable', () => {
});
it('should render Draft status without color class', async () => {
- const el = await fixture(html``);
- await el.updateComplete;
const cards = [createMockCard('/path/card1', 'Card 1', { status: FRAGMENT_STATUS.DRAFT })];
setupCardsInStore(cards);
+ const el = await fixture(
+ html``,
+ );
await el.updateComplete;
const collapsibleRow = el.shadowRoot.querySelector('mas-collapsible-table-row');
const statusCell = collapsibleRow.shadowRoot.querySelector('.status-cell');
diff --git a/studio/test/translation/mas-selected-items.test.js b/studio/test/translation/mas-selected-items.test.js
index e4072df33..9ec59851b 100644
--- a/studio/test/translation/mas-selected-items.test.js
+++ b/studio/test/translation/mas-selected-items.test.js
@@ -3,10 +3,11 @@ import { html } from 'lit';
import { fixture, fixtureCleanup } from '@open-wc/testing-helpers/pure';
import sinon from 'sinon';
import Store from '../../src/store.js';
-import { setCardVariationsByPaths } from '../../src/translation/translation-items-loader.js';
+import { setItemsSelectionStore } from '../../src/common/items-selection-store.js';
+import { setCardVariationsByPaths } from '../../src/common/utils/items-loader.js';
import { CARD_MODEL_PATH, COLLECTION_MODEL_PATH } from '../../src/constants.js';
import '../../src/swc.js';
-import '../../src/translation/mas-selected-items.js';
+import '../../src/common/components/mas-selected-items.js';
describe('MasSelectedItems', () => {
let sandbox;
@@ -58,6 +59,7 @@ describe('MasSelectedItems', () => {
beforeEach(() => {
sandbox = sinon.createSandbox();
+ setItemsSelectionStore(Store.translationProjects);
Store.translationProjects.showSelected.set(false);
Store.translationProjects.selectedCards.set([]);
Store.translationProjects.selectedCollections.set([]);
@@ -73,6 +75,7 @@ describe('MasSelectedItems', () => {
Store.translationProjects.selectedCollections.set([]);
Store.translationProjects.selectedPlaceholders.set([]);
resetMaps();
+ setItemsSelectionStore(null);
});
describe('initialization', () => {
@@ -333,7 +336,7 @@ describe('MasSelectedItems', () => {
const el = await fixture(html``);
const typeEl = el.shadowRoot.querySelector('.type');
expect(typeEl).to.exist;
- expect(typeEl.textContent.trim()).to.equal('Default card');
+ expect(typeEl.textContent.trim()).to.equal('Default');
});
it('should render remove button for each item', async () => {
@@ -519,7 +522,7 @@ describe('MasSelectedItems', () => {
it('should handle undefined item gracefully in getType', async () => {
const el = await fixture(html``);
- expect(el.getType(undefined)).to.equal('Unknown type');
+ expect(el.getType(undefined)).to.equal('Unknown');
});
});
});
diff --git a/studio/test/translation/mas-translation-editor.test.js b/studio/test/translation/mas-translation-editor.test.js
index c479316e6..3e71477b9 100644
--- a/studio/test/translation/mas-translation-editor.test.js
+++ b/studio/test/translation/mas-translation-editor.test.js
@@ -4,6 +4,7 @@ import { html } from 'lit';
import { fixture, fixtureCleanup } from '@open-wc/testing-helpers/pure';
import { PAGE_NAMES, QUICK_ACTION, TRANSLATION_PROJECT_MODEL_ID } from '../../src/constants.js';
import Store from '../../src/store.js';
+import { setItemsSelectionStore } from '../../src/common/items-selection-store.js';
import router from '../../src/router.js';
import Events from '../../src/events.js';
import { Fragment } from '../../src/aem/fragment.js';
@@ -88,6 +89,7 @@ describe('MasTranslationEditor', () => {
beforeEach(() => {
sandbox = sinon.createSandbox();
+ setItemsSelectionStore(Store.translationProjects);
toastEmitStub = sandbox.stub(Events.toast, 'emit');
originalQuerySelector = document.querySelector.bind(document);
defaultMockRepository = {
@@ -119,6 +121,7 @@ describe('MasTranslationEditor', () => {
fixtureCleanup();
sandbox.restore();
resetStores();
+ setItemsSelectionStore(null);
});
describe('initialization', () => {
diff --git a/studio/test/translation/mas-translation.test.js b/studio/test/translation/mas-translation.test.js
index f63048522..c8b08a9fb 100644
--- a/studio/test/translation/mas-translation.test.js
+++ b/studio/test/translation/mas-translation.test.js
@@ -162,7 +162,7 @@ describe('MasTranslation', () => {
const mockProjects = [createMockTranslationProject('1', 'Project 1')];
Store.translationProjects.list.data.value = mockProjects;
const el = await fixture(html``);
- const table = el.shadowRoot.querySelector('.translation-table');
+ const table = el.shadowRoot.querySelector('.item-table');
expect(table).to.exist;
});
diff --git a/studio/test/translation/translation-items-loader.test.js b/studio/test/translation/translation-items-loader.test.js
index a2d7442ad..086f89c09 100644
--- a/studio/test/translation/translation-items-loader.test.js
+++ b/studio/test/translation/translation-items-loader.test.js
@@ -1,6 +1,7 @@
import { expect } from '@esm-bundle/chai';
import sinon from 'sinon';
import Store from '../../src/store.js';
+import { setItemsSelectionStore } from '../../src/common/items-selection-store.js';
import { Fragment } from '../../src/aem/fragment.js';
import { TABLE_TYPE, COLLECTION_MODEL_PATH, CARD_MODEL_PATH } from '../../src/constants.js';
import {
@@ -12,11 +13,12 @@ import {
fetchUnresolvedVariations,
fetchVariationByPath,
setCardVariationsByPaths,
-} from '../../src/translation/translation-items-loader.js';
+} from '../../src/common/utils/items-loader.js';
describe('translation-items-loader', () => {
let sandbox;
+ const mockGetDisplayName = () => 'mock-display-name';
const resetStore = () => {
Store.translationProjects.allCards.set([]);
Store.translationProjects.cardsByPaths.set(new Map());
@@ -50,6 +52,7 @@ describe('translation-items-loader', () => {
beforeEach(() => {
sandbox = sinon.createSandbox();
+ setItemsSelectionStore(Store.translationProjects);
resetStore();
createMockCommerceService();
});
@@ -58,6 +61,7 @@ describe('translation-items-loader', () => {
sandbox.restore();
resetStore();
removeMockCommerceService();
+ setItemsSelectionStore(null);
});
describe('setCardVariationsByPaths', () => {
@@ -115,10 +119,16 @@ describe('translation-items-loader', () => {
});
describe('loadAllFragments', () => {
+ it('should return no-op subscription when allCards already has data', () => {
+ Store.translationProjects.allCards.set([{ path: '/card1', title: 'Card 1' }]);
+ const result = loadAllFragments(TABLE_TYPE.CARDS, null, {}, { getDisplayName: mockGetDisplayName });
+ expect(result.unsubscribe).to.be.a('function');
+ expect(Store.translationProjects.allCards.get()).to.have.lengthOf(1);
+ });
+
it('should not subscribe for collections (loaded via repository.loadAllCollections)', async () => {
const before = Store.translationProjects.allCollections.get();
const result = loadAllFragments(TABLE_TYPE.COLLECTIONS, null, {});
-
const mockCollection = {
value: {
path: '/content/dam/mas/acom/en_US/collections/test',
@@ -149,7 +159,7 @@ describe('translation-items-loader', () => {
},
};
- const result = loadAllFragments(TABLE_TYPE.CARDS, repo, state);
+ const result = loadAllFragments(TABLE_TYPE.CARDS, repo, state, { getDisplayName: mockGetDisplayName });
const mockCardData = {
path: '/content/dam/mas/acom/en_US/cards/card1',
@@ -195,8 +205,7 @@ describe('translation-items-loader', () => {
fields: [{ name: 'variations', values: [variationPath] }],
references: [{ path: variationPath }],
});
-
- const result = loadAllFragments(TABLE_TYPE.CARDS, repo, state);
+ const result = loadAllFragments(TABLE_TYPE.CARDS, repo, state, { getDisplayName: mockGetDisplayName });
Store.fragments.list.data.set([{ value: mockCardFragment }]);
await new Promise((r) => setTimeout(r, 200));
@@ -253,14 +262,17 @@ describe('translation-items-loader', () => {
describe('loadSelectedFragments', () => {
it('should call onItems with empty array when repository is null', async () => {
const onItems = sinon.stub();
- await loadSelectedFragments(['/path/1'], TABLE_TYPE.CARDS, null, { onItems });
+ await loadSelectedFragments(['/path/1'], TABLE_TYPE.CARDS, null, {
+ onItems,
+ getDisplayName: mockGetDisplayName,
+ });
expect(onItems.calledWith([])).to.be.true;
});
it('should call onItems with empty array when selectedPaths is empty', async () => {
const onItems = sinon.stub();
const repo = { aem: { getFragmentByPath: sinon.stub() } };
- await loadSelectedFragments([], TABLE_TYPE.CARDS, repo, { onItems });
+ await loadSelectedFragments([], TABLE_TYPE.CARDS, repo, { onItems, getDisplayName: mockGetDisplayName });
expect(onItems.calledWith([])).to.be.true;
});
@@ -277,7 +289,10 @@ describe('translation-items-loader', () => {
};
const onItems = sinon.stub();
- await loadSelectedFragments([mockFragment.path], TABLE_TYPE.COLLECTIONS, repo, { onItems });
+ await loadSelectedFragments([mockFragment.path], TABLE_TYPE.COLLECTIONS, repo, {
+ onItems,
+ getDisplayName: mockGetDisplayName,
+ });
expect(repo.aem.getFragmentByPath.calledWith(mockFragment.path)).to.be.true;
expect(onItems.called).to.be.true;
@@ -307,7 +322,10 @@ describe('translation-items-loader', () => {
};
const onItems = sinon.stub();
- await loadSelectedFragments([cardPath], TABLE_TYPE.CARDS, repo, { onItems });
+ await loadSelectedFragments([cardPath], TABLE_TYPE.CARDS, repo, {
+ onItems,
+ getDisplayName: mockGetDisplayName,
+ });
expect(repo.aem.getFragmentByPath.calledWith(cardPath)).to.be.true;
expect(onItems.called).to.be.true;
@@ -326,7 +344,10 @@ describe('translation-items-loader', () => {
aem: { getFragmentByPath: sinon.stub().rejects(new Error('Fetch failed')) },
};
- await loadSelectedFragments(['/invalid/path'], TABLE_TYPE.CARDS, repo, { onItems });
+ await loadSelectedFragments(['/invalid/path'], TABLE_TYPE.CARDS, repo, {
+ onItems,
+ getDisplayName: mockGetDisplayName,
+ });
expect(onItems.calledWith([])).to.be.true;
});
@@ -341,7 +362,9 @@ describe('translation-items-loader', () => {
},
};
- await loadSelectedFragments(['/path'], TABLE_TYPE.COLLECTIONS, repo, {});
+ await loadSelectedFragments(['/path'], TABLE_TYPE.COLLECTIONS, repo, {
+ getDisplayName: mockGetDisplayName,
+ });
expect(repo.aem.getFragmentByPath.called).to.be.true;
});
@@ -365,6 +388,7 @@ describe('translation-items-loader', () => {
await loadSelectedFragments([cardPath], TABLE_TYPE.CARDS, repo, {
signal: abortedController.signal,
onItems,
+ getDisplayName: mockGetDisplayName,
});
expect(onItems.called).to.be.false;
@@ -374,7 +398,7 @@ describe('translation-items-loader', () => {
describe('loadCardVariations', () => {
it('should return early when variationPaths is empty', async () => {
const repo = { aem: { getFragmentByPath: sinon.stub() } };
- await loadCardVariations('/card/path', [], repo);
+ await loadCardVariations('/card/path', [], repo, { getDisplayName: mockGetDisplayName });
expect(repo.aem.getFragmentByPath.called).to.be.false;
});
@@ -384,13 +408,13 @@ describe('translation-items-loader', () => {
setCardVariationsByPaths(existingMap);
const repo = { aem: { getFragmentByPath: sinon.stub() } };
- await loadCardVariations('/card/path', ['/var/path'], repo);
+ await loadCardVariations('/card/path', ['/var/path'], repo, { getDisplayName: mockGetDisplayName });
expect(repo.aem.getFragmentByPath.called).to.be.false;
});
it('should return early when repository is null', async () => {
- await loadCardVariations('/card/path', ['/var/path'], null);
+ await loadCardVariations('/card/path', ['/var/path'], null, { getDisplayName: mockGetDisplayName });
expect(Store.translationProjects.groupedVariationsByParent.value?.has('/card/path')).to.be.false;
});
@@ -409,7 +433,7 @@ describe('translation-items-loader', () => {
},
};
- await loadCardVariations(cardPath, [variationPath], repo);
+ await loadCardVariations(cardPath, [variationPath], repo, { getDisplayName: mockGetDisplayName });
expect(repo.aem.getFragmentByPath.calledWith(variationPath)).to.be.true;
const variationsByPaths = Store.translationProjects.groupedVariationsByParent.value?.get(cardPath);
@@ -437,7 +461,7 @@ describe('translation-items-loader', () => {
},
};
- await loadCardVariations(cardPath, [invalidPath], repo);
+ await loadCardVariations(cardPath, [invalidPath], repo, { getDisplayName: mockGetDisplayName });
const variationsByPaths = Store.translationProjects.groupedVariationsByParent.value?.get(cardPath);
expect(variationsByPaths).to.exist;
@@ -451,7 +475,7 @@ describe('translation-items-loader', () => {
aem: { getFragmentByPath: sinon.stub().rejects(new Error('Network error')) },
};
- await loadCardVariations(cardPath, [variationPath], repo);
+ await loadCardVariations(cardPath, [variationPath], repo, { getDisplayName: mockGetDisplayName });
expect(repo.aem.getFragmentByPath.calledWith(variationPath)).to.be.true;
const variationsMap = Store.translationProjects.groupedVariationsByParent.value?.get(cardPath);
@@ -479,7 +503,7 @@ describe('translation-items-loader', () => {
aem: { getFragmentByPath: sinon.stub().resolves(mockVar) },
};
- await loadCardVariations(cardPath2, [varPath2], repo);
+ await loadCardVariations(cardPath2, [varPath2], repo, { getDisplayName: mockGetDisplayName });
const result = Store.translationProjects.groupedVariationsByParent.value;
expect(result.has(cardPath1)).to.be.true;
@@ -493,19 +517,19 @@ describe('translation-items-loader', () => {
const variationPath = '/content/dam/mas/acom/en_US/cards/parent/pzn/var1';
it('should return false when repository is null', async () => {
- const result = await fetchVariationByPath(variationPath, null);
+ const result = await fetchVariationByPath(variationPath, null, { getDisplayName: mockGetDisplayName });
expect(result).to.be.false;
});
it('should return false when repository has no getFragmentByPath', async () => {
- const result = await fetchVariationByPath(variationPath, {});
+ const result = await fetchVariationByPath(variationPath, {}, { getDisplayName: mockGetDisplayName });
expect(result).to.be.false;
});
it('should return false when path is not a grouped variation path', async () => {
const cardPath = '/content/dam/mas/acom/en_US/cards/card1';
const repo = { aem: { getFragmentByPath: sinon.stub() } };
- const result = await fetchVariationByPath(cardPath, repo);
+ const result = await fetchVariationByPath(cardPath, repo, { getDisplayName: mockGetDisplayName });
expect(result).to.be.false;
expect(repo.aem.getFragmentByPath.called).to.be.false;
});
@@ -513,7 +537,7 @@ describe('translation-items-loader', () => {
it('should return false when path has no /pzn/ segment', async () => {
const invalidPath = '/content/dam/mas/acom/en_US/cards/parent/invalid/var1';
const repo = { aem: { getFragmentByPath: sinon.stub() } };
- const result = await fetchVariationByPath(invalidPath, repo);
+ const result = await fetchVariationByPath(invalidPath, repo, { getDisplayName: mockGetDisplayName });
expect(result).to.be.false;
expect(repo.aem.getFragmentByPath.called).to.be.false;
});
@@ -522,7 +546,7 @@ describe('translation-items-loader', () => {
const repo = {
aem: { getFragmentByPath: sinon.stub().rejects(new Error('Network error')) },
};
- const result = await fetchVariationByPath(variationPath, repo);
+ const result = await fetchVariationByPath(variationPath, repo, { getDisplayName: mockGetDisplayName });
expect(result).to.be.false;
});
@@ -536,7 +560,7 @@ describe('translation-items-loader', () => {
aem: { getFragmentByPath: sinon.stub().resolves(mockVariation) },
};
- const result = await fetchVariationByPath(variationPath, repo);
+ const result = await fetchVariationByPath(variationPath, repo, { getDisplayName: mockGetDisplayName });
expect(result).to.be.true;
const cardPath = '/content/dam/mas/acom/en_US/cards/parent';
@@ -553,20 +577,22 @@ describe('translation-items-loader', () => {
it('should not fetch when selectedCards is empty', async () => {
const repo = { aem: { getFragmentByPath: sinon.stub() } };
- await fetchUnresolvedVariations([], new Map(), new Map(), repo);
+ await fetchUnresolvedVariations([], new Map(), new Map(), repo, { getDisplayName: mockGetDisplayName });
expect(repo.aem.getFragmentByPath.called).to.be.false;
});
it('should not fetch when selectedCards is null', async () => {
const repo = { aem: { getFragmentByPath: sinon.stub() } };
- await fetchUnresolvedVariations(null, new Map(), new Map(), repo);
+ await fetchUnresolvedVariations(null, new Map(), new Map(), repo, { getDisplayName: mockGetDisplayName });
expect(repo.aem.getFragmentByPath.called).to.be.false;
});
it('should skip non-grouped-variation paths', async () => {
const defaultCardPath = '/content/dam/mas/acom/en_US/cards/card1';
const repo = { aem: { getFragmentByPath: sinon.stub() } };
- await fetchUnresolvedVariations([defaultCardPath], new Map(), new Map(), repo);
+ await fetchUnresolvedVariations([defaultCardPath], new Map(), new Map(), repo, {
+ getDisplayName: mockGetDisplayName,
+ });
expect(repo.aem.getFragmentByPath.called).to.be.false;
});
@@ -574,7 +600,9 @@ describe('translation-items-loader', () => {
const cardsByPaths = new Map();
cardsByPaths.set(variationPath, { path: variationPath });
const repo = { aem: { getFragmentByPath: sinon.stub() } };
- await fetchUnresolvedVariations([variationPath], cardsByPaths, new Map(), repo);
+ await fetchUnresolvedVariations([variationPath], cardsByPaths, new Map(), repo, {
+ getDisplayName: mockGetDisplayName,
+ });
expect(repo.aem.getFragmentByPath.called).to.be.false;
});
@@ -585,7 +613,9 @@ describe('translation-items-loader', () => {
const groupedVariationsByParent = new Map();
groupedVariationsByParent.set(cardPath, variationsMap);
const repo = { aem: { getFragmentByPath: sinon.stub() } };
- await fetchUnresolvedVariations([variationPath], new Map(), groupedVariationsByParent, repo);
+ await fetchUnresolvedVariations([variationPath], new Map(), groupedVariationsByParent, repo, {
+ getDisplayName: mockGetDisplayName,
+ });
expect(repo.aem.getFragmentByPath.called).to.be.false;
});
@@ -599,7 +629,9 @@ describe('translation-items-loader', () => {
aem: { getFragmentByPath: sinon.stub().resolves(mockVariation) },
};
- await fetchUnresolvedVariations([variationPath], new Map(), new Map(), repo);
+ await fetchUnresolvedVariations([variationPath], new Map(), new Map(), repo, {
+ getDisplayName: mockGetDisplayName,
+ });
expect(repo.aem.getFragmentByPath.calledWith(variationPath)).to.be.true;
const cardPath = '/content/dam/mas/acom/en_US/cards/parent';
@@ -613,7 +645,9 @@ describe('translation-items-loader', () => {
aem: { getFragmentByPath: sinon.stub().rejects(new Error('Network error')) },
};
- await fetchUnresolvedVariations([variationPath], new Map(), new Map(), repo);
+ await fetchUnresolvedVariations([variationPath], new Map(), new Map(), repo, {
+ getDisplayName: mockGetDisplayName,
+ });
expect(repo.aem.getFragmentByPath.calledWith(variationPath)).to.be.true;
const cardPath = '/content/dam/mas/acom/en_US/cards/parent';
@@ -631,7 +665,9 @@ describe('translation-items-loader', () => {
aem: { getFragmentByPath: sinon.stub().resolves(mockInvalidVariation) },
};
- await fetchUnresolvedVariations([variationPath], new Map(), new Map(), repo);
+ await fetchUnresolvedVariations([variationPath], new Map(), new Map(), repo, {
+ getDisplayName: mockGetDisplayName,
+ });
expect(repo.aem.getFragmentByPath.calledWith(variationPath)).to.be.true;
const cardPath = '/content/dam/mas/acom/en_US/cards/parent';
@@ -692,7 +728,9 @@ describe('translation-items-loader', () => {
fields: [],
};
- const { unsubscribe } = loadAllFragments(TABLE_TYPE.CARDS, null, state);
+ const { unsubscribe } = loadAllFragments(TABLE_TYPE.CARDS, null, state, {
+ getDisplayName: mockGetDisplayName,
+ });
Store.fragments.list.data.set([{ value: new Fragment(card) }]);
await new Promise((r) => setTimeout(r, 100));