From eeb36826205ffda36e2cff07014847ace6572ad0 Mon Sep 17 00:00:00 2001 From: lonesahilnazir Date: Sat, 20 Jun 2026 19:08:10 +0530 Subject: [PATCH] fix: update return type documentation for get_page_number_from_query_loop and add unit tests --- src/helpers/pagination-helper.php | 2 +- tests/Unit/Helpers/Pagination_Helper_Test.php | 20 +++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/src/helpers/pagination-helper.php b/src/helpers/pagination-helper.php index 784f7bcfc91..cdf4c31cb08 100644 --- a/src/helpers/pagination-helper.php +++ b/src/helpers/pagination-helper.php @@ -187,7 +187,7 @@ public function get_key_query_loop() { /** * Returns the page number from the query loop. * - * @return string The page number from the query loop. + * @return int|string The page number from the query loop, or an empty string when none applies. */ public function get_page_number_from_query_loop() { $key_query_loop = $this->get_key_query_loop(); diff --git a/tests/Unit/Helpers/Pagination_Helper_Test.php b/tests/Unit/Helpers/Pagination_Helper_Test.php index 6275a23c8ef..cf3f6271465 100644 --- a/tests/Unit/Helpers/Pagination_Helper_Test.php +++ b/tests/Unit/Helpers/Pagination_Helper_Test.php @@ -623,4 +623,24 @@ public function test_get_page_number_from_query_loop( $key, $value, $expects ) { $this->assertEquals( $expects, $this->instance->get_page_number_from_query_loop() ); } + + /** + * @covers ::get_page_number_from_query_loop + * + * @return void + */ + public function test_query_loop_page_number_returns_int_when_above_one() { + $_GET = [ 'query-1-page' => '2' ]; + $this->assertSame( 2, $this->instance->get_page_number_from_query_loop() ); + } + + /** + * @covers ::get_page_number_from_query_loop + * + * @return void + */ + public function test_query_loop_page_number_returns_empty_string_when_absent() { + $_GET = []; + $this->assertSame( '', $this->instance->get_page_number_from_query_loop() ); + } }