From 0ebdd54462a92a48d856858aaab6641f38f8eed9 Mon Sep 17 00:00:00 2001 From: Ricardo Artemio Morales Date: Fri, 23 Feb 2024 17:15:05 -0500 Subject: [PATCH 1/2] Add connection icon to list view --- .../src/components/list-view/block-select-button.js | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/packages/block-editor/src/components/list-view/block-select-button.js b/packages/block-editor/src/components/list-view/block-select-button.js index 6b9de943ea0bf2..b12d3866f8edd5 100644 --- a/packages/block-editor/src/components/list-view/block-select-button.js +++ b/packages/block-editor/src/components/list-view/block-select-button.js @@ -14,7 +14,12 @@ import { Tooltip, } from '@wordpress/components'; import { forwardRef } from '@wordpress/element'; -import { Icon, lockSmall as lock, pinSmall } from '@wordpress/icons'; +import { + Icon, + connection, + lockSmall as lock, + pinSmall, +} from '@wordpress/icons'; import { SPACE, ENTER, BACKSPACE, DELETE } from '@wordpress/keycodes'; import { useSelect, useDispatch } from '@wordpress/data'; import { __unstableUseShortcutEventMatch as useShortcutEventMatch } from '@wordpress/keyboard-shortcuts'; @@ -66,6 +71,7 @@ function ListViewBlockSelectButton( getBlockRootClientId, getBlockOrder, getBlocksByClientId, + getBlockAttributes, canRemoveBlocks, } = useSelect( blockEditorStore ); const { duplicateBlocks, multiSelect, removeBlocks } = @@ -75,6 +81,8 @@ function ListViewBlockSelectButton( const images = useListViewImages( { clientId, isExpanded } ); const { rootClientId } = useListViewContext(); + const isConnected = getBlockAttributes( clientId )?.metadata?.bindings; + const positionLabel = blockInformation?.positionLabel ? sprintf( // translators: 1: Position of selected block, e.g. "Sticky" or "Fixed". @@ -278,9 +286,11 @@ function ListViewBlockSelectButton( ) } + { isConnected && } { positionLabel && isSticky && ( + text ) } { images.length ? ( From 2935d0560ab8c525ea11237b3b77f6290fd0afba Mon Sep 17 00:00:00 2001 From: Ricardo Artemio Morales Date: Mon, 26 Feb 2024 15:08:24 -0500 Subject: [PATCH 2/2] Remove extraneous string --- .../block-editor/src/components/list-view/block-select-button.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/block-editor/src/components/list-view/block-select-button.js b/packages/block-editor/src/components/list-view/block-select-button.js index b12d3866f8edd5..bc32baf9609d69 100644 --- a/packages/block-editor/src/components/list-view/block-select-button.js +++ b/packages/block-editor/src/components/list-view/block-select-button.js @@ -290,7 +290,6 @@ function ListViewBlockSelectButton( { positionLabel && isSticky && ( - text ) } { images.length ? (