From d9a1aafd9c719a35bff0fc47e1616762d2a82c63 Mon Sep 17 00:00:00 2001 From: Elaeagnifolia Date: Sun, 8 Nov 2020 23:37:33 -0600 Subject: [PATCH] Fix filename image dump bug for Gamepedia API Gamepedia's image files were moved to Wikia's image servers, so dumping images with the script - given a Gamepedia API - causes the same latest?cb= filename bug that Wikia/Fandom Wikis experienced (Issue #362). Example: https://dragalialost.gamepedia.com/File:Notte.png https://static.wikia.nocookie.net/dragalialost_gamepedia_en/images/e/e8/Notte.png/revision/latest?cb=20180919220831 --- dumpgenerator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dumpgenerator.py b/dumpgenerator.py index 536cd0ed..29843012 100755 --- a/dumpgenerator.py +++ b/dumpgenerator.py @@ -1373,7 +1373,7 @@ def getImageNamesAPI(config={}, session=None): url = curateImageURL(config=config, url=url) # encoding to ascii is needed to work around this horrible bug: # http://bugs.python.org/issue8136 - if 'api' in config and ('.wikia.' in config['api'] or '.fandom.com' in config['api']): + if 'api' in config and ('.wikia.' in config['api'] or '.fandom.com' in config['api'] or '.gamepedia.com' in config['api']): #to avoid latest?cb=20120816112532 in filenames filename = unicode(urllib.unquote((re.sub('_', ' ', url.split('/')[-3])).encode('ascii', 'ignore')), 'utf-8') else: