Skip to content

Commit 0b458c7

Browse files
committed
Review comments
1 parent fc8e63b commit 0b458c7

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

design/mvp/Binary.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,8 @@ instancedecl ::= 0x00 t:<core:type> => t
228228
| 0x01 t:<type> => t
229229
| 0x02 a:<alias> => a
230230
| 0x04 ed:<exportdecl> => ed
231-
importdecl ::= in:<importname> ed:<externdesc> => (import in ed)
232-
exportdecl ::= en:<exportname> ed:<externdesc> => (export en ed)
231+
importdecl ::= in:<importname'> ed:<externdesc> => (import in ed)
232+
exportdecl ::= en:<exportname'> ed:<externdesc> => (export en ed)
233233
externdesc ::= 0x00 0x11 i:<core:typeidx> => (core module (type i))
234234
| 0x01 i:<typeidx> => (func (type i))
235235
| 0x02 b:<valuebound> => (value b) 🪙
@@ -388,12 +388,12 @@ in the explainer.)
388388
```ebnf
389389
import ::= in:<importname> ed:<externdesc> => (import in ed)
390390
export ::= en:<exportname> si:<sortidx> ed?:<externdesc>? => (export en si ed?)
391-
importname ::= 0x00 len:<u32> in:<importname> => in (if len = |in|)
391+
importname' ::= 0x00 len:<u32> in:<importname> => in (if len = |in|)
392392
| 0x01 len:<u32> in:<importname> => in (if len = |in|)
393393
| 0x02 len:<u32> in:<importname> vs:<versionsuffix> => in vs (if len = |in|) 🔗
394-
exoprtname ::= 0x00 len:<u32> in:<exoprtname> => in (if len = |in|)
395-
| 0x01 len:<u32> in:<exoprtname> => in (if len = |in|)
396-
| 0x02 len:<u32> in:<exoprtname> vs:<versionsuffix> => in vs (if len = |in|) 🔗
394+
exportname' ::= 0x00 len:<u32> in:<exportname> => in (if len = |in|)
395+
| 0x01 len:<u32> in:<exportname> => in (if len = |in|)
396+
| 0x02 len:<u32> in:<exportname> vs:<versionsuffix> => in vs (if len = |in|) 🔗
397397
versionsuffix ::= len:<u32> vs:<semversuffix> => (versionsuffix vs) (if len = |vs|) 🔗
398398
```
399399

@@ -408,7 +408,7 @@ Notes:
408408
of the inferred `externdesc` of the `sortidx`.
409409
* `<importname>` and `<exportname>` refer to the productions defined in the
410410
[text format](Explainer.md#import-and-export-definitions).
411-
* `<importname>` and `<exportname>` will [be cleaned up for a 1.0
411+
* `<importname'>` and `<exportname'>` will [be cleaned up for a 1.0
412412
release](##binary-format-warts-to-fix-in-a-10-release).
413413
* The `<importname>`s of a component must all be [strongly-unique]. Separately,
414414
the `<exportname>`s of a component must also all be [strongly-unique].
@@ -523,7 +523,7 @@ named once.
523523
* The two `depname` cases should be merged into one (`dep=<...>`)
524524
* The two `list` type codes should be merged into one with an optional immediate
525525
and similarly for `func`.
526-
* The `0x00` and `0x01` variant of `importname` and `exportname` will be
526+
* The `0x00` and `0x01` variant of `importname'` and `exportname'` will be
527527
removed. Any remaining variant(s) will be renumbered or the prefix byte will
528528
be removed or repurposed.
529529
* Most built-ins should have a `<canonopt>*` immediate instead of an ad hoc

0 commit comments

Comments
 (0)