feat(autocomplete): don't search unless length is 3

eliandoran · eliandoran · commit fd53e35f6fe8 · 2025-03-29T22:22:51.000+02:00
diff --git a/src/public/app/services/note_autocomplete.ts b/src/public/app/services/note_autocomplete.ts
@@ -70,9 +70,14 @@ async function autocompleteSource(term: string, cb: (rows: Suggestion[]) => void
     }
 
     const activeNoteId = appContext.tabManager.getActiveContextNoteId();
+    const length = term.trim().length;
 
-    let results: Suggestion[] = await server.get<Suggestion[]>(`autocomplete?query=${encodeURIComponent(term)}&activeNoteId=${activeNoteId}&fastSearch=${fastSearch}`);
-    if (term.trim().length >= 1 && options.allowCreatingNotes) {
+    let results: Suggestion[] = [];
+    if (length >= 3) {
+        results = await server.get<Suggestion[]>(`autocomplete?query=${encodeURIComponent(term)}&activeNoteId=${activeNoteId}&fastSearch=${fastSearch}`);
+    }
+
+    if (length >= 1 && options.allowCreatingNotes) {
         results = [
             {
                 action: "create-note",
@@ -83,7 +88,7 @@ async function autocompleteSource(term: string, cb: (rows: Suggestion[]) => void
         ].concat(results);
     }
 
-    if (term.trim().length >= 1 && options.allowJumpToSearchNotes) {
+    if (length >= 1 && options.allowJumpToSearchNotes) {
         results = results.concat([
             {
                 action: "search-notes",

Original file line number	Diff line number	Diff line change
`@@ -70,9 +70,14 @@ async function autocompleteSource(term: string, cb: (rows: Suggestion[]) => void`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`const activeNoteId = appContext.tabManager.getActiveContextNoteId();`
	`73`	`+ const length = term.trim().length;`
`73`	`74`
`74`		- let results: Suggestion[] = await server.get<Suggestion[]>(`autocomplete?query=${encodeURIComponent(term)}&activeNoteId=${activeNoteId}&fastSearch=${fastSearch}`);
`75`		`- if (term.trim().length >= 1 && options.allowCreatingNotes) {`
	`75`	`+ let results: Suggestion[] = [];`
	`76`	`+ if (length >= 3) {`
	`77`	+ results = await server.get<Suggestion[]>(`autocomplete?query=${encodeURIComponent(term)}&activeNoteId=${activeNoteId}&fastSearch=${fastSearch}`);
	`78`	`+ }`
	`79`	`+`
	`80`	`+ if (length >= 1 && options.allowCreatingNotes) {`
`76`	`81`	`results = [`
`77`	`82`	`{`
`78`	`83`	`action: "create-note",`
`@@ -83,7 +88,7 @@ async function autocompleteSource(term: string, cb: (rows: Suggestion[]) => void`
`83`	`88`	`].concat(results);`
`84`	`89`	`}`
`85`	`90`
`86`		`- if (term.trim().length >= 1 && options.allowJumpToSearchNotes) {`
	`91`	`+ if (length >= 1 && options.allowJumpToSearchNotes) {`
`87`	`92`	`results = results.concat([`
`88`	`93`	`{`
`89`	`94`	`action: "search-notes",`