fix(desktop): use plugin to clean up languages

Author: eliandoran

apps/desktop/electron-forge/forge.config.cjs

@@ -1,6 +1,7 @@
 const path = require("path");
 const fs = require("fs-extra");
 const { LOCALES } = require("@triliumnext/commons");
+const setLanguages = require('electron-packager-languages');
 
 const ELECTRON_FORGE_DIR = __dirname;
 
@@ -29,6 +30,10 @@ const macosSignConfiguration = process.env.APPLE_ID ? {
     }
 } : undefined;
 
+const localesToKeep = LOCALES
+    .filter(locale => !locale.contentOnly)
+    .map(locale => locale.electronLocale);
+
 module.exports = {
     outDir: "out",
     // Documentation of `packagerConfig` options: https://electron.github.io/packager/main/interfaces/Options.html
@@ -45,6 +50,9 @@ module.exports = {
             ...(process.platform === "darwin" ? [] : extraResourcesForPlatform)
         ],
         prune: false,
+        afterCopy: [
+            setLanguages(localesToKeep)
+        ],
         afterComplete: [
             (buildPath, _electronVersion, platform, _arch, callback) => {
                 // Only move resources on non-macOS platforms
@@ -142,53 +150,6 @@ module.exports = {
         }
     ],
     hooks: {
-        // Remove unused locales from the packaged app to save some space.
-        postPackage(_, packageResult) {
-            const localesToKeep = LOCALES
-                .filter(locale => !locale.contentOnly)
-                .map(locale => locale.electronLocale.replace("_", "-"));
-            const keptLocales = new Set();
-            const removedLocales = [];
-
-            for (const outputPath of packageResult.outputPaths) {
-                const localesDir = path.join(outputPath, 'locales');
-
-                if (!fs.existsSync(localesDir)) {
-                    console.log('No locales directory found. Skipping cleanup.');
-                    return;
-                }
-
-                const files = fs.readdirSync(localesDir);
-
-                for (const file of files) {
-                    let localeName = path.basename(file, ".pak");
-                    if (localeName === "en-US" && process.platform === "win32") {
-                        // If the locale is "en-US" on Windows, we treat it as "en".
-                        // This is because the Windows version of Electron uses "en-US.pak" instead of "en.pak".
-                        localeName = "en";
-                    }
-
-                    if (localesToKeep.includes(localeName)) {
-                        keptLocales.add(localeName);
-                        continue;
-                    }
-
-                    const filePath = path.join(localesDir, file);
-                    fs.unlinkSync(filePath);
-                    removedLocales.push(file);
-                }
-            }
-
-            console.log(`Removed unused locale files: ${removedLocales.join(", ")}`);                    
-
-            // Ensure all locales that should be kept are actually present.
-            for (const locale of localesToKeep) {
-                if (!keptLocales.has(locale)) {
-                    console.error(`Locale ${locale} was not found in the packaged app.`);
-                    process.exit(1);
-                }
-            }
-        },
         // Gather all the artifacts produced by the makers and copy them to a common upload directory.
         postMake(_, makeResults) {
             const outputDir = path.join(__dirname, "..", "upload");

apps/desktop/package.json

@@ -10,14 +10,10 @@
     "electron-debug": "4.1.0",
     "electron-dl": "4.0.0",
     "electron-squirrel-startup": "1.0.1",
-    "jquery.fancytree": "2.38.5",
-    "jquery-hotkeys": "0.2.2"
+    "jquery-hotkeys": "0.2.2",
+    "jquery.fancytree": "2.38.5"
   },
   "devDependencies": {
-    "@types/electron-squirrel-startup": "1.0.2",
-    "@triliumnext/server": "workspace:*",
-    "copy-webpack-plugin": "13.0.0",
-    "electron": "36.4.0",
     "@electron-forge/cli": "7.8.1",
     "@electron-forge/maker-deb": "7.8.1",
     "@electron-forge/maker-dmg": "7.8.1",
@@ -26,6 +22,11 @@
     "@electron-forge/maker-squirrel": "7.8.1",
     "@electron-forge/maker-zip": "7.8.1",
     "@electron-forge/plugin-auto-unpack-natives": "7.8.1",
+    "@triliumnext/server": "workspace:*",
+    "@types/electron-squirrel-startup": "1.0.2",
+    "copy-webpack-plugin": "13.0.0",
+    "electron": "36.4.0",
+    "electron-packager-languages": "0.6.0",
     "prebuild-install": "^7.1.1"
   },
   "config": {
@@ -75,7 +76,7 @@
             "cjs"
           ],
           "thirdParty": true,
-          "declaration": false,          
+          "declaration": false,
           "esbuildOptions": {
             "splitting": false,
             "loader": {