Fix Webpack compatibility

.changeset/happy-planets-hang.md

@@ -0,0 +1,11 @@
+---
+'@theoplayer/adscript-connector-web': patch
+'@theoplayer/comscore-connector-web': patch
+'@theoplayer/conviva-connector-web': patch
+'@theoplayer/nielsen-connector-web': patch
+'@theoplayer/yospace-connector-web': patch
+'@theoplayer/gemius-connector-web': patch
+'@theoplayer/cmcd-connector-web': patch
+---
+
+Fixed an issue where Webpack would incorrectly prefer the UMD version over the ESM version.

.changeset/sixty-candies-doubt.md

@@ -0,0 +1,6 @@
+---
+'@theoplayer/conviva-connector-web': patch
+---
+
+Fixed an issue that prevented the ESM build from being loaded by certain bundlers.
+ - The ESM build now imports the Conviva SDK using a namespace import (`import * as Conviva from '@convivainc/conviva-js-coresdk'`) and will auto-detect if the Conviva SDK was exported as a single `default` export or as named exports.

adscript/package.json

@@ -10,6 +10,7 @@
     ".": {
       "types": "./dist/types/index.d.ts",
       "import": "./dist/adscript-connector.esm.js",
+      "webpack": "./dist/adscript-connector.esm.js",
       "require": "./dist/adscript-connector.umd.js"
     },
     "./dist/*": "./dist/*",

cmcd/package.json

@@ -19,6 +19,7 @@
     ".": {
       "types": "./dist/types/index.d.ts",
       "import": "./dist/cmcd-connector.esm.js",
+      "webpack": "./dist/cmcd-connector.esm.js",
       "require": "./dist/cmcd-connector.umd.js"
     },
     "./dist/*": "./dist/*",

comscore/package.json

@@ -10,6 +10,7 @@
     ".": {
       "types": "./dist/types/index.d.ts",
       "import": "./dist/comscore-connector.esm.js",
+      "webpack": "./dist/comscore-connector.esm.js",
       "require": "./dist/comscore-connector.umd.js"
     },
     "./dist/*": "./dist/*",

conviva/package.json

@@ -11,6 +11,7 @@
     ".": {
       "types": "./dist/types/index.d.ts",
       "import": "./dist/conviva-connector.esm.js",
+      "webpack": "./dist/conviva-connector.esm.js",
       "require": "./dist/conviva-connector.umd.js"
     },
     "./dist/*": "./dist/*",

conviva/src/integration/ConvivaHandler.ts

@@ -210,7 +210,7 @@ export class ConvivaHandler {
         this.player.removeEventListener('durationchange', this.onDurationChange);
         this.player.removeEventListener('destroy', this.onDestroy);
 
-        this.player.network.removeEventListener('offline', this.onNetworkOffline);
+        this.player.network?.removeEventListener('offline', this.onNetworkOffline);
 
         document.removeEventListener('visibilitychange', this.onVisibilityChange);
         window.removeEventListener('beforeunload', this.onBeforeUnload);

conviva/src/utils/ConvivaSdk.ts

@@ -1,7 +1,9 @@
-// Use default import, so Rollup can insert its interop helpers.
-import Conviva from '@convivainc/conviva-js-coresdk';
+import * as Conviva from '@convivainc/conviva-js-coresdk';
 
-// Re-create Conviva's namespace.
-const { Analytics, Constants } = Conviva;
+// Conviva is distributed as CommonJS, so depending on the user's bundler choice
+// we will either get a single default export or separate named exports.
+const { Analytics, Constants } = 'Constants' in Conviva ? Conviva : ((Conviva as any).default as typeof Conviva);
+
+// Re-export the Conviva SDK as *actual* named exports.
 export { Analytics, Constants };
 export type * from '@convivainc/conviva-js-coresdk';

gemius/package.json

@@ -10,6 +10,7 @@
     ".": {
       "types": "./dist/types/index.d.ts",
       "import": "./dist/gemius-connector.esm.js",
+      "webpack": "./dist/gemius-connector.esm.js",
       "require": "./dist/gemius-connector.umd.js"
     },
     "./dist/*": "./dist/*",

gemius/src/integration/GemiusTHEOIntegration.ts

@@ -89,8 +89,10 @@ export class GemiusTHEOIntegration {
         this.player.removeEventListener('seeking', this.onSeeking);
         this.player.removeEventListener('ended', this.onEnded);
         this.player.removeEventListener('volumechange', this.onVolumeChange);
-        this.player.videoTracks.removeEventListener('addtrack', this.onAddTrack);
-        this.player.videoTracks.removeEventListener('removetrack', this.onRemoveTrack);
+        if (this.player.videoTracks) {
+            this.player.videoTracks.removeEventListener('addtrack', this.onAddTrack);
+            this.player.videoTracks.removeEventListener('removetrack', this.onRemoveTrack);
+        }
         if (this.player.ads) {
             this.player.ads.removeEventListener('adbreakbegin', this.onAdBreakBegin);
             this.player.ads.removeEventListener('adbreakend', this.onAdBreakEnd);

nielsen/package.json

@@ -10,6 +10,7 @@
     ".": {
       "types": "./dist/types/index.d.ts",
       "import": "./dist/nielsen-connector.esm.js",
+      "webpack": "./dist/nielsen-connector.esm.js",
       "require": "./dist/nielsen-connector.umd.js"
     },
     "./dist/*": "./dist/*",

nielsen/src/integration/NielsenHandler.ts

@@ -113,7 +113,7 @@ export class NielsenHandler {
         this.player.removeEventListener('durationchange', this.onDurationChange);
         this.player.removeEventListener('timeupdate', this.onTimeUpdate);
 
-        this.player.textTracks.removeEventListener('addtrack', this.onAddTrack);
+        this.player.textTracks?.removeEventListener('addtrack', this.onAddTrack);
 
         if (this.player.ads) {
             this.player.ads.removeEventListener('adbegin', this.onAdBegin);

yospace/package.json

@@ -19,6 +19,7 @@
     ".": {
       "types": "./dist/types/index.d.ts",
       "import": "./dist/yospace-connector.esm.js",
+      "webpack": "./dist/yospace-connector.esm.js",
       "require": "./dist/yospace-connector.umd.js"
     },
     "./dist/*": "./dist/*",