Skip to content

Commit f16c356

Browse files
authored
Merge pull request #3980 from SwiftPackageIndex/pr-3977
Push the footer down on pages that do not fill the viewport
2 parents b32b045 + e6afba4 commit f16c356

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

FrontEnd/styles/base.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
}
2222

2323
body {
24+
min-height: 100vh;
2425
font-family:
2526
-apple-system, BlinkMacSystemFont, 'SF Hello', 'Segoe UI', Roboto, 'Helvetica Neue', Arial, sans-serif,
2627
'Apple Color Emoji', 'Segoe UI Emoji';

FrontEnd/styles/header_footer.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,9 @@ header {
107107
// Footer specific.
108108

109109
footer {
110+
position: sticky;
111+
top: 100vh;
112+
110113
.inner {
111114
padding: 20px 10px;
112115
}

Sources/App/Views/PublicPage.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,6 @@ class PublicPage {
263263
main(),
264264
postMain(),
265265
footer(),
266-
stagingBanner(),
267266
postBody(),
268267
frontEndDebugPanel()
269268
)

Tests/AppTests/__Snapshots__/WebpageSnapshotTests/HomeIndex_document_development.1.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -244,9 +244,6 @@ <h3>Recent Releases</h3>
244244
</nav>
245245
</div>
246246
</footer>
247-
<div class="staging">This is a staging environment. For live and up-to-date package information,
248-
<a href="https://swiftpackageindex.com">visit swiftpackageindex.com</a>.
249-
</div>
250247
<script type="application/ld+json">{"@context":"https://schema.org","@type":"WebSite","potentialAction":{"@context":"https://schema.org","@type":"SearchAction","query-input":"required name=search_term_string","target":{"@context":"https://schema.org","@type":"EntryPoint","urlTemplate":"http://localhost:8080/search?query={search_term_string}"}},"url":"http://localhost:8080/"}</script>
251248
<spi-debug-panel class="hidden">
252249
<table>

0 commit comments

Comments
 (0)