Merge pull request #4037 from SwiftPackageIndex/update-success-rate-check

Update success rate check

Author: finestructure

Sources/App/Commands/Alerting.swift

@@ -275,8 +275,7 @@ extension [Alerting.BuildInfo] {
 
     func validateSuccessRateInRange() -> Alerting.Validation {
         let successRate = Double(filter { $0.status == .ok }.count) / Double(count)
-        // Success rate has been around 30% generally
-        if 0.15 <= successRate && successRate <= 0.45 {
+        if 0.15 <= successRate && successRate <= 0.85 {
             return .ok
         } else {
             let percentSuccessRate = (successRate * 1000).rounded() / 10

Tests/AppTests/AlertingTests.swift

@@ -117,12 +117,12 @@ extension AllTests.AlertingTests {
             #expect(all.validateSuccessRateInRange() == .failed(reasons: ["Global success rate of 14.9% out of bounds"]))
         }
         do {
-            let okCount = 451
+            let okCount = 851
             let failedCount = 1000 - okCount
             let okBuilds = (0..<okCount).map { _ in Alerting.BuildInfo.mock(status: .ok) }
             let failedBuilds = (0..<failedCount).map { _ in Alerting.BuildInfo.mock(status: .failed) }
             let all = okBuilds + failedBuilds
-            #expect(all.validateSuccessRateInRange() == .failed(reasons: ["Global success rate of 45.1% out of bounds"]))
+            #expect(all.validateSuccessRateInRange() == .failed(reasons: ["Global success rate of 85.1% out of bounds"]))
         }
     }