multiply initial dt by random number to prevent numerical coincendences#3127
Open
oscardssmith wants to merge 2 commits intomasterfrom
Open
multiply initial dt by random number to prevent numerical coincendences#3127oscardssmith wants to merge 2 commits intomasterfrom
oscardssmith wants to merge 2 commits intomasterfrom
Conversation
Previously our initial dt was very likely to be a power of 10 which can cause odd numerical issues (e.g. if it lines up exactly with the period of a sign wave). This is exacerbated dramatically with the inital_qmax raise to 10000 since a dt of 1e-4 amplifys to a dt of 1.0 after an inital step (if the inital step had no error) and something like ~30% of ODEs have something special happen at t=1
Member
|
a lot more failures than expected |
Member
Author
|
I think a number of them are failing on master it's hard to imagine that this change would cause failures in performstep |
Member
|
No |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously our initial dt was very likely to be a power of 10 which can cause odd numerical issues (e.g. if it lines up exactly with the period of a sign wave). This is exacerbated dramatically with the inital_qmax raise to 10000 since a dt of 1e-4 amplifys to a dt of 1.0 after an inital step (if the inital step had no error) and something like ~30% of ODEs have something special happen at t=1