Commit 75e50e5
Revert DAEProblem initdt to original 1e-6*tdist formula and fix test tolerances
The DAEProblem ode_determine_initdt was inadvertently changed from 1e-6*tdist
to 0.001*tdist in the initial StiffInitDt commit. This 1000x larger initial
step caused chaotic divergence between SArray and Array DFBDF DAE solutions.
Also updates the NonlinearSolve newton test to use proportional nf tolerance
(2%) instead of absolute (+20), since exact nf counts depend on initial step
size selection which differs between DefaultInitDt and StiffInitDt.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent 8763701 commit 75e50e5
3 files changed
Lines changed: 8 additions & 12 deletions
File tree
- lib
- OrdinaryDiffEqCore/src
- OrdinaryDiffEqNonlinearSolve/test
- test/interface
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
835 | 835 | | |
836 | 836 | | |
837 | 837 | | |
838 | | - | |
| 838 | + | |
839 | 839 | | |
840 | | - | |
841 | 840 | | |
842 | 841 | | |
843 | 842 | | |
| |||
847 | 846 | | |
848 | 847 | | |
849 | 848 | | |
850 | | - | |
851 | 849 | | |
852 | | - | |
853 | | - | |
854 | | - | |
855 | | - | |
856 | | - | |
857 | | - | |
858 | | - | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
859 | 853 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
20 | 22 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
297 | | - | |
| 297 | + | |
0 commit comments