Implement fd_datasync, fd_sync, and fd_renumber WASI functions #401
Implement fd_datasync, fd_sync, and fd_renumber WASI functions #401ksh8281 merged 4 commits intoSamsung:mainfrom
Conversation
| @@ -0,0 +1,81 @@ | |||
| (module | |||
There was a problem hiding this comment.
Welcome to the project!
By the way, could you let me know where these test codes came from?
Did you create them yourself?
There was a problem hiding this comment.
I implemented this by referencing the existing tests in src/test/wasi/. To determine the correct rights values and expected error cases, I consulted wasi_types.h, uvwasi.h, and uvwasi.c within third_party
Could you please review this and let me know if I got these details right?
|
Rebase this patch after #403 landed |
Signed-off-by: M-SE0K <seg082911@gmail.com>
Signed-off-by: M-SE0K <seg082911@gmail.com>
Signed-off-by: M-SE0K <seg082911@gmail.com>
|
Done! I've rebased the branch. |
zherczeg
left a comment
zherczeg
left a comment
There was a problem hiding this comment.
LGTM with minor changes
|
|
||
| result[0] = Value(uvwasi_fd_sync(WASI::g_uvwasi, fd)); | ||
| } | ||
| void WASI::fd_renumber(ExecutionState& state, Value* argv, Value* result, Instance* instance) |
There was a problem hiding this comment.
Please add newlines between the functions.
There was a problem hiding this comment.
Done. I've added the newlines between functions and updated the commit. Thanks for the review!
Signed-off-by: M-SE0K <seg082911@gmail.com>
M-SE0K
force-pushed
the
feature/WASI
branch
2 times, most recently
from
0572f41 to
8d90b7b
Compare
4 participants
Uh oh!
There was an error while loading. Please reload this page.