feat: DAH-3577 Forms EasyPost address verification #2866
Open
feat: DAH-3577 Forms EasyPost address verification #2866
Conversation
alulabeshue-sfgov
temporarily deployed
to
dahlia-webap-dah-3577-a-orahjn
cliu02
changed the title
cliu02
changed the title
cliu02
commented
Apr 17, 2026
| } | ||
| case "HouseholdMemberVerifyAddress": { | ||
| return <VerifyAddress /> | ||
| return <VerifyAddress fieldNames={{ verifiedAddress: "householdMemberAddress" }} /> |
Collaborator
Author
There was a problem hiding this comment.
note: to be implemented in https://sfgovdt.jira.com/browse/DAH-3589
There was a problem hiding this comment.
Pull request overview
Adds an address verification step to the form engine flow by calling a new frontend API helper that posts addresses to an /api/v1/addresses/validate.json endpoint and renders a “Verify Address” page for user confirmation.
Changes:
- Introduces
VerifyAddresspage that fetches a verified address, displays it, and writes the verified values back toformDataon confirmation. - Adds
locateVerifiedAddresstoformApiServiceplus supporting types and unit tests. - Adds a small address formatting utility and styles for the new verify-address UI.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| app/javascript/util/formEngineUtil.ts | Adds getFormattedAddress helper for display formatting. |
| app/javascript/pages/form/components/household/HouseholdMemberMultiStepWrapper.tsx | Passes address prop to VerifyAddress for household-member usage. |
| app/javascript/pages/form/components/VerifyAddress.tsx | Implements the address verification UI + data writeback + API call. |
| app/javascript/pages/form/components/VerifyAddress.module.scss | Styles layout for the verify address section. |
| app/javascript/pages/form/components/ListingApplyStepWrapper.module.scss | Adds .no-back variant styling for step titles. |
| app/javascript/api/formApiService.ts | Adds locateVerifiedAddress and response/request typing. |
| app/javascript/tests/pages/form/components/VerifyAddress.test.tsx | Adds component tests for the verify address step UI/behavior. |
| app/javascript/tests/api/formApiService.test.ts | Adds a unit test for locateVerifiedAddress. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jimlin-sfgov
requested changes
Apr 23, 2026
Collaborator
There was a problem hiding this comment.
There are some inter-page behaviors that are not the same as the Angular version:
- when entering an invalid address, there is a browser alert, and then user is sent back to the contact page with no error messaging
- when on the page after address verification, clicking "back" will go back to the address verification page
Also, some styling differences around spacing:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Creates the form engine page for address verification and API call to EasyPost to get a verified address.
Jira ticket
https://sfgovdt.jira.com/browse/DAH-3577
Before requesting eng review
Version Control
angularif it contains updates to Angular codetype: TICKET-NUMBER Descriptionformat, useDAH-000if it does not need a ticketurgent: Descriptionformat if it is urgent and does not need a ticketCode quality
Code conventions
.scssstylesheets andui-seedstokens, rather than inline styles or TailwindReview instructions
Request eng review
needs reviewlabelHousing Enggroup to automatically assign reviewers, and/or assign specific engineersBefore merging
Request product acceptance (PA) testing
needs product acceptancelabel)