AFF for Lock Objects (ENQU) by anne-hobbs · Pull Request #737 · SAP/abap-file-formats

anne-hobbs · 2026-02-03T10:44:15Z

AFF definition for Lock Objects (ENQU)

cla-assistant · 2026-02-03T10:44:29Z

All committers have signed the CLA.

cla-assistant · 2026-02-03T10:44:32Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

schneidermic0

Thanks @anne-hobbs for your contribution. 👍

In a first iteration I went only over the example file and added some suggestions/ideas/questions there.

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: Michael Schneider <micha.schneider@sap.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

albertmink · 2026-04-08T08:51:18Z

@anne-hobbs f7d1d5f adds the missing metadata file for the ABAP interface

albertmink · 2026-04-08T09:08:07Z

@larshp just wanted to let you know that the JSON Schema generation looks off. Maybe you know more?
To me, it looks like this is not related to the repository/pr here. Looks more like a tool issue.

larshp · 2026-04-08T14:43:04Z

yea, its fixed, with the commit above updating the branch

wurzka

@anne-hobbs, thanks for the adaption. My review now is based on the structure of the AFF & mandatory fields. Please see my comments.

And @larshp, thanks for fixing 🙏

github-actions · 2026-04-20T17:43:25Z

ABAP Doc Checks

Run ABAP Doc title/description casing check

New commits with ABAP changes were pushed. Check the box to run again.

wurzka

Thanks for your changes. There is just one minor left from my site.

Co-authored-by: Katharina Wurz <katharina.wurz@sap.com>

albertmink

Hi @anne-hobbs I went over the file format and I kindly ask to fine tune the Title and Descriptions to better align, see also screenshot where some entries end by Lock others don't. These changes don't affect the data model, just tune the text in the JSON Schema.

Btw. I'm aware that the enum is inspired by (not aligned naming pattern either)

albertmink · 2026-04-21T09:19:08Z

+  "! $default { @link zif_aff_enqu_v1.data:co_lock_modes.exclusive }
+  TYPES ty_lock_mode TYPE c LENGTH 1.
+  CONSTANTS:
+    BEGIN OF co_lock_modes,


Some title/description pairs contain .. Lock and some don't, which doesn't LGTM.

Please check again, I just updated the JSON and the Interface.

Co-authored-by: Albert Mink <albert.mink@sap.com>

albertmink · 2026-04-21T11:53:59Z

Hi @anne-hobbs you'll need to generate/update the JSON Schema

albertmink

LGTm

wurzka

LGTM :)
Welcome @anne-hobbs as contributor to our ABAP File Formats repository 🥳

anne-hobbs added 4 commits February 3, 2026 11:40

Create README.md

4fb4ba4

Create enqu-v1.json

92e483c

Create zif_aff_enqu_v1.intf.abap

15e629b

Create z_aff_example_enqu.enqu.json

a1d8382

albertmink added the new-object This is a new object type added to AFF label Feb 3, 2026

schneidermic0 reviewed Feb 3, 2026

View reviewed changes

Merge branch 'main' into main

6a97b7a

albertmink reviewed Feb 4, 2026

View reviewed changes

Comment thread file-formats/enqu/README.md Outdated

anne-hobbs and others added 20 commits February 25, 2026 09:59

Merge branch 'SAP:main' into main

2f9ec0d

Update enqu-v1.json

c8ffba0

Update zif_aff_enqu_v1.intf.abap

195c53a

Rename z_aff_example_enqu.enqu.json to z_aff_enqu_ex.enqu.json

5327bf4

Update z_aff_enqu_ex.enqu.json

2c90827

Update z_aff_enqu_ex.enqu.json

01c46ad

Update README.md

e6bf9ca

Update file-formats/enqu/type/zif_aff_enqu_v1.intf.abap

e0fbd48

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Update file-formats/enqu/examples/z_aff_enqu_ex.enqu.json

c31be6a

Co-authored-by: Michael Schneider <micha.schneider@sap.com>

Update z_aff_enqu_ex.enqu.json

851f557

Update file-formats/enqu/examples/z_aff_enqu_ex.enqu.json

3713a91

Co-authored-by: Michael Schneider <micha.schneider@sap.com>

Update z_aff_enqu_ex.enqu.json

5f9a826

Update file-formats/enqu/type/zif_aff_enqu_v1.intf.abap

48b00bc

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Update file-formats/enqu/type/zif_aff_enqu_v1.intf.abap

e65dc13

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Update file-formats/enqu/type/zif_aff_enqu_v1.intf.abap

a56d548

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Update file-formats/enqu/type/zif_aff_enqu_v1.intf.abap

0028526

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Update file-formats/enqu/type/zif_aff_enqu_v1.intf.abap

a9730a5

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Update file-formats/enqu/type/zif_aff_enqu_v1.intf.abap

39594b5

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Update file-formats/enqu/type/zif_aff_enqu_v1.intf.abap

bf3a5a7

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Update zif_aff_enqu_v1.intf.abap

41f5c3c

Merge branch 'main' into main

b3c87a9

Merge branch 'main' into main

9571e88

wurzka requested changes Apr 8, 2026

View reviewed changes

Comment thread file-formats/enqu/type/zif_aff_enqu_v1.intf.abap

Comment thread file-formats/enqu/type/zif_aff_enqu_v1.intf.abap

Comment thread file-formats/enqu/type/zif_aff_enqu_v1.intf.abap Outdated

Comment thread file-formats/enqu/type/zif_aff_enqu_v1.intf.abap

Update zif_aff_enqu_v1.intf.abap

16c9d76

wurzka self-assigned this Apr 14, 2026

wurzka and others added 6 commits April 14, 2026 15:53

Merge branch 'main' into main

c843d62

Update enqu-v1.json

79bdef3

Update zif_aff_enqu_v1.intf.abap

1779ae0

Update z_aff_enqu_ex.enqu.json

0c9744f

Update zif_aff_enqu_v1.intf.abap

178d634

Merge branch 'main' into main

7b7624f

wurzka mentioned this pull request Apr 20, 2026

Fix ABAP Doc Casing Check permissions for fork PRs #768

Merged

Merge branch 'main' into main

8b48368

wurzka requested changes Apr 21, 2026

View reviewed changes

Comment thread file-formats/enqu/examples/z_aff_enqu_ex.enqu.json Outdated

Update file-formats/enqu/examples/z_aff_enqu_ex.enqu.json

96a97df

Co-authored-by: Katharina Wurz <katharina.wurz@sap.com>

anne-hobbs requested a review from wurzka April 21, 2026 09:01

albertmink reviewed Apr 21, 2026

View reviewed changes

Comment thread file-formats/enqu/examples/z_aff_enqu_ex.enqu.json Outdated

albertmink reviewed Apr 21, 2026

View reviewed changes

anne-hobbs and others added 4 commits April 21, 2026 13:19

Update file-formats/enqu/examples/z_aff_enqu_ex.enqu.json

a719f25

Co-authored-by: Albert Mink <albert.mink@sap.com>

Update file-formats/enqu/type/zif_aff_enqu_v1.intf.abap

fc82ce3

Co-authored-by: Albert Mink <albert.mink@sap.com>

Update enqu-v1.json

9a6da30

Update zif_aff_enqu_v1.intf.abap

8dc0c5a

albertmink approved these changes Apr 21, 2026

View reviewed changes

wurzka approved these changes Apr 21, 2026

View reviewed changes

wurzka merged commit b92c5f9 into SAP:main Apr 21, 2026
11 checks passed

Conversation

anne-hobbs commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cla-assistant Bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cla-assistant Bot commented Feb 3, 2026

Uh oh!

schneidermic0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

albertmink commented Apr 8, 2026

Uh oh!

albertmink commented Apr 8, 2026

Uh oh!

larshp commented Apr 8, 2026

Uh oh!

wurzka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ABAP Doc Checks

Uh oh!

wurzka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

albertmink left a comment

Choose a reason for hiding this comment

Uh oh!

albertmink Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

anne-hobbs Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

albertmink commented Apr 21, 2026

Uh oh!

albertmink left a comment

Choose a reason for hiding this comment

Uh oh!

wurzka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

anne-hobbs commented Feb 3, 2026 •

edited

Loading

cla-assistant Bot commented Feb 3, 2026 •

edited

Loading

github-actions Bot commented Apr 20, 2026 •

edited

Loading