Skip to content

Commit a9a9903

Browse files
committed
testsuite: classify Cygwin full-path rename race
1 parent 0b66be7 commit a9a9903

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

‎testsuite/rename-fullpath-symlink-race_test.py‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,15 @@
1717
# with no rsync.c instrumentation -- a separate-process flipper wins the race.
1818

1919
import os
20+
import platform
2021
import subprocess
2122
import time
2223

23-
from rsyncfns import race_budget, SCRATCHDIR, rmtree, rsync_argv, test_fail
24+
from rsyncfns import (
25+
race_budget, SCRATCHDIR, rmtree, rsync_argv, test_fail, test_xfail,
26+
)
27+
28+
_CYGWIN = platform.system().startswith('CYGWIN')
2429

2530
# Unique per-invocation base: this test's rename storm can corrupt the `dest`
2631
# directory on some filesystems (OpenBSD FFS leaves an un-removable dir), and a
@@ -100,6 +105,10 @@ def push():
100105
escaped = sorted(p.name for p in outside.iterdir()
101106
if p.is_file() and not p.is_symlink())
102107
if escaped:
108+
if _CYGWIN:
109+
test_xfail(
110+
"cygwin: the full-path rename race still writes outside "
111+
"the destination -- documented Cygwin platform residual")
103112
test_fail(
104113
"rename-fullpath symlink race: files were written OUTSIDE the "
105114
f"destination tree ({escaped}) -- finish_transfer's tmp->final "

0 commit comments

Comments
 (0)