Skip to content

Commit 2ebd73a

Browse files
committed
testsuite: accept the -M local-transfer breakage in the backport skip list
fake-super-acl-xattr is the last test the 3.5.0 suite still fails on this branch, and unlike the other entries it is not an absent feature: any --remote-option on a local transfer makes the receiver write to the current directory instead of the destination, silently and with exit 0. It predates every security commit here, stock 3.2.7 does the same when given -s, and v3.4.1 and 3.5.0 are unaffected. We are shipping that, so the test is excluded -- but in its own section, with the defect described and pointing at the analysis, because silencing a real failure in the same list as "this feature does not exist" is how it stops being remembered. Anything that reads this list needs to see the difference.
1 parent 0d709b1 commit 2ebd73a

1 file changed

Lines changed: 17 additions & 0 deletions

File tree

‎testsuite/skiplist/backport.txt‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,20 @@ rrsync-no-overwrite-backup-collision
3333
rrsync-no-overwrite-delay-updates
3434
rrsync-no-overwrite-logfile
3535
rrsync-no-overwrite-partial-dir
36+
37+
# --- KNOWN BUG, DELIBERATELY ACCEPTED -------------------------------------
38+
# Everything above is a feature or helper this branch does not have. This one
39+
# is different: it is a REAL DEFECT in this branch that we have chosen to ship.
40+
#
41+
# Any --remote-option (-M) on a LOCAL transfer makes the receiver write to the
42+
# process's current directory instead of the destination -- silently, with exit
43+
# 0 and a normal transfer summary. fake-super-acl-xattr is simply the only
44+
# test in the 3.5.0 suite that uses -M on a local copy, so it is the only one
45+
# that catches it. Stock 3.2.7 fails the same way when given -s; v3.4.1 and
46+
# 3.5.0 are unaffected; the breakage predates every security commit on this
47+
# branch. Full analysis, including the strace and what was ruled out, is in
48+
# dev-notes/v327-backport-remote-option-wrong-dir.txt.
49+
#
50+
# Remove this line if that bug is ever fixed -- it is the only thing watching
51+
# for it.
52+
fake-super-acl-xattr

0 commit comments

Comments
 (0)